From patchwork Thu Dec 17 17:06:04 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Jackson X-Patchwork-Id: 7875121 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 2E667BEEE5 for ; Thu, 17 Dec 2015 17:09:01 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3EEAB20460 for ; Thu, 17 Dec 2015 17:09:00 +0000 (UTC) Received: from lists.xen.org (lists.xenproject.org [50.57.142.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BC30B20254 for ; Thu, 17 Dec 2015 17:08:58 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1a9c0V-0005us-TM; Thu, 17 Dec 2015 17:06:23 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1a9c0T-0005tw-9n for xen-devel@lists.xenproject.org; Thu, 17 Dec 2015 17:06:21 +0000 Received: from [85.158.139.211] by server-11.bemta-5.messagelabs.com id 77/EC-24494-C8BE2765; Thu, 17 Dec 2015 17:06:20 +0000 X-Env-Sender: prvs=7867bb76c=Ian.Jackson@citrix.com X-Msg-Ref: server-14.tower-206.messagelabs.com!1450371978!11121974!2 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 24635 invoked from network); 17 Dec 2015 17:06:20 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-14.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 17 Dec 2015 17:06:20 -0000 X-IronPort-AV: E=Sophos;i="5.20,442,1444694400"; d="scan'208";a="320065444" From: Ian Jackson To: Date: Thu, 17 Dec 2015 17:06:04 +0000 Message-ID: <1450371968-27997-5-git-send-email-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1450371968-27997-1-git-send-email-ian.jackson@eu.citrix.com> References: <1450371968-27997-1-git-send-email-ian.jackson@eu.citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: Ian Jackson , Ian Campbell Subject: [Xen-devel] [OSSTEST PATCH 5/9] ms-planner: Improve an error message X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP I experienced this `die' due to mg-schema-test-database failing to borrow shared hosts properly, and added this Dumper for debugging. I have not bothered to improve any of the other quite terse `die's in ms-planner. Signed-off-by: Ian Jackson Acked-by: Ian Campbell --- ms-planner | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ms-planner b/ms-planner index fc65a5b..8c2e06f 100755 --- a/ms-planner +++ b/ms-planner @@ -319,7 +319,9 @@ END my ($reso, $shareix) = ($`, $1); my $share= $currentshare{$reso}; - die unless !!$share == !!$shareix; + die Dumper($reskey, $reso, $shareix, + $plan->{Allocations}{$reskey}, $currentshare{$reso}) + unless !!$share == !!$shareix; if ($share && $share->{OnlyPreparing}) { delete $plan->{Allocations}{$reskey};