From patchwork Tue Jan 5 15:36:21 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Ian Campbell X-Patchwork-Id: 7955821 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 28690BEEE5 for ; Tue, 5 Jan 2016 15:40:38 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4F05A20328 for ; Tue, 5 Jan 2016 15:40:37 +0000 (UTC) Received: from lists.xen.org (lists.xenproject.org [50.57.142.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 619492025B for ; Tue, 5 Jan 2016 15:40:36 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aGTgf-0005RE-LS; Tue, 05 Jan 2016 15:38:17 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aGTge-0005R8-8I for xen-devel@lists.xen.org; Tue, 05 Jan 2016 15:38:16 +0000 Received: from [193.109.254.147] by server-8.bemta-14.messagelabs.com id 7C/70-24450-763EB865; Tue, 05 Jan 2016 15:38:15 +0000 X-Env-Sender: prvs=80598d8b9=Ian.Campbell@citrix.com X-Msg-Ref: server-8.tower-27.messagelabs.com!1452008291!11078337!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 39995 invoked from network); 5 Jan 2016 15:38:12 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-8.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 5 Jan 2016 15:38:12 -0000 X-IronPort-AV: E=Sophos;i="5.20,525,1444694400"; d="scan'208";a="322975429" Message-ID: <1452008181.13361.328.camel@citrix.com> From: Ian Campbell To: Wei Liu , Doug Goldstein Date: Tue, 5 Jan 2016 15:36:21 +0000 In-Reply-To: <1452004651.13361.289.camel@citrix.com> References: <1450759603-24249-1-git-send-email-cardoe@cardoe.com> <20160104122805.GG9423@citrix.com> <568A7E3F.9020108@cardoe.com> <20160104142638.GA12639@citrix.com> <1452004651.13361.289.camel@citrix.com> X-Mailer: Evolution 3.18.2-1 MIME-Version: 1.0 X-DLP: MIA2 Cc: Daniel De Graaf , xen-devel@lists.xen.org, Ian Jackson , Stefano Stabellini Subject: Re: [Xen-devel] [PATCH] tools: make flask utils build unconditional X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP On Tue, 2016-01-05 at 14:37 +0000, Ian Campbell wrote: > > which on the basis of this discussion I wasn't expecting. I didn't see this > new file on i686 or ARM*. > > My baseline is from the last time I committed, which would be last year, so > maybe something other than my current batch of patches has caused this. > > I'm going to drop this one for now and (hopefully) get the rest of the > batch squared away. Afterwards I'll take another look (with a new baseline > filelist), but if someone can explain it in the meantime that would be > super. So with a fresh basline I still see: *** FILES DIFFER *** On i686 and ARM* I only see the (expected) second hunk. I think the i686 case is explainable by the lack of a hypervisor build there, but I'm unsure why ARM* and x86_64 should differ in this regard. config/Tools.mk is y only on x86_64, not on the others, which obviously explains things, but the question is why only on x86_64 (I presume this has always been the case and it was previously masked, but I've not checked). Ah, OK, I misread AX_ARG_DEFAULT_ENABLE([xsmpolicy], [Disable XSM policy compilation]) as being default disable, actually the default is "enabled iff checkpolicy is installed" and it happens to be that it is only installed in my x86_64 build env. So, in the end I think Wei was correct and this change will now, in some circumstances, end up installing a /boot/xenpolicy-*. So the question is do we mind that? Ian. --- ../FILE_LIST.BASE.staging.x86_64    2016-01-05 14:50:32.000000000 +0000 +++ ../FILE_LIST.staging.x86_64 2016-01-05 15:11:15.000000000 +0000 @@ -6,6 +6,7 @@  dist/install/boot/xen-4.7-unstable.gz  dist/install/boot/xen-4.gz  dist/install/boot/xen.gz +dist/install/boot/xenpolicy-4.7-unstable  dist/install/etc  dist/install/etc/bash_completion.d  dist/install/etc/bash_completion.d/xl.sh @@ -386,6 +387,12 @@  dist/install/usr/local/lib/xen/libexec  dist/install/usr/local/lib/xen/libexec/qemu-bridge-helper  dist/install/usr/local/sbin +dist/install/usr/local/sbin/flask-get-bool +dist/install/usr/local/sbin/flask-getenforce +dist/install/usr/local/sbin/flask-label-pci +dist/install/usr/local/sbin/flask-loadpolicy +dist/install/usr/local/sbin/flask-set-bool +dist/install/usr/local/sbin/flask-setenforce  dist/install/usr/local/sbin/gdbsx  dist/install/usr/local/sbin/gtracestat  dist/install/usr/local/sbin/gtraceview