From patchwork Fri Jan 8 06:38:50 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wen Congyang X-Patchwork-Id: 7982831 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 4EFF29F54F for ; Fri, 8 Jan 2016 06:42:27 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 807902017D for ; Fri, 8 Jan 2016 06:42:26 +0000 (UTC) Received: from lists.xen.org (lists.xenproject.org [50.57.142.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AEE6E20149 for ; Fri, 8 Jan 2016 06:42:25 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aHQhj-0004h9-I7; Fri, 08 Jan 2016 06:39:19 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aHQhi-0004gn-HJ for xen-devel@lists.xen.org; Fri, 08 Jan 2016 06:39:18 +0000 Received: from [85.158.137.68] by server-13.bemta-3.messagelabs.com id 15/5F-31443-5995F865; Fri, 08 Jan 2016 06:39:17 +0000 X-Env-Sender: wency@cn.fujitsu.com X-Msg-Ref: server-12.tower-31.messagelabs.com!1452235152!14520989!2 X-Originating-IP: [59.151.112.132] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 39984 invoked from network); 8 Jan 2016 06:39:15 -0000 Received: from cn.fujitsu.com (HELO heian.cn.fujitsu.com) (59.151.112.132) by server-12.tower-31.messagelabs.com with SMTP; 8 Jan 2016 06:39:15 -0000 X-IronPort-AV: E=Sophos;i="5.20,346,1444665600"; d="scan'208";a="2364573" Received: from unknown (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 08 Jan 2016 14:39:11 +0800 Received: from G08CNEXCHPEKD01.g08.fujitsu.local (unknown [10.167.33.80]) by cn.fujitsu.com (Postfix) with ESMTP id 2E2364189109; Fri, 8 Jan 2016 14:38:47 +0800 (CST) Received: from G08FNSTD140052.g08.fujitsu.local (10.167.226.52) by G08CNEXCHPEKD01.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server (TLS) id 14.3.181.6; Fri, 8 Jan 2016 14:38:46 +0800 From: Wen Congyang To: xen devel , Andrew Cooper Date: Fri, 8 Jan 2016 14:38:50 +0800 Message-ID: <1452235131-1861-5-git-send-email-wency@cn.fujitsu.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1452235131-1861-1-git-send-email-wency@cn.fujitsu.com> References: <1452235131-1861-1-git-send-email-wency@cn.fujitsu.com> MIME-Version: 1.0 X-Originating-IP: [10.167.226.52] X-yoursite-MailScanner-ID: 2E2364189109.A32AC X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: wency@cn.fujitsu.com X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Cc: Changlong Xie , Wei Liu , Ian Campbell , Wen Congyang , Ian Jackson , Shriram Rajagopalan , Yang Hongyang Subject: [Xen-devel] [PATCH v3 4/5] tools/libxc: error handling for the postcopy() callback X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Wen Congyang Reviewed-by: Andrew Cooper Reviewed-by: Yang Hongyang --- tools/libxc/xc_sr_save.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/libxc/xc_sr_save.c b/tools/libxc/xc_sr_save.c index e532168..e4ba560 100644 --- a/tools/libxc/xc_sr_save.c +++ b/tools/libxc/xc_sr_save.c @@ -791,7 +791,9 @@ static int save(struct xc_sr_context *ctx, uint16_t guest_type) if ( rc ) goto err; - ctx->save.callbacks->postcopy(ctx->save.callbacks->data); + rc = ctx->save.callbacks->postcopy(ctx->save.callbacks->data); + if ( rc <= 0 ) + goto err; rc = ctx->save.callbacks->checkpoint(ctx->save.callbacks->data); if ( rc <= 0 )