From patchwork Tue Jan 12 09:58:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Durrant X-Patchwork-Id: 8015691 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E186ABEEE5 for ; Tue, 12 Jan 2016 10:08:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6E8E7203A4 for ; Tue, 12 Jan 2016 10:08:24 +0000 (UTC) Received: from lists.xen.org (lists.xenproject.org [50.57.142.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DEAA120394 for ; Tue, 12 Jan 2016 10:08:22 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aIvpI-0007OG-Fv; Tue, 12 Jan 2016 10:05:20 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aIvpG-0007NQ-Il for xen-devel@lists.xenproject.org; Tue, 12 Jan 2016 10:05:18 +0000 Received: from [85.158.137.68] by server-3.bemta-3.messagelabs.com id EF/0F-02499-DDFC4965; Tue, 12 Jan 2016 10:05:17 +0000 X-Env-Sender: prvs=81273039b=Paul.Durrant@citrix.com X-Msg-Ref: server-16.tower-31.messagelabs.com!1452593114!7789750!2 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 58567 invoked from network); 12 Jan 2016 10:05:16 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-16.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 12 Jan 2016 10:05:16 -0000 X-IronPort-AV: E=Sophos;i="5.20,556,1444694400"; d="scan'208";a="330595757" From: Paul Durrant To: Date: Tue, 12 Jan 2016 09:58:56 +0000 Message-ID: <1452592736-6463-3-git-send-email-paul.durrant@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1452592736-6463-1-git-send-email-paul.durrant@citrix.com> References: <1452592736-6463-1-git-send-email-paul.durrant@citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: Keir Fraser , Ian Campbell , Tim Deegan , Ian Jackson , Paul Durrant , Jan Beulich Subject: [Xen-devel] [PATCH v7 2/2] public/io/netif.h: document control ring and toeplitz hashing X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch documents a new shared ring between frontend and backend that can be used to pass bulk out-of-band data, such as that required to implement toeplitz hashing in the backend such that it is configurable by the frontend (which is needed to support NDIS RSS for Windows guests). The patch then goes on to document the messages passed over the control ring that can be used to configure toeplitz hashing and a new extra info fragment that can be used to pass hash values between frontend and backend for both transmit and receive packets. Signed-off-by: Paul Durrant Cc: Ian Campbell Cc: Ian Jackson Cc: Jan Beulich Cc: Keir Fraser Cc: Tim Deegan Acked-by: Ian Campbell --- v7: - s/feature-control-ring/feature-ctrl-ring/g for consistency v5: - Clarify the control API for toeplitz hashing in many places. - Add messages for getting and setting mapping table order to allow for a table that is larger than can be mapped by a single grant reference. - Fold in the definition of the new extra info type for passing hash values and make it toeplitz specific. v4: - Fix netif_ctrl_response_t definition to match specification. v3: - Fix commit comment. v2: - Use a balanced fix-sized message ring for the control ring (bulk data now passed by grant reference). --- xen/include/public/io/netif.h | 380 +++++++++++++++++++++++++++++++++++++++++- 1 file changed, 379 insertions(+), 1 deletion(-) diff --git a/xen/include/public/io/netif.h b/xen/include/public/io/netif.h index 0a3272f..fe0a87f 100644 --- a/xen/include/public/io/netif.h +++ b/xen/include/public/io/netif.h @@ -151,6 +151,361 @@ */ /* + * Control ring + * ============ + * + * Some features, such as toeplitz hashing (detailed below), require a + * significant amount of out-of-band data to be passed from frontend to + * backend. Use of xenstore is not suitable for large quantities of data + * because of quota limitations and so a dedicated 'control ring' is used. + * The ability of the backend to use a control ring is advertised by + * setting: + * + * /local/domain/X/backend///feature-ctrl-ring = "1" + * + * The frontend provides a control ring to the backend by setting: + * + * /local/domain//device/vif//ctrl-ring-ref = + * /local/domain//device/vif//event-channel-ctrl = + * + * where is the grant reference of the shared page used to + * implement the control ring and is an event channel to be used + * as a mailbox interrupt. These keys must be set before the frontend + * moves into the connected state. + * + * The control ring uses a fixed request/response message size and is + * balanced (i.e. one request to one response), so operationally it is much + * the same as a transmit or receive ring. + * Note that there is no requirement that responses are issued in the same + * order as requests. + */ + +/* + * Toeplitz hash types + * =================== + * + * For the purposes of the definitions below, 'Packet[]' is an array of + * octets containing an IP packet without options, 'Array[X..Y]' means a + * sub-array of 'Array' containing bytes X thru Y inclusive, and '+' is + * used to indicate concatenation of arrays. + */ + +/* + * A hash calculated over an IP version 4 header as follows: + * + * Buffer[0..8] = Packet[12..15] (source address) + + * Packet[16..19] (destination address) + * + * Result = ToeplitzHash(Buffer, 8) + */ +#define _NETIF_CTRL_TOEPLITZ_HASH_IPV4 0 +#define NETIF_CTRL_TOEPLITZ_HASH_IPV4 (1 << _NETIF_CTRL_TOEPLITZ_HASH_IPV4) + +/* + * A hash calculated over an IP version 4 header and TCP header as + * follows: + * + * Buffer[0..12] = Packet[12..15] (source address) + + * Packet[16..19] (destination address) + + * Packet[20..21] (source port) + + * Packet[22..23] (destination port) + * + * Result = ToeplitzHash(Buffer, 12) + */ +#define _NETIF_CTRL_TOEPLITZ_HASH_IPV4_TCP 1 +#define NETIF_CTRL_TOEPLITZ_HASH_IPV4_TCP (1 << _NETIF_CTRL_TOEPLITZ_HASH_IPV4_TCP) + +/* + * A hash calculated over an IP version 6 header as follows: + * + * Buffer[0..32] = Packet[8..23] (source address ) + + * Packet[24..39] (destination address) + * + * Result = ToeplitzHash(Buffer, 32) + */ +#define _NETIF_CTRL_TOEPLITZ_HASH_IPV6 2 +#define NETIF_CTRL_TOEPLITZ_HASH_IPV6 (1 << _NETIF_CTRL_TOEPLITZ_HASH_IPV4) + +/* + * A hash calculated over an IP version 6 header and TCP header as + * follows: + * + * Buffer[0..36] = Packet[8..23] (source address) + + * Packet[24..39] (destination address) + + * Packet[40..41] (source port) + + * Packet[42..43] (destination port) + * + * Result = ToeplitzHash(Buffer, 36) + */ +#define _NETIF_CTRL_TOEPLITZ_HASH_IPV6_TCP 3 +#define NETIF_CTRL_TOEPLITZ_HASH_IPV6_TCP (1 << _NETIF_CTRL_TOEPLITZ_HASH_IPV4_TCP) + +/* + * Control requests (netif_ctrl_request_t) + * ======================================= + * + * All requests have the following format: + * + * 0 1 2 3 4 5 6 7 octet + * +-----+-----+-----+-----+-----+-----+-----+-----+ + * | id | type | data[0] | + * +-----+-----+-----+-----+-----+-----+-----+-----+ + * | data[1] | data[2] | + * +-----+-----+-----+-----+-----------------------+ + * + * id: the request identifier, echoed in response. + * type: the type of request (see below) + * data[]: any data associated with the request (determined by type) + */ + +struct netif_ctrl_request { + uint16_t id; + uint16_t type; + +#define NETIF_CTRL_TYPE_INVALID 0 +#define NETIF_CTRL_TYPE_GET_TOEPLITZ_FLAGS 1 +#define NETIF_CTRL_TYPE_SET_TOEPLITZ_FLAGS 2 +#define NETIF_CTRL_TYPE_SET_TOEPLITZ_KEY 3 +#define NETIF_CTRL_TYPE_GET_TOEPLITZ_MAPPING_ORDER 4 +#define NETIF_CTRL_TYPE_SET_TOEPLITZ_MAPPING_ORDER 5 +#define NETIF_CTRL_TYPE_SET_TOEPLITZ_MAPPING 6 + + uint32_t data[3]; +}; +typedef struct netif_ctrl_request netif_ctrl_request_t; + +/* + * Control responses (netif_ctrl_response_t) + * ========================================= + * + * All responses have the following format: + * + * 0 1 2 3 4 5 6 7 octet + * +-----+-----+-----+-----+-----+-----+-----+-----+ + * | id | type | status | + * +-----+-----+-----+-----+-----+-----+-----+-----+ + * | data | + * +-----+-----+-----+-----+ + * + * id: the corresponding request identifier + * type: the type of the corresponding request + * status: the status of request processing + * data: any data associated with the response (determined by type and + * status) + */ + +struct netif_ctrl_response { + uint16_t id; + uint16_t type; + uint32_t status; + +#define NETIF_CTRL_STATUS_SUCCESS 0 +#define NETIF_CTRL_STATUS_NOT_SUPPORTED 1 +#define NETIF_CTRL_STATUS_INVALID_PARAMETER 2 +#define NETIF_CTRL_STATUS_BUFFER_OVERFLOW 3 + + uint32_t data; +}; +typedef struct netif_ctrl_response netif_ctrl_response_t; + +/* + * Control messages + * ================ + * + * NETIF_CTRL_TYPE_GET_TOEPLITZ_FLAGS + * ---------------------------------- + * + * This is sent by the frontend to query the types of toeplitz + * hash supported by the backend. + * + * Request: + * + * type = NETIF_CTRL_TYPE_GET_TOEPLITZ_FLAGS + * data[0] = 0 + * data[1] = 0 + * data[2] = 0 + * + * Response: + * + * status = NETIF_CTRL_STATUS_NOT_SUPPORTED - Operation not supported + * NETIF_CTRL_STATUS_SUCCESS - Operation successful + * data = supported hash types (if operation was successful) + * + * NETIF_CTRL_TYPE_SET_TOEPLITZ_FLAGS + * ---------------------------------- + * + * This is sent by the frontend to set the types of toeplitz hash that + * the backend should calculate. (See above for hash type definitions). + * Note that the 'maximal' type of hash should always be chosen. For + * example, if the frontend sets both IPV4 and IPV4_TCP hash types then + * the latter hash type should be calculated for any TCP packet and the + * former only calculated for non-TCP packets. + * + * Request: + * + * type = NETIF_CTRL_TYPE_SET_TOEPLITZ_FLAGS + * data[0] = bitwise OR of NETIF_CTRL_TOEPLITZ_HASH_* values + * data[1] = 0 + * data[2] = 0 + * + * Response: + * + * status = NETIF_CTRL_STATUS_NOT_SUPPORTED - Operation not supported + * NETIF_CTRL_STATUS_INVALID_PARAMETER - One or more flag value + * is invalid or + * unsupported + * NETIF_CTRL_STATUS_SUCCESS - Operation successful + * data = 0 + * + * NOTE: Setting data[0] to zero disables toeplitz hashing and the backend + * is free to choose how it steers packets to queues (which is the + * default behaviour). + * + * NETIF_CTRL_TYPE_SET_TOEPLITZ_KEY + * -------------------------------- + * + * This is sent by the frontend to set the key of the toeplitz hash that + * the backend should calculate. The toeplitz algorithm is illustrated + * by the following pseudo-code: + * + * (Buffer[] and Key[] are treated as shift-registers where the MSB of + * Buffer/Key[0] is considered 'left-most' and the LSB of Buffer/Key[N-1] + * is the 'right-most'). + * + * Value = 0 + * For number of bits in Buffer[] + * If (left-most bit of Buffer[] is 1) + * Value ^= left-most 32 bits of Key[] + * Key[] << 1 + * Buffer[] << 1 + * + * Request: + * + * type = NETIF_CTRL_TYPE_SET_TOEPLITZ_KEY + * data[0] = grant reference of page containing the key (assumed to + * start at beginning of grant) + * data[1] = size of key in octets + * data[2] = 0 + * + * Response: + * + * status = NETIF_CTRL_STATUS_NOT_SUPPORTED - Operation not supported + * NETIF_CTRL_STATUS_INVALID_PARAMETER - Key size is invalid + * NETIF_CTRL_STATUS_BUFFER_OVERFLOW - Key size is larger than + * the backend supports + * NETIF_CTRL_STATUS_SUCCESS - Operation successful + * data = 0 + * + * NOTE: Any key octets not specified are assumed to be zero (the key + * is assumed to be empty by default) and specifying a new key + * invalidates any previous key, hence specifying a key size of + * zero will clear the key (which ensures that the calculated hash + * will always be zero). + * The maximum size of key is backend specific, but is also limited + * by the single grant reference. + * The grant reference may be read-only and must remain valid until + * the response has been processed. + * + * NETIF_CTRL_TYPE_GET_TOEPLITZ_MAPPING_ORDER + * ------------------------------------------ + * + * This is sent by the frontend to query the maximum order of mapping + * table supported by the backend. The order is specified in terms of + * table entries i.e. the table may contain up to 2^order entries. + * + * Request: + * + * type = NETIF_CTRL_TYPE_GET_TOEPLITZ_MAPPING_ORDER + * data[0] = 0 + * data[1] = 0 + * data[2] = 0 + * + * Response: + * + * status = NETIF_CTRL_STATUS_NOT_SUPPORTED - Operation not supported + * NETIF_CTRL_STATUS_SUCCESS - Operation successful + * data = maximum order of mapping table (if operation was successful) + * + * NETIF_CTRL_TYPE_SET_TOEPLITZ_MAPPING_ORDER + * ------------------------------------------ + * + * This is sent by the frontend to set the actual order of the mapping + * table to be used by the backend. The order is specified in terms of + * table entries i.e. the table will contain to 2^order entries. + * Any previous table is invalidated by this message and any new table + * is assumed to be zero filled. The default order is zero and hence the + * default table contains a single entry mapping all hashes to queue-0. + * + * Request: + * + * type = NETIF_CTRL_TYPE_SET_TOEPLITZ_MAPPING_ORDER + * data[0] = order of mapping table + * data[1] = 0 + * data[2] = 0 + * + * Response: + * + * status = NETIF_CTRL_STATUS_NOT_SUPPORTED - Operation not supported + * NETIF_CTRL_STATUS_INVALID_PARAMETER - Table order is invalid + * NETIF_CTRL_STATUS_SUCCESS - Operation successful + * data = 0 + * + * NETIF_CTRL_TYPE_SET_TOEPLITZ_MAPPING + * ------------------------------------ + * + * This is sent by the frontend to set the content of the table mapping + * toeplitz hash value to queue number. The backend should calculate the + * hash from the packet header, use it as an index into the table (modulo + * the size of the table) and then steer the packet to the queue number + * found at that index. + * + * Request: + * + * type = NETIF_CTRL_TYPE_SET_TOEPLITZ_MAPPING + * data[0] = grant reference of page containing the mapping (sub-)table + * (assumed to start at beginning of grant) + * data[1] = size of (sub-)table in entries + * data[2] = offset, in entries, of sub-table within overall table + * + * Response: + * + * status = NETIF_CTRL_STATUS_NOT_SUPPORTED - Operation not supported + * NETIF_CTRL_STATUS_INVALID_PARAMETER - Table size or content is + * invalid + * NETIF_CTRL_STATUS_BUFFER_OVERFLOW - Table size is larger than + * the backend supports + * NETIF_CTRL_STATUS_SUCCESS - Operation successful + * data = 0 + * + * NOTE: The overall table has the following format: + * + * 0 1 2 3 4 5 6 7 octet + * +-----+-----+-----+-----+-----+-----+-----+-----+ + * | mapping[0] | mapping[1] | + * +-----+-----+-----+-----+-----+-----+-----+-----+ + * | . | + * | . | + * | . | + * +-----+-----+-----+-----+-----+-----+-----+-----+ + * | mapping[N-2] | mapping[N-1] | + * +-----+-----+-----+-----+-----+-----+-----+-----+ + * + * where N == 2^order as specified by a + * NETIF_CTRL_TYPE_SET_TOEPLITZ_MAPPING_ORDER message and each + * mapping must specifies a queue between 0 and + * "multi-queue-num-queues" (see above). + * The backend may support a mapping table larger than can be + * mapped by a single grant reference. Thus sub-tables within a + * larger table can be individually set by sending multiple messages + * with differing offset values. Specifying a new sub-table does not + * invalidate any table data outside that range. + * The grant reference may be read-only and must remain valid until + * the response has been processed. + */ + +DEFINE_RING_TYPES(netif_ctrl, struct netif_ctrl_request, struct netif_ctrl_response); + +/* * Guest transmit * ============== * @@ -330,6 +685,23 @@ * type: Must be XEN_NETIF_EXTRA_TYPE_MCAST_{ADD,DEL} * flags: XEN_NETIF_EXTRA_FLAG_* * addr: address to add/remove + * + * XEN_NETIF_EXTRA_TYPE_TOEPLITZ: + * + * A backend that supports teoplitz hashing is assumed to accept + * this type of extra info in transmit packets. + * A frontend that enables toeplitz hashing is assumed to accept + * this type of extra info in receive packets. + * + * 0 1 2 3 4 5 6 7 octet + * +-----+-----+-----+-----+-----+-----+-----+-----+ + * |type |flags|htype| pad |LSB ---- value ---- MSB| + * +-----+-----+-----+-----+-----+-----+-----+-----+ + * + * type: Must be XEN_NETIF_EXTRA_TYPE_TOEPLITZ + * flags: XEN_NETIF_EXTRA_FLAG_* + * htype: Hash type (one of _NETIF_CTRL_TOEPLITZ_HASH_* - see above) + * value: Hash value */ /* Protocol checksum field is blank in the packet (hardware offload)? */ @@ -363,7 +735,8 @@ typedef struct netif_tx_request netif_tx_request_t; #define XEN_NETIF_EXTRA_TYPE_GSO (1) /* u.gso */ #define XEN_NETIF_EXTRA_TYPE_MCAST_ADD (2) /* u.mcast */ #define XEN_NETIF_EXTRA_TYPE_MCAST_DEL (3) /* u.mcast */ -#define XEN_NETIF_EXTRA_TYPE_MAX (4) +#define XEN_NETIF_EXTRA_TYPE_TOEPLITZ (4) /* u.toeplitz */ +#define XEN_NETIF_EXTRA_TYPE_MAX (5) /* netif_extra_info_t flags. */ #define _XEN_NETIF_EXTRA_FLAG_MORE (0) @@ -391,6 +764,11 @@ struct netif_extra_info { struct { uint8_t addr[6]; } mcast; + struct { + uint8_t type; + uint8_t pad; + uint8_t value[4]; + } toeplitz; uint16_t pad[3]; } u; };