diff mbox

[v5,1/5] build: Env var to enable expert config options

Message ID 1452782954-56016-2-git-send-email-jonathan.creekmore@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jonathan Creekmore Jan. 14, 2016, 2:49 p.m. UTC 
Add an additional environment variable, defaulting to disabled,
that enables the CONFIG_EXPERT configuration option. The purpose
of the CONFIG_EXPERT configuration option is to make non-standard
Kconfig options visible during the configuration process. The
CONFIG_EXPERT option is not, itself, visible during the Kconfig
configuration process, so typical users will never see it nor
any of the non-standard configuration options.

CC: Ian Campbell <ian.campbell@citrix.com>
CC: Ian Jackson <ian.jackson@eu.citrix.com>
CC: Jan Beulich <jbeulich@suse.com>
CC: Keir Fraser <keir@xen.org>
CC: Tim Deegan <tim@xen.org>
Signed-off-by: Jonathan Creekmore <jonathan.creekmore@gmail.com>
Reviewed-by: Doug Goldstein <cardoe@cardoe.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
 xen/Kconfig  | 4 ++++
 xen/Makefile | 1 +
 2 files changed, 5 insertions(+)

Comments

Jan Beulich Jan. 14, 2016, 4:09 p.m. UTC | #1 
>>> On 14.01.16 at 15:49, <jonathan.creekmore@gmail.com> wrote:
> --- a/xen/Kconfig
> +++ b/xen/Kconfig
> @@ -22,3 +22,7 @@ config DEFCONFIG_LIST
>  	string
>  	option defconfig_list
>  	default "$ARCH_DEFCONFIG"
> +
> +config EXPERT
> +	string
> +	option env="XEN_CONFIG_EXPERT"

This better wouldn't go in ahead of
http://lists.xenproject.org/archives/html/xen-devel/2016-01/msg01321.html
and would then need adjustment to take care of avoiding
re-introduction of that same problem.

Jan
Ian Campbell Jan. 15, 2016, 3:47 p.m. UTC | #2 
On Thu, 2016-01-14 at 09:09 -0700, Jan Beulich wrote:
> > > > On 14.01.16 at 15:49, <jonathan.creekmore@gmail.com> wrote:
> > --- a/xen/Kconfig
> > +++ b/xen/Kconfig
> > @@ -22,3 +22,7 @@ config DEFCONFIG_LIST
> >  	string
> >  	option defconfig_list
> >  	default "$ARCH_DEFCONFIG"
> > +
> > +config EXPERT
> > +	string
> > +	option env="XEN_CONFIG_EXPERT"
> 
> This better wouldn't go in ahead of
> http://lists.xenproject.org/archives/html/xen-devel/2016-01/msg01321.html
> and would then need adjustment to take care of avoiding
> re-introduction of that same problem.

I don't follow what problem would be reintroduced, this patch seems to be
correctly defining and exporting XEN_CONFIG_EXPERT from xen/Makefile before
any inclusion of kconfig related things

Ian.
Jan Beulich Jan. 15, 2016, 4:56 p.m. UTC | #3 
>>> On 15.01.16 at 16:47, <ian.campbell@citrix.com> wrote:
> On Thu, 2016-01-14 at 09:09 -0700, Jan Beulich wrote:
>> > > > On 14.01.16 at 15:49, <jonathan.creekmore@gmail.com> wrote:
>> > --- a/xen/Kconfig
>> > +++ b/xen/Kconfig
>> > @@ -22,3 +22,7 @@ config DEFCONFIG_LIST
>> >  	string
>> >  	option defconfig_list
>> >  	default "$ARCH_DEFCONFIG"
>> > +
>> > +config EXPERT
>> > +	string
>> > +	option env="XEN_CONFIG_EXPERT"
>> 
>> This better wouldn't go in ahead of
>> http://lists.xenproject.org/archives/html/xen-devel/2016-01/msg01321.html 
>> and would then need adjustment to take care of avoiding
>> re-introduction of that same problem.
> 
> I don't follow what problem would be reintroduced, this patch seems to be
> correctly defining and exporting XEN_CONFIG_EXPERT from xen/Makefile before
> any inclusion of kconfig related things

Ah, wait, this variable comes from the environment in the first place,
and hence should be visible to Makefile.kconfig no matter what. I'm
sorry for the noise then.

Jan
diff mbox

Patch

diff --git a/xen/Kconfig b/xen/Kconfig
index ffe3f45..fa8b27c 100644
--- a/xen/Kconfig
+++ b/xen/Kconfig
@@ -22,3 +22,7 @@  config DEFCONFIG_LIST
 	string
 	option defconfig_list
 	default "$ARCH_DEFCONFIG"
+
+config EXPERT
+	string
+	option env="XEN_CONFIG_EXPERT"
diff --git a/xen/Makefile b/xen/Makefile
index 9023863..4950afb 100644
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -11,6 +11,7 @@  export XEN_DOMAIN	?= $(shell ([ -x /bin/dnsdomainname ] && /bin/dnsdomainname) |
 export XEN_BUILD_DATE	?= $(shell LC_ALL=C date)
 export XEN_BUILD_TIME	?= $(shell LC_ALL=C date +%T)
 export XEN_BUILD_HOST	?= $(shell hostname)
+export XEN_CONFIG_EXPERT ?= n
 
 export BASEDIR := $(CURDIR)
 export XEN_ROOT := $(BASEDIR)/..