| Message ID | 1452879580-1770-1-git-send-email-cardoe@cardoe.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 15/01/16 17:39, Doug Goldstein wrote: > The flask utilities only have dependencies on libxc so there's no > downside to always building it. Distros and projects based on Xen can > put these in a different package to not install them for all users. > Prior to this change FLASK_ENABLE needed to be set at the top level to > build the utilities and the tools/configure script would build the FLASK > policy by default, but only if the utilities were built. > > This change makes item 3 from > http://lists.xenproject.org/archives/html/xen-devel/2016-01/msg01796.html > a happen by default. > > CC: Ian Jackson <ian.jackson@eu.citrix.com> > CC: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > CC: Ian Campbell <ian.campbell@citrix.com> > CC: Wei Liu <wei.liu2@citrix.com> > Signed-off-by: Doug Goldstein <cardoe@cardoe.com> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com> > --- > tools/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/Makefile b/tools/Makefile > index 9f74ac7..3f9289b 100644 > --- a/tools/Makefile > +++ b/tools/Makefile > @@ -5,7 +5,7 @@ SUBDIRS-y := > SUBDIRS-y += include > SUBDIRS-y += libs > SUBDIRS-y += libxc > -SUBDIRS-$(FLASK_ENABLE) += flask > +SUBDIRS-y += flask > SUBDIRS-y += xenstore > SUBDIRS-y += misc > SUBDIRS-y += examples
On Fri, 2016-01-15 at 19:48 +0000, Andrew Cooper wrote: > On 15/01/16 17:39, Doug Goldstein wrote: > > The flask utilities only have dependencies on libxc so there's no > > downside to always building it. Distros and projects based on Xen can > > put these in a different package to not install them for all users. > > Prior to this change FLASK_ENABLE needed to be set at the top level to > > build the utilities and the tools/configure script would build the > > FLASK > > policy by default, but only if the utilities were built. > > > > This change makes item 3 from > > http://lists.xenproject.org/archives/html/xen-devel/2016-01/msg01796.ht > > ml > > a happen by default. > > > > CC: Ian Jackson <ian.jackson@eu.citrix.com> > > CC: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > > CC: Ian Campbell <ian.campbell@citrix.com> > > CC: Wei Liu <wei.liu2@citrix.com> > > Signed-off-by: Doug Goldstein <cardoe@cardoe.com> > > Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com> As noted elsewhere I have acked + applied htis.
diff --git a/tools/Makefile b/tools/Makefile index 9f74ac7..3f9289b 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -5,7 +5,7 @@ SUBDIRS-y := SUBDIRS-y += include SUBDIRS-y += libs SUBDIRS-y += libxc -SUBDIRS-$(FLASK_ENABLE) += flask +SUBDIRS-y += flask SUBDIRS-y += xenstore SUBDIRS-y += misc SUBDIRS-y += examples
The flask utilities only have dependencies on libxc so there's no downside to always building it. Distros and projects based on Xen can put these in a different package to not install them for all users. Prior to this change FLASK_ENABLE needed to be set at the top level to build the utilities and the tools/configure script would build the FLASK policy by default, but only if the utilities were built. This change makes item 3 from http://lists.xenproject.org/archives/html/xen-devel/2016-01/msg01796.html a happen by default. CC: Ian Jackson <ian.jackson@eu.citrix.com> CC: Stefano Stabellini <stefano.stabellini@eu.citrix.com> CC: Ian Campbell <ian.campbell@citrix.com> CC: Wei Liu <wei.liu2@citrix.com> Signed-off-by: Doug Goldstein <cardoe@cardoe.com> --- tools/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)