[v2,1/5] libxl: tidy libxl_get_scheduler() according to CODING_STYLE

Commit Message

Chester Lin Jan. 19, 2016, 5:57 a.m. UTC

To more closely follow the guidelines in CODING_STYLE, store the result
of xc_sched_id() in the local variable r, and the check the result of
the call in a separate statement.  Change the type of the output
parameter given to xc_sched_id() from libxl_scheduler to int to match
the libxc interface.

Additionally, change the error log statement to more accurately reflect
the failure.  This is the only functional change introduced by this
patch.

Suggested-by: Ian Campbell <[e-mail]>
Signed-off-by: Chester Lin <[e-mail]>

---
Now storing the return of xc_sched_id in an int as per
  On Mon, 2016-01-04 at 16:23 +0000, Ian Campbell wrote:
  >Safer (and cleaner looking even if I'm wrong) would be to use a temporary
  >int for the function call and turn it into an enum implicitly in the return
---
 tools/libxl/libxl.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

Comments

Dario Faggioli Jan. 19, 2016, 9:14 a.m. UTC | #1

On Tue, 2016-01-19 at 00:57 -0500, Chester Lin wrote:
> To more closely follow the guidelines in CODING_STYLE, store the
> result
> of xc_sched_id() in the local variable r, and the check the result of
> the call in a separate statement.  Change the type of the output
> parameter given to xc_sched_id() from libxl_scheduler to int to match
> the libxc interface.
> 
> Additionally, change the error log statement to more accurately
> reflect
> the failure.  This is the only functional change introduced by this
> patch.
> 
> Suggested-by: Ian Campbell <[e-mail]>
> Signed-off-by: Chester Lin <[e-mail]>
> 
Reviewed-by: Dario Faggioli <[e-mail]>

Regards,
Dario

Wei Liu Jan. 19, 2016, 11:28 a.m. UTC | #2

Hi Chester

What we normally do for new version of patches is to send out a new
series prefixed with "PATCH v2", instead of replying to old version of
the patches.

Could you collect Dario's Reviewed-by tags and send this series as v2.

Thanks
Wei.

Ian Campbell Jan. 19, 2016, 11:35 a.m. UTC | #3

On Tue, 2016-01-19 at 11:28 +0000, Wei Liu wrote:
> Hi Chester
> 
> What we normally do for new version of patches is to send out a new
> series prefixed with "PATCH v2", instead of replying to old version of
> the patches.
> 
> Could you collect Dario's Reviewed-by tags and send this series as v2.

Please call the resend v3 to avoid any confusion.

http://wiki.xen.org/wiki/Submitting_Xen_Patches#Review.2C_Rinse_.26_Repeat 
also has some words on this topic.

Ian.

Patch

diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c
index 9207621..7f28af8 100644
--- a/tools/libxl/libxl.c
+++ b/tools/libxl/libxl.c
@@ -5585,10 +5585,12 @@  out:
 
 libxl_scheduler libxl_get_scheduler(libxl_ctx *ctx)
 {
-    libxl_scheduler sched, ret;
+    int r, sched;
+
     GC_INIT(ctx);
-    if ((ret = xc_sched_id(ctx->xch, (int *)&sched)) != 0) {
-        LOGE(ERROR, "getting domain info list");
+    r = xc_sched_id(ctx->xch, &sched);
+    if (r != 0) {
+        LOGE(ERROR, "getting current scheduler id");
         return ERROR_FAIL;
         GC_FREE;
     }