From patchwork Fri Jan 22 14:27:29 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Campbell X-Patchwork-Id: 8090561 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 07F199F859 for ; Fri, 22 Jan 2016 14:29:41 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4882C20434 for ; Fri, 22 Jan 2016 14:29:40 +0000 (UTC) Received: from lists.xen.org (lists.xenproject.org [50.57.142.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7904A203F3 for ; Fri, 22 Jan 2016 14:29:39 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aMcgZ-00048r-M5; Fri, 22 Jan 2016 14:27:35 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aMcgY-00048O-UF for xen-devel@lists.xen.org; Fri, 22 Jan 2016 14:27:35 +0000 Received: from [193.109.254.147] by server-5.bemta-14.messagelabs.com id 3B/AC-23366-65C32A65; Fri, 22 Jan 2016 14:27:34 +0000 X-Env-Sender: prvs=8224aa445=Ian.Campbell@citrix.com X-Msg-Ref: server-6.tower-27.messagelabs.com!1453472852!18799776!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 59759 invoked from network); 22 Jan 2016 14:27:33 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-6.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 22 Jan 2016 14:27:33 -0000 X-IronPort-AV: E=Sophos;i="5.22,331,1449532800"; d="scan'208";a="333336302" From: Ian Campbell To: Date: Fri, 22 Jan 2016 14:27:29 +0000 Message-ID: <1453472849-25496-2-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.6.1 In-Reply-To: <1453472830.4320.97.camel@citrix.com> References: <1453472830.4320.97.camel@citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: Ian Campbell , xen-devel@lists.xen.org Subject: [Xen-devel] [PATCH 2/2] xenalyze: remove cr3_compare_total X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP gcc-6 complains: xenalyze.c:4132:9: error: 'cr3_compare_total' defined but not used [-Werror=unused-function] int cr3_compare_total(const void *_a, const void *_b) { ^~~~~~~~~~~~~~~~~ I believe it is correct. Signed-off-by: Ian Campbell Reviewed-by: George Dunlap --- tools/xentrace/xenalyze.c | 17 ----------------- 1 file changed, 17 deletions(-) diff --git a/tools/xentrace/xenalyze.c b/tools/xentrace/xenalyze.c index 4bcaf83..6520790 100644 --- a/tools/xentrace/xenalyze.c +++ b/tools/xentrace/xenalyze.c @@ -4129,23 +4129,6 @@ void cr3_dump_list(struct cr3_value_struct *head){ struct cr3_value_struct **qsort_array; int i, N=0; - int cr3_compare_total(const void *_a, const void *_b) { - struct cr3_value_struct *a=*(typeof(&a))_a; - struct cr3_value_struct *b=*(typeof(&a))_b; - - if(a->total_time.cycles < b->total_time.cycles) - return 1; - else if(b->total_time.cycles == a->total_time.cycles) { - if(a->total_time.count < b->total_time.count) - return 1; - else if(a->total_time.count == b->total_time.count) - return 0; - else - return -1; - } else - return -1; - } - int cr3_compare_start(const void *_a, const void *_b) { struct cr3_value_struct *a=*(typeof(&a))_a; struct cr3_value_struct *b=*(typeof(&a))_b;