From patchwork Mon Jan 25 21:06:55 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Rzeszutek Wilk X-Patchwork-Id: 8115501 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id AC569BEEE5 for ; Mon, 25 Jan 2016 21:09:46 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DF4222037E for ; Mon, 25 Jan 2016 21:09:45 +0000 (UTC) Received: from lists.xen.org (lists.xenproject.org [50.57.142.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B6AFB20384 for ; Mon, 25 Jan 2016 21:09:43 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aNoM3-0000VF-Cx; Mon, 25 Jan 2016 21:07:19 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aNoM2-0000V8-BD for xen-devel@lists.xenproject.org; Mon, 25 Jan 2016 21:07:18 +0000 Received: from [85.158.137.68] by server-10.bemta-3.messagelabs.com id 47/9A-02807-58E86A65; Mon, 25 Jan 2016 21:07:17 +0000 X-Env-Sender: konrad.wilk@oracle.com X-Msg-Ref: server-9.tower-31.messagelabs.com!1453756033!2198731!1 X-Originating-IP: [156.151.31.81] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogMTU2LjE1MS4zMS44MSA9PiAyODgzMzk=\n X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 36500 invoked from network); 25 Jan 2016 21:07:14 -0000 Received: from userp1040.oracle.com (HELO userp1040.oracle.com) (156.151.31.81) by server-9.tower-31.messagelabs.com with DHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 25 Jan 2016 21:07:14 -0000 Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u0PL7Apb008676 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 25 Jan 2016 21:07:10 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.14.4/8.13.8) with ESMTP id u0PL79E0028468 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Mon, 25 Jan 2016 21:07:09 GMT Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by aserv0121.oracle.com (8.13.8/8.13.8) with ESMTP id u0PL799j009183; Mon, 25 Jan 2016 21:07:09 GMT Received: from x230.dumpdata.com.com (/10.154.179.98) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 25 Jan 2016 13:07:09 -0800 From: Konrad Rzeszutek Wilk To: xen-devel@lists.xenproject.org, ian.campbell@citrix.com, wei.liu2@citrix.com, ian.jackson@eu.citrix.com Date: Mon, 25 Jan 2016 16:06:55 -0500 Message-Id: <1453756017-8747-2-git-send-email-konrad.wilk@oracle.com> X-Mailer: git-send-email 2.4.3 In-Reply-To: <1453756017-8747-1-git-send-email-konrad.wilk@oracle.com> References: <1453756017-8747-1-git-send-email-konrad.wilk@oracle.com> X-Source-IP: userv0022.oracle.com [156.151.31.74] Cc: Konrad Rzeszutek Wilk Subject: [Xen-devel] [PATCH 1/3] libxc/xc_domain_resume: Update comment. X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP To hopefully clarify what it meant. Signed-off-by: Konrad Rzeszutek Wilk --- tools/libxc/xc_resume.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/libxc/xc_resume.c b/tools/libxc/xc_resume.c index 87d4324..19ba2a3 100644 --- a/tools/libxc/xc_resume.c +++ b/tools/libxc/xc_resume.c @@ -248,9 +248,12 @@ out: /* * Resume execution of a domain after suspend shutdown. * This can happen in one of two ways: - * 1. Resume with special return code. - * 2. Reset guest environment so it believes it is resumed in a new + * 1. (fast=1) Resume with special return code (1) that the guest + * gets from SCHEDOP_shutdown:SHUTDOWN_suspend. + * + * 2. (fast=0) Reset guest environment so it believes it is resumed in a new * domain context. + * * (2) should be used only for guests which cannot handle the special * new return code. (1) is always safe (but slower). */