diff mbox

[1/1] xen-netfront: uninitialized fields in xenvif_rx_action

Message ID 1454394031.2873.10.camel@linux
State New, archived
Headers show

Commit Message

Dongli Zhang Feb. 2, 2016, 6:20 a.m. UTC
While npo.copy and npo.meta are initialized in xenvif_rx_action, fields
such as npo.meta_prod are directly used later in xenvif_gop_skb without
being initialized first. Although the output of xenvif_rx_action is based
on the difference between new npo->meta_prod and old npo->meta_prod, it is
better to initialize them to 0 at the beginning.

Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
---
 drivers/net/xen-netback/netback.c | 4 ++++
 1 file changed, 4 insertions(+)

Comments

David Vrabel Feb. 2, 2016, 10:25 a.m. UTC | #1
On 02/02/16 06:20, Dongli Zhang wrote:
> While npo.copy and npo.meta are initialized in xenvif_rx_action, fields
> such as npo.meta_prod are directly used later in xenvif_gop_skb without
> being initialized first. Although the output of xenvif_rx_action is based
> on the difference between new npo->meta_prod and old npo->meta_prod, it is
> better to initialize them to 0 at the beginning.

Fields that are omitted from an initializer are initialized to zero.  So
this patch is not needed.

David

> --- a/drivers/net/xen-netback/netback.c
> +++ b/drivers/net/xen-netback/netback.c
> @@ -560,6 +560,10 @@ static void xenvif_rx_action(struct xenvif_queue *queue)
>  	bool need_to_notify = false;
>  
>  	struct netrx_pending_operations npo = {
> +		.copy_prod = 0,
> +		.copy_cons = 0,
> +		.meta_prod = 0,
> +		.meta_cons = 0,
>  		.copy  = queue->grant_copy_op,
>  		.meta  = queue->meta,
>  	};
>
diff mbox

Patch

diff --git a/drivers/net/xen-netback/netback.c b/drivers/net/xen-netback/netback.c
index 61b97c3..32f0fbd 100644
--- a/drivers/net/xen-netback/netback.c
+++ b/drivers/net/xen-netback/netback.c
@@ -560,6 +560,10 @@  static void xenvif_rx_action(struct xenvif_queue *queue)
 	bool need_to_notify = false;
 
 	struct netrx_pending_operations npo = {
+		.copy_prod = 0,
+		.copy_cons = 0,
+		.meta_prod = 0,
+		.meta_cons = 0,
 		.copy  = queue->grant_copy_op,
 		.meta  = queue->meta,
 	};