From patchwork Wed Feb 17 10:51:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Campbell X-Patchwork-Id: 8336661 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 333AA9F38B for ; Wed, 17 Feb 2016 10:54:45 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5B1F320254 for ; Wed, 17 Feb 2016 10:54:44 +0000 (UTC) Received: from lists.xen.org (lists.xenproject.org [50.57.142.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8B2B020376 for ; Wed, 17 Feb 2016 10:54:43 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aVziM-0006RI-Vx; Wed, 17 Feb 2016 10:52:10 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aVziH-0006R6-Mf for xen-devel@lists.xen.org; Wed, 17 Feb 2016 10:52:10 +0000 Received: from [85.158.137.68] by server-3.bemta-3.messagelabs.com id E0/52-02499-4D054C65; Wed, 17 Feb 2016 10:52:04 +0000 X-Env-Sender: prvs=848fde4e6=Ian.Campbell@citrix.com X-Msg-Ref: server-5.tower-31.messagelabs.com!1455706323!23043688!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 3183 invoked from network); 17 Feb 2016 10:52:04 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-5.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 17 Feb 2016 10:52:04 -0000 X-IronPort-AV: E=Sophos;i="5.22,459,1449532800"; d="scan'208";a="338797235" From: Ian Campbell To: , Date: Wed, 17 Feb 2016 10:51:59 +0000 Message-ID: <1455706319-24690-1-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 2.6.1 MIME-Version: 1.0 X-DLP: MIA1 Cc: Ian Campbell Subject: [Xen-devel] [PATCH OSSTEST] mg-show-flight-runvars: avoid "SELECT .. AND TRUE" for sqlite X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP c5e29f93fb6e "mg-show-flight-runvars: recurse on buildjobs upon request" broke standalone mode with: Error: no such column: TRUE from sqlite. Do as is done for $syntcond and use (1=1) instead. Signed-off-by: Ian Campbell --- mg-show-flight-runvars | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mg-show-flight-runvars b/mg-show-flight-runvars index c847456..d708fed 100755 --- a/mg-show-flight-runvars +++ b/mg-show-flight-runvars @@ -53,7 +53,7 @@ our %jobs; sub collect ($;$@) { my ($flight,$jobcond,@jobcondparams) = @_; - $jobcond //= "TRUE"; + $jobcond //= "(1=1)"; $flight =~ m/^\d+/ or $flight = "'$flight'"; my $qfrom = "FROM runvars WHERE flight=$flight AND $synthcond AND $jobcond";