| Message ID | 1455892362-1560-1-git-send-email-konrad.wilk@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 02/19/2016 04:32 PM, Konrad Rzeszutek Wilk wrote: > And what it is usually used for. > > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > --- > xen/include/public/version.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/xen/include/public/version.h b/xen/include/public/version.h > index adca602..b97fc68 100644 > --- a/xen/include/public/version.h > +++ b/xen/include/public/version.h > @@ -79,6 +79,10 @@ typedef struct xen_feature_info xen_feature_info_t; > #define XENVER_pagesize 7 > > /* arg == xen_domain_handle_t. */ > +/* > + * The toolstack fills it out for the guest consumption. Usually it is > + * the UUID of the guest but can be anything. > + */ > #define XENVER_guest_handle 8 > > #define XENVER_commandline 9 I'm not a maintainer for this code, so an Ack would be meaningless, but I just wanted to say thanks for documenting this. :) Thanks, Razvan
On Fri, Feb 19, 2016 at 04:36:14PM +0200, Razvan Cojocaru wrote: > On 02/19/2016 04:32 PM, Konrad Rzeszutek Wilk wrote: > > And what it is usually used for. > > > > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > > --- > > xen/include/public/version.h | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/xen/include/public/version.h b/xen/include/public/version.h > > index adca602..b97fc68 100644 > > --- a/xen/include/public/version.h > > +++ b/xen/include/public/version.h > > @@ -79,6 +79,10 @@ typedef struct xen_feature_info xen_feature_info_t; > > #define XENVER_pagesize 7 > > > > /* arg == xen_domain_handle_t. */ > > +/* > > + * The toolstack fills it out for the guest consumption. Usually it is > > + * the UUID of the guest but can be anything. > > + */ > > #define XENVER_guest_handle 8 > > > > #define XENVER_commandline 9 > > I'm not a maintainer for this code, so an Ack would be meaningless, but > I just wanted to say thanks for documenting this. :) You can always do: Reviewed-by: :-) > > > Thanks, > Razvan
On 02/19/2016 04:32 PM, Konrad Rzeszutek Wilk wrote: > And what it is usually used for. > > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > --- > xen/include/public/version.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/xen/include/public/version.h b/xen/include/public/version.h > index adca602..b97fc68 100644 > --- a/xen/include/public/version.h > +++ b/xen/include/public/version.h > @@ -79,6 +79,10 @@ typedef struct xen_feature_info xen_feature_info_t; > #define XENVER_pagesize 7 > > /* arg == xen_domain_handle_t. */ > +/* > + * The toolstack fills it out for the guest consumption. Usually it is > + * the UUID of the guest but can be anything. > + */ > #define XENVER_guest_handle 8 > > #define XENVER_commandline 9 Reviewed-by: Razvan Cojocaru <rcojocaru@bitdefender.com> Thanks, Razvan
>>> On 19.02.16 at 15:32, <konrad@kernel.org> wrote: > --- a/xen/include/public/version.h > +++ b/xen/include/public/version.h > @@ -79,6 +79,10 @@ typedef struct xen_feature_info xen_feature_info_t; > #define XENVER_pagesize 7 > > /* arg == xen_domain_handle_t. */ > +/* > + * The toolstack fills it out for the guest consumption. Usually it is > + * the UUID of the guest but can be anything. > + */ > #define XENVER_guest_handle 8 Generally fine, but I'm not overly happy with the wording. I'd prefer if it was made slightly less vague this is meant to be the UUID. Maybe "The toolstack fills it out for guest consumption. It is intended to hold the UUID of the guest"? Jan
diff --git a/xen/include/public/version.h b/xen/include/public/version.h index adca602..b97fc68 100644 --- a/xen/include/public/version.h +++ b/xen/include/public/version.h @@ -79,6 +79,10 @@ typedef struct xen_feature_info xen_feature_info_t; #define XENVER_pagesize 7 /* arg == xen_domain_handle_t. */ +/* + * The toolstack fills it out for the guest consumption. Usually it is + * the UUID of the guest but can be anything. + */ #define XENVER_guest_handle 8 #define XENVER_commandline 9
And what it is usually used for. Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> --- xen/include/public/version.h | 4 ++++ 1 file changed, 4 insertions(+)