From patchwork Wed Feb 24 12:53:24 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harmandeep Kaur X-Patchwork-Id: 8405951 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id B41D5C0553 for ; Wed, 24 Feb 2016 12:56:55 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id D9B5720274 for ; Wed, 24 Feb 2016 12:56:54 +0000 (UTC) Received: from lists.xen.org (lists.xenproject.org [50.57.142.19]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E513F2011D for ; Wed, 24 Feb 2016 12:56:53 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aYYxe-00089v-AI; Wed, 24 Feb 2016 12:54:34 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1aYYxd-00088v-4A for xen-devel@lists.xenproject.org; Wed, 24 Feb 2016 12:54:33 +0000 Received: from [85.158.139.211] by server-14.bemta-5.messagelabs.com id 47/0A-02992-808ADC65; Wed, 24 Feb 2016 12:54:32 +0000 X-Env-Sender: write.harmandeep@gmail.com X-Msg-Ref: server-7.tower-206.messagelabs.com!1456318470!24427320!1 X-Originating-IP: [209.85.220.66] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 7.35.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 45801 invoked from network); 24 Feb 2016 12:54:31 -0000 Received: from mail-pa0-f66.google.com (HELO mail-pa0-f66.google.com) (209.85.220.66) by server-7.tower-206.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 24 Feb 2016 12:54:31 -0000 Received: by mail-pa0-f66.google.com with SMTP id a7so872384pax.3 for ; Wed, 24 Feb 2016 04:54:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Z7TVxeY4PO5SgTTHJjwtckg3p3jMoycNaShyUEacTzA=; b=ybckGBJBguLv1MMq4VuwFqidKUPxiGHqf+hycGrU3bLwDI2vQNw3kjZChIcH0xrgTy i9octuMRmraXEEMBBhnIC1eZznMLU1oJYFBqpJ806U0E6GhwRc8660dVqd66Dz9iimcS YIwARCIdvHd+LKcpHpazZNvkVOTroFjZmUK1dI2BKrSbb9oH7Wj6mOizeAoKgPiOMvth zrudfD95ywHp/rjDekJ9z/TjQyYfvr51JBSJPLEGnfewFKjAJPNLJi0SCfLQNOEn1swq kUa3FUrxfm3zy5L0QB0bd8XjdY0UrPvYwOxtyv1vgsPsUDD6ve2Y52wtS4ljM1vEVeFP ilZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Z7TVxeY4PO5SgTTHJjwtckg3p3jMoycNaShyUEacTzA=; b=OmSV9O0AOhskZmXMVjtIh0VVi3UTUH5WyJ1XylbBPLHH7MZKs3avk4GP5tzCKoqiqF vvKJuGpBrInpDAZR8gft5sdi82igRblgWpi33VVwCNxb402/XYzPjxQvVlA1f0sBAFJy HJWpQ/odDajjDukkzEneeE4ZWWouwXPy52jCbIMijeXEXKQkfVIVByInK32qAvxKCk0O JthckKYDyIWHdNO6hYFE0NnrXhiS0pHkf16hJDBrndAsl5MgkddstxFETxmGjjnfAszp J6IcGOaFIOvXqi7t/o+cQTCoSYPV81mgle9O9fVCvjDG5vHcGI5nI26B/2NR1OmCFbJ6 TfTw== X-Gm-Message-State: AG10YOQm/LN1AxusSIbCyLiaeCmVhCN+7Wb2n57wFqYr0KzumSEEq9QS5DmAO1Wp1kF7fg== X-Received: by 10.66.54.44 with SMTP id g12mr28696618pap.48.1456318469999; Wed, 24 Feb 2016 04:54:29 -0800 (PST) Received: from localhost.localdomain ([124.253.62.0]) by smtp.googlemail.com with ESMTPSA id t87sm5027294pfa.14.2016.02.24.04.54.26 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 24 Feb 2016 04:54:29 -0800 (PST) From: Harmandeep Kaur To: xen-devel@lists.xenproject.org Date: Wed, 24 Feb 2016 18:23:24 +0530 Message-Id: <1456318407-3635-7-git-send-email-write.harmandeep@gmail.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1456318407-3635-1-git-send-email-write.harmandeep@gmail.com> References: <1456318407-3635-1-git-send-email-write.harmandeep@gmail.com> Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, Harmandeep Kaur Subject: [Xen-devel] [PATCH 6/9] xl: Improve return and exit codes of main_list() and main_vm_list() related functions. X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Signed-off-by: Harmandeep Kaur --- tools/libxl/xl_cmdimpl.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index b4920ff..9d95b50 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -433,7 +433,7 @@ static void flush_stream(FILE *fh) if (ferror(fh) || fflush(fh)) { perror(fh_name); - exit(-1); + exit(EXIT_FAILURE); } } @@ -3927,12 +3927,12 @@ static void list_domains(bool verbose, bool context, bool claim, bool numa, if (numa) { if (libxl_node_bitmap_alloc(ctx, &nodemap, 0)) { fprintf(stderr, "libxl_node_bitmap_alloc_failed.\n"); - exit(1); + exit(EXIT_FAILURE); } if (libxl_get_physinfo(ctx, &physinfo) != 0) { fprintf(stderr, "libxl_physinfo failed.\n"); libxl_bitmap_dispose(&nodemap); - exit(1); + exit(EXIT_FAILURE); } printf(" NODE Affinity"); @@ -3996,7 +3996,7 @@ static void list_vm(void) if (!info) { fprintf(stderr, "libxl_list_vm failed.\n"); - exit(1); + exit(EXIT_FAILURE); } printf("UUID ID name\n"); for (i = 0; i < nb_vm; i++) { @@ -4944,7 +4944,7 @@ int main_list(int argc, char **argv) info = libxl_list_domain(ctx, &nb_domain); if (!info) { fprintf(stderr, "libxl_list_domain failed.\n"); - return 1; + return EXIT_FAILURE; } info_free = info; } else if (optind == argc-1) { @@ -4953,17 +4953,17 @@ int main_list(int argc, char **argv) if (rc == ERROR_DOMAIN_NOTFOUND) { fprintf(stderr, "Error: Domain \'%s\' does not exist.\n", argv[optind]); - return -rc; + return EXIT_FAILURE; } if (rc) { fprintf(stderr, "libxl_domain_info failed (code %d).\n", rc); - return -rc; + return EXIT_FAILURE; } info = &info_buf; nb_domain = 1; } else { help("list"); - return 2; + return EXIT_FAILURE; } if (details) @@ -4977,7 +4977,7 @@ int main_list(int argc, char **argv) libxl_dominfo_dispose(&info_buf); - return 0; + return EXIT_SUCCESS; } int main_vm_list(int argc, char **argv) @@ -4989,7 +4989,7 @@ int main_vm_list(int argc, char **argv) } list_vm(); - return 0; + return EXIT_SUCCESS; } static void string_realloc_append(char **accumulate, const char *more)