| Message ID | 1456583416-12785-1-git-send-email-wei.liu2@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Sat, Feb 27, 2016 at 9:30 AM, Wei Liu <wei.liu2@citrix.com> wrote: > Commit 7449fb36 ("migration/save: pass checkpointed_stream from libxl to > libxc ") failed to initialise rc in the error path. > > Reported-by: Olaf Hering <olaf@aepfle.de> > Signed-off-by: Wei Liu <wei.liu2@citrix.com> Reviewed and applied. > --- > Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > Cc: Ian Jackson <ian.jackson@eu.citrix.com> > Cc: Wen Congyang <wency@cn.fujitsu.com> > --- > tools/libxl/libxl_dom_save.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/libxl/libxl_dom_save.c b/tools/libxl/libxl_dom_save.c > index 4eb7960..f3288b9 100644 > --- a/tools/libxl/libxl_dom_save.c > +++ b/tools/libxl/libxl_dom_save.c > @@ -341,6 +341,7 @@ void libxl__domain_save(libxl__egc *egc, libxl__domain_save_state *dss) > if (dss->checkpointed_stream != LIBXL_CHECKPOINTED_STREAM_NONE && !r_info) { > LOG(ERROR, "Migration stream is checkpointed, but there's no " > "checkpoint info!"); > + rc = ERROR_INVAL; > goto out; > } > > -- > 2.1.4 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel
diff --git a/tools/libxl/libxl_dom_save.c b/tools/libxl/libxl_dom_save.c index 4eb7960..f3288b9 100644 --- a/tools/libxl/libxl_dom_save.c +++ b/tools/libxl/libxl_dom_save.c @@ -341,6 +341,7 @@ void libxl__domain_save(libxl__egc *egc, libxl__domain_save_state *dss) if (dss->checkpointed_stream != LIBXL_CHECKPOINTED_STREAM_NONE && !r_info) { LOG(ERROR, "Migration stream is checkpointed, but there's no " "checkpoint info!"); + rc = ERROR_INVAL; goto out; }
Commit 7449fb36 ("migration/save: pass checkpointed_stream from libxl to libxc ") failed to initialise rc in the error path. Reported-by: Olaf Hering <olaf@aepfle.de> Signed-off-by: Wei Liu <wei.liu2@citrix.com> --- Cc: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Cc: Ian Jackson <ian.jackson@eu.citrix.com> Cc: Wen Congyang <wency@cn.fujitsu.com> --- tools/libxl/libxl_dom_save.c | 1 + 1 file changed, 1 insertion(+)