diff mbox

[V2,3/4] Xen drivers: show hap enabled by default in capabilities

Message ID 1456804848-13127-4-git-send-email-jfehlig@suse.com (mailing list archive)
State New, archived
Headers show

Commit Message

Jim Fehlig March 1, 2016, 4 a.m. UTC
Hardware Assisted Paging is enabled by default in Xen. Change
the capabilities output to reflect this.

Signed-off-by: Jim Fehlig <jfehlig@suse.com>
---
 src/libxl/libxl_conf.c   | 2 +-
 src/xen/xen_hypervisor.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Joao Martins March 8, 2016, 4:37 p.m. UTC | #1
On 03/01/2016 04:00 AM, Jim Fehlig wrote:
> Hardware Assisted Paging is enabled by default in Xen. Change
> the capabilities output to reflect this.
> 
> Signed-off-by: Jim Fehlig <jfehlig@suse.com>
> ---
>  src/libxl/libxl_conf.c   | 2 +-
>  src/xen/xen_hypervisor.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
> index 93c943b..6efd9b5 100644
> --- a/src/libxl/libxl_conf.c
> +++ b/src/libxl/libxl_conf.c
> @@ -493,7 +493,7 @@ libxlCapsInitGuests(libxl_ctx *ctx, virCapsPtr caps)
>  
>              if (virCapabilitiesAddGuestFeature(guest,
>                                                 "hap",
> -                                               0,
> +                                               1,
>                                                 1) == NULL)
>                  return -1;
>          }
> diff --git a/src/xen/xen_hypervisor.c b/src/xen/xen_hypervisor.c
> index c1834cb..fc9e1c6 100644
> --- a/src/xen/xen_hypervisor.c
> +++ b/src/xen/xen_hypervisor.c
> @@ -2206,7 +2206,7 @@ xenHypervisorBuildCapabilities(virConnectPtr conn, virArch hostarch,
>              if ((hv_major == 3 && hv_minor >= 3) || (hv_major > 3))
>                  if (virCapabilitiesAddGuestFeature(guest,
>                                                     "hap",
> -                                                   false,
> +                                                   true,
>                                                     true) == NULL)
>                      goto no_memory;
>  
> 

For the libxl part,

Reviewed-by: Joao Martins <joao.m.martins@oracle.com>
diff mbox

Patch

diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
index 93c943b..6efd9b5 100644
--- a/src/libxl/libxl_conf.c
+++ b/src/libxl/libxl_conf.c
@@ -493,7 +493,7 @@  libxlCapsInitGuests(libxl_ctx *ctx, virCapsPtr caps)
 
             if (virCapabilitiesAddGuestFeature(guest,
                                                "hap",
-                                               0,
+                                               1,
                                                1) == NULL)
                 return -1;
         }
diff --git a/src/xen/xen_hypervisor.c b/src/xen/xen_hypervisor.c
index c1834cb..fc9e1c6 100644
--- a/src/xen/xen_hypervisor.c
+++ b/src/xen/xen_hypervisor.c
@@ -2206,7 +2206,7 @@  xenHypervisorBuildCapabilities(virConnectPtr conn, virArch hostarch,
             if ((hv_major == 3 && hv_minor >= 3) || (hv_major > 3))
                 if (virCapabilitiesAddGuestFeature(guest,
                                                    "hap",
-                                                   false,
+                                                   true,
                                                    true) == NULL)
                     goto no_memory;