From patchwork Tue Mar 8 19:02:07 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harmandeep Kaur X-Patchwork-Id: 8536811 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 4377C9F8A8 for ; Tue, 8 Mar 2016 19:05:34 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 711CA201FE for ; Tue, 8 Mar 2016 19:05:33 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 86ED12015E for ; Tue, 8 Mar 2016 19:05:32 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xen.org with esmtp (Exim 4.84) (envelope-from ) id 1adMuO-0000yD-ED; Tue, 08 Mar 2016 19:03:04 +0000 Received: from mail6.bemta6.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.84) (envelope-from ) id 1adMuM-0000x3-H1 for xen-devel@lists.xenproject.org; Tue, 08 Mar 2016 19:03:02 +0000 Received: from [85.158.143.35] by server-1.bemta-6.messagelabs.com id 40/4C-03034-5E12FD65; Tue, 08 Mar 2016 19:03:01 +0000 X-Env-Sender: write.harmandeep@gmail.com X-Msg-Ref: server-15.tower-21.messagelabs.com!1457463781!4818255!1 X-Originating-IP: [74.125.82.66] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.11; banners=-,-,- X-VirusChecked: Checked Received: (qmail 11335 invoked from network); 8 Mar 2016 19:03:01 -0000 Received: from mail-wm0-f66.google.com (HELO mail-wm0-f66.google.com) (74.125.82.66) by server-15.tower-21.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 8 Mar 2016 19:03:01 -0000 Received: by mail-wm0-f66.google.com with SMTP id 1so5909126wmg.2 for ; Tue, 08 Mar 2016 11:03:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=694u/w9vOlNJQPEUdlUcGM0ZfDkGBxjxF9wJYwpOLNg=; b=izT7OnIgcleDiJpgUtkwQ4LnUhESDOTNS/egILgyS44lNSLleMf12WSM1oFD3lD50B VJR9448Piki8fLvqz4VPLYsrSkcWLy+UGB3aJ8GuxcOzVvy8emr+ohO7anxUpsAYLGk9 mR1YTpojmZRGK9leHt7E/jt/sWLNDBL/fw2+O4XOG/5HWKYskzu1t8AYwQCj3z3py3L+ zt+EyC/j0VX8x6CJ7CAD7PXkXQPzwHNLKLZz07ne1kX8oyF2QBygrfWX3FShx3Y4UWjH QYrJJqwYDUh6HuLQBZtMalVWoaJpOVahxWSDsCN3G1ZCKkpfwH1sn0rwQgNQHRW/bqCI q3ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=694u/w9vOlNJQPEUdlUcGM0ZfDkGBxjxF9wJYwpOLNg=; b=PB5ZVhBS5X3hwFCEU9uEXeRE51xta4mqqLokcJ6PhkNdC8P1iWt5TxDJpGkWPnPxj+ hmqWjmYpzwfJs2qse1qJ/EBXOeZsG4uUQr1f5BKRttbL06Wjv3XUzabb8DpkMZfclnob pBxa1pjXhdC4WhxVpT+9mZR8upfR89Xb59DS6AB5QnCQCJ6EZqZEo45N/t8Qo08nURCg DyVbG1+dQf4No53Z31+gdJwa3QeV0/wUupl5qhNPhHhLs+5TvaiGroqxU9ZJYYNWC5Ay ir5QXY876/nt170w3TNQCo4pD2gg/fISjQGAN+GGP90AWAnfnG5MAw9Uu74ReyWh2BF0 X6lA== X-Gm-Message-State: AD7BkJIpHqqw7J13l09n7mk0vzvlYV1wAv6KeIcSVGr4b2YZF01udtTCYOW1ZBJ5xRFkpA== X-Received: by 10.194.63.75 with SMTP id e11mr30619399wjs.79.1457463780990; Tue, 08 Mar 2016 11:03:00 -0800 (PST) Received: from localhost.localdomain ([124.253.57.150]) by smtp.googlemail.com with ESMTPSA id hu1sm4310795wjb.36.2016.03.08.11.02.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 08 Mar 2016 11:03:00 -0800 (PST) From: Harmandeep Kaur To: xen-devel@lists.xenproject.org Date: Wed, 9 Mar 2016 00:32:07 +0530 Message-Id: <1457463730-4712-7-git-send-email-write.harmandeep@gmail.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1457463730-4712-1-git-send-email-write.harmandeep@gmail.com> References: <1457463730-4712-1-git-send-email-write.harmandeep@gmail.com> Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, Harmandeep Kaur Subject: [Xen-devel] [PATCH 6/9 v2] xl: Improve return and exit codes of list related functions. X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP flush_stream(), list_domains(), list_vm(), main_list() and main_vm_list() are fixed. Signed-off-by: Harmandeep Kaur --- v2: No changes. --- tools/libxl/xl_cmdimpl.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 02aec34..4011c81 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -433,7 +433,7 @@ static void flush_stream(FILE *fh) if (ferror(fh) || fflush(fh)) { perror(fh_name); - exit(-1); + exit(EXIT_FAILURE); } } @@ -3936,12 +3936,12 @@ static void list_domains(bool verbose, bool context, bool claim, bool numa, if (numa) { if (libxl_node_bitmap_alloc(ctx, &nodemap, 0)) { fprintf(stderr, "libxl_node_bitmap_alloc_failed.\n"); - exit(1); + exit(EXIT_FAILURE); } if (libxl_get_physinfo(ctx, &physinfo) != 0) { fprintf(stderr, "libxl_physinfo failed.\n"); libxl_bitmap_dispose(&nodemap); - exit(1); + exit(EXIT_FAILURE); } printf(" NODE Affinity"); @@ -4005,7 +4005,7 @@ static void list_vm(void) if (!info) { fprintf(stderr, "libxl_list_vm failed.\n"); - exit(1); + exit(EXIT_FAILURE); } printf("UUID ID name\n"); for (i = 0; i < nb_vm; i++) { @@ -4959,7 +4959,7 @@ int main_list(int argc, char **argv) info = libxl_list_domain(ctx, &nb_domain); if (!info) { fprintf(stderr, "libxl_list_domain failed.\n"); - return 1; + return EXIT_FAILURE; } info_free = info; } else if (optind == argc-1) { @@ -4968,17 +4968,17 @@ int main_list(int argc, char **argv) if (rc == ERROR_DOMAIN_NOTFOUND) { fprintf(stderr, "Error: Domain \'%s\' does not exist.\n", argv[optind]); - return -rc; + return EXIT_FAILURE; } if (rc) { fprintf(stderr, "libxl_domain_info failed (code %d).\n", rc); - return -rc; + return EXIT_FAILURE; } info = &info_buf; nb_domain = 1; } else { help("list"); - return 2; + return EXIT_FAILURE; } if (details) @@ -4992,7 +4992,7 @@ int main_list(int argc, char **argv) libxl_dominfo_dispose(&info_buf); - return 0; + return EXIT_SUCCESS; } int main_vm_list(int argc, char **argv) @@ -5004,7 +5004,7 @@ int main_vm_list(int argc, char **argv) } list_vm(); - return 0; + return EXIT_SUCCESS; } static void string_realloc_append(char **accumulate, const char *more)