From patchwork Tue Mar 8 19:02:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harmandeep Kaur X-Patchwork-Id: 8536761 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 8E1FC9F372 for ; Tue, 8 Mar 2016 19:05:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C34772015E for ; Tue, 8 Mar 2016 19:05:24 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E123220155 for ; Tue, 8 Mar 2016 19:05:23 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xen.org with esmtp (Exim 4.84) (envelope-from ) id 1adMua-00014c-MP; Tue, 08 Mar 2016 19:03:16 +0000 Received: from mail6.bemta6.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.84) (envelope-from ) id 1adMuY-00013o-Uu for xen-devel@lists.xenproject.org; Tue, 08 Mar 2016 19:03:15 +0000 Received: from [85.158.143.35] by server-2.bemta-6.messagelabs.com id D6/89-01728-2F12FD65; Tue, 08 Mar 2016 19:03:14 +0000 X-Env-Sender: write.harmandeep@gmail.com X-Msg-Ref: server-7.tower-21.messagelabs.com!1457463791!4948676!1 X-Originating-IP: [74.125.82.68] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 8.11; banners=-,-,- X-VirusChecked: Checked Received: (qmail 21838 invoked from network); 8 Mar 2016 19:03:13 -0000 Received: from mail-wm0-f68.google.com (HELO mail-wm0-f68.google.com) (74.125.82.68) by server-7.tower-21.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 8 Mar 2016 19:03:13 -0000 Received: by mail-wm0-f68.google.com with SMTP id l68so5893967wml.3 for ; Tue, 08 Mar 2016 11:03:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=AWFcz8sLU3z4t3S/TOVngy23/yzfI4Cod7ubZPOm0xg=; b=bU0cO2a6U0tyWNKWsiA7DIOgXvwmHyZkF/N8ifPSTXFox3LQquS2lBuoj9c5DDK5FD Rr/3Dz5HVVDFQ7fgA3M+7/uh4doZTWE8cAITK5ZJ5XmGdP9Uuf96diwZgKWuxjkhlhcb QtLRSt75lMQ2ybSRoVWshSLI1FNF0SnR8PSN6CNIG+RfTQU4bDHr5nTC2fr1i90xw5hn F/aCZzgWaRJLJfm3V3uGmLwDESs6SkBj8UKW9+Yfd0L3WDmzBDRUC4iFUi22eAF4P4n0 CxqjOSpP9p1nohyFiBmoNMiKQU4Y7KP1mtQDWHOMCjNXasC4LWpKldAncsg48Qnm2v5x tlHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=AWFcz8sLU3z4t3S/TOVngy23/yzfI4Cod7ubZPOm0xg=; b=A0sL5xeOMpun/xENuVsnyik1xspcK/H5Dz65FJm1UlJZxEo1vqsZTg5tLaHw6mmnkc IxrBL/AXNZ0YqAxbW9taYiNuPsOM7DwKrhHoksAoKY+1HcbBvlwQjySERrSrMNYCGVwU wnRmyIYB83PeKgPPAthSAUJi+mufqr2I2q2lxzY9ZMjtTaOqJGkxuCvjLiYJ2qpMT03e UEoWa0NRDavoxS3vveZLNJ8ckvikQgWBNGvaV19h4UDGvTP2xggFlNcmZL5/Hm1aa6om 83DO6lhGf+kasGaNm3wz+vtEH90sJEKAmJz3r73Y5oiYjOAmxN9v1ly2n8b++COWspqX Pz3g== X-Gm-Message-State: AD7BkJLqiUE8oOjroQA5tybnkNSW9wFhY9RZq1Hhy3d4vdiHLuP0pggTpBHK4vWuvZn4kg== X-Received: by 10.28.46.82 with SMTP id u79mr22418176wmu.67.1457463791242; Tue, 08 Mar 2016 11:03:11 -0800 (PST) Received: from localhost.localdomain ([124.253.57.150]) by smtp.googlemail.com with ESMTPSA id hu1sm4310795wjb.36.2016.03.08.11.03.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 08 Mar 2016 11:03:10 -0800 (PST) From: Harmandeep Kaur To: xen-devel@lists.xenproject.org Date: Wed, 9 Mar 2016 00:32:09 +0530 Message-Id: <1457463730-4712-9-git-send-email-write.harmandeep@gmail.com> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1457463730-4712-1-git-send-email-write.harmandeep@gmail.com> References: <1457463730-4712-1-git-send-email-write.harmandeep@gmail.com> Cc: wei.liu2@citrix.com, ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, Harmandeep Kaur Subject: [Xen-devel] [PATCH 8/9 v2] xl : Improve return and exit codes debugging, special keys and triggering related functions. X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=no version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP button_press(), main_trigger(), main_sysrq(), main_debug_keys() and main_dmesg() are fixed. Signed-off-by: Harmandeep Kaur --- v2: Add main_sysrq(), main_debug_keys(), main_dmesg() Remove xvasprintf(), main_remus() --- tools/libxl/xl_cmdimpl.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index f0b5efc..4b2ae68 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -5231,7 +5231,7 @@ static void button_press(uint32_t domid, const char *b) trigger = LIBXL_TRIGGER_SLEEP; } else { fprintf(stderr, "%s is an invalid button identifier\n", b); - exit(2); + exit(EXIT_FAILURE); } libxl_send_trigger(ctx, domid, trigger, 0); @@ -6413,7 +6413,7 @@ int main_trigger(int argc, char **argv) trigger_name = argv[optind++]; if (libxl_trigger_from_string(trigger_name, &trigger)) { fprintf(stderr, "Invalid trigger \"%s\"\n", trigger_name); - return -1; + return EXIT_FAILURE; } if (argv[optind]) { @@ -6425,7 +6425,7 @@ int main_trigger(int argc, char **argv) libxl_send_trigger(ctx, domid, trigger, vcpuid); - return 0; + return EXIT_SUCCESS; } @@ -6446,12 +6446,12 @@ int main_sysrq(int argc, char **argv) if (sysrq[1] != '\0') { fprintf(stderr, "Invalid sysrq.\n\n"); help("sysrq"); - return 1; + return EXIT_FAILURE; } libxl_send_sysrq(ctx, domid, sysrq[0]); - return 0; + return EXIT_SUCCESS; } int main_debug_keys(int argc, char **argv) @@ -6467,10 +6467,10 @@ int main_debug_keys(int argc, char **argv) if (libxl_send_debug_keys(ctx, keys)) { fprintf(stderr, "cannot send debug keys: %s\n", keys); - return 1; + return EXIT_FAILURE; } - return 0; + return EXIT_SUCCESS; } int main_dmesg(int argc, char **argv) @@ -6496,7 +6496,7 @@ int main_dmesg(int argc, char **argv) finish: if (cr) libxl_xen_console_read_finish(ctx, cr); - return ret; + return ret ? EXIT_FAILURE : EXIT_SUCCESS; } int main_top(int argc, char **argv)