| Message ID | 1457987365-866-5-git-send-email-cardoe@cardoe.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
>>> On 14.03.16 at 21:29, <cardoe@cardoe.com> wrote: > tmem_xen.h assumes that all users will have already included stdbool.h > which might not always be true. Wait, no - stdbool.h is not supposed to be included in code other than such shared with the tool stack. I see ARM has gained some of those (Julien, Stefano?), but adding more is not acceptable. I.e. the adjustment, if any is needed (as I can't right away see how things would build if there really was such a dependency, and indeed neither .tmem.o.d nor .tmem_xen.o.d list any stdbool.h as dependencies), would be to replace uses of bool, true, and false (of which I can't find any in that header) by their canonical hypervisor variants. Jan
diff --git a/xen/include/xen/tmem_xen.h b/xen/include/xen/tmem_xen.h index f516bbe..b95bde9 100644 --- a/xen/include/xen/tmem_xen.h +++ b/xen/include/xen/tmem_xen.h @@ -9,6 +9,7 @@ #ifndef __XEN_TMEM_XEN_H__ #define __XEN_TMEM_XEN_H__ +#include <xen/stdbool.h> #include <xen/mm.h> /* heap alloc/free */ #include <xen/pfn.h> #include <xen/xmalloc.h> /* xmalloc/xfree */
tmem_xen.h assumes that all users will have already included stdbool.h which might not always be true. Signed-off-by: Doug Goldstein <cardoe@cardoe.com> --- CC: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> --- xen/include/xen/tmem_xen.h | 1 + 1 file changed, 1 insertion(+)