diff mbox

[v4,01/34] compat/x86: Remove unncessary #define.

Message ID 1458064616-23101-2-git-send-email-konrad.wilk@oracle.com (mailing list archive)
State New, archived
Headers show

Commit Message

Konrad Rzeszutek Wilk March 15, 2016, 5:56 p.m. UTC
It is not used.

Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>
Cc: Tim Deegan <tim@xen.org>
---
---
 xen/common/compat/kernel.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Andrew Cooper March 15, 2016, 6:57 p.m. UTC | #1
On 15/03/16 17:56, Konrad Rzeszutek Wilk wrote:
> It is not used.
>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Jan Beulich March 16, 2016, 11:08 a.m. UTC | #2
>>> On 15.03.16 at 18:56, <konrad.wilk@oracle.com> wrote:
> It is not used.

Consistently please - either keep them all (just to cover the case
that they might get used) or remove them all: xen_compile_info,
xen_changeset_info, etc are all unused too. Otoh
xennmi_callback is used, but xennmi_callback_t isn't. Which to me
suggests that we should leave this alone.

Jan

> --- a/xen/common/compat/kernel.c
> +++ b/xen/common/compat/kernel.c
> @@ -18,7 +18,6 @@ asm(".file \"" __FILE__ "\"");
>  
>  extern xen_commandline_t saved_cmdline;
>  
> -#define xen_extraversion compat_extraversion
>  #define xen_extraversion_t compat_extraversion_t
>  
>  #define xen_compile_info compat_compile_info
> -- 
> 2.5.0
diff mbox

Patch

diff --git a/xen/common/compat/kernel.c b/xen/common/compat/kernel.c
index df93fdd..e1b9013 100644
--- a/xen/common/compat/kernel.c
+++ b/xen/common/compat/kernel.c
@@ -18,7 +18,6 @@  asm(".file \"" __FILE__ "\"");
 
 extern xen_commandline_t saved_cmdline;
 
-#define xen_extraversion compat_extraversion
 #define xen_extraversion_t compat_extraversion_t
 
 #define xen_compile_info compat_compile_info