| Message ID | 1458064616-23101-3-git-send-email-konrad.wilk@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 15/03/16 17:56, Konrad Rzeszutek Wilk wrote: > The 'caps' is not used anywhere in there. > > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
On Tue, Mar 15, 2016 at 06:04:16PM +0000, Andrew Cooper wrote: > On 15/03/16 17:56, Konrad Rzeszutek Wilk wrote: > > The 'caps' is not used anywhere in there. > > > > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > > Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com> And the winnner for fastest review time goes to Andrew. "In less than 60 seconds and he pounces on the patch! He tags it!!! And off he goes for the next one!"
On Tue, Mar 15, 2016 at 01:56:24PM -0400, Konrad Rzeszutek Wilk wrote: > The 'caps' is not used anywhere in there. > > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > > --- > Cc: Ian Jackson <ian.jackson@eu.citrix.com> > Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > Cc: Wei Liu <wei.liu2@citrix.com> Acked-by: Wei Liu <wei.liu2@citrix.com> > --- > --- > tools/libxc/xc_dom_x86.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/tools/libxc/xc_dom_x86.c b/tools/libxc/xc_dom_x86.c > index bdec40a..021f8a8 100644 > --- a/tools/libxc/xc_dom_x86.c > +++ b/tools/libxc/xc_dom_x86.c > @@ -1259,7 +1259,6 @@ static int meminit_hvm(struct xc_dom_image *dom) > unsigned long target_pages = dom->target_pages; > unsigned long cur_pages, cur_pfn; > int rc; > - xen_capabilities_info_t caps; > unsigned long stat_normal_pages = 0, stat_2mb_pages = 0, > stat_1gb_pages = 0; > unsigned int memflags = 0; > @@ -1339,12 +1338,6 @@ static int meminit_hvm(struct xc_dom_image *dom) > goto error_out; > } > > - if ( xc_version(xch, XENVER_capabilities, &caps) != 0 ) > - { > - DOMPRINTF("Could not get Xen capabilities"); > - goto error_out; > - } > - > dom->p2m_size = p2m_size; > dom->p2m_host = xc_dom_malloc(dom, sizeof(xen_pfn_t) * > dom->p2m_size); > -- > 2.5.0 >
diff --git a/tools/libxc/xc_dom_x86.c b/tools/libxc/xc_dom_x86.c index bdec40a..021f8a8 100644 --- a/tools/libxc/xc_dom_x86.c +++ b/tools/libxc/xc_dom_x86.c @@ -1259,7 +1259,6 @@ static int meminit_hvm(struct xc_dom_image *dom) unsigned long target_pages = dom->target_pages; unsigned long cur_pages, cur_pfn; int rc; - xen_capabilities_info_t caps; unsigned long stat_normal_pages = 0, stat_2mb_pages = 0, stat_1gb_pages = 0; unsigned int memflags = 0; @@ -1339,12 +1338,6 @@ static int meminit_hvm(struct xc_dom_image *dom) goto error_out; } - if ( xc_version(xch, XENVER_capabilities, &caps) != 0 ) - { - DOMPRINTF("Could not get Xen capabilities"); - goto error_out; - } - dom->p2m_size = p2m_size; dom->p2m_host = xc_dom_malloc(dom, sizeof(xen_pfn_t) * dom->p2m_size);
The 'caps' is not used anywhere in there. Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> --- Cc: Ian Jackson <ian.jackson@eu.citrix.com> Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com> Cc: Wei Liu <wei.liu2@citrix.com> --- --- tools/libxc/xc_dom_x86.c | 7 ------- 1 file changed, 7 deletions(-)