| Message ID | 1458161499-15313-3-git-send-email-ben.sanda@dornerworks.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 16/03/2016 20:51, Benjamin Sanda wrote: > From: bensanda <ben.sanda@dornerworks.com> > > Modified to provide building of the xenalyze binary for ARM platforms. This was done in conjunction with patches to xentrace allowing its use on ARM. The xenalyze binary is now built as part of the SBIN list. It should be part of the unconditional BIN list, rather than SBIN. xenalyse does not need special permissions to run, so shouldn't be restricted to supervisor-only. ~Andrew > > Signed-off-by: Benjamin Sanda <ben.sanda@dornerworks.com> > --- > tools/xentrace/Makefile | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/tools/xentrace/Makefile b/tools/xentrace/Makefile > index 0157be2..180add4 100644 > --- a/tools/xentrace/Makefile > +++ b/tools/xentrace/Makefile > @@ -9,9 +9,8 @@ LDLIBS += $(LDLIBS_libxenevtchn) > LDLIBS += $(LDLIBS_libxenctrl) > LDLIBS += $(ARGP_LDFLAGS) > > -BIN-$(CONFIG_X86) = xenalyze > BIN = $(BIN-y) > -SBIN = xentrace xentrace_setsize > +SBIN = xenalyze xentrace xentrace_setsize > LIBBIN = xenctx > SCRIPTS = xentrace_format >
On Wed, Mar 16, 2016 at 8:59 PM, Andrew Cooper <andrew.cooper3@citrix.com> wrote: > On 16/03/2016 20:51, Benjamin Sanda wrote: >> From: bensanda <ben.sanda@dornerworks.com> >> >> Modified to provide building of the xenalyze binary for ARM platforms. This was done in conjunction with patches to xentrace allowing its use on ARM. The xenalyze binary is now built as part of the SBIN list. > > It should be part of the unconditional BIN list, rather than SBIN. > > xenalyse does not need special permissions to run, so shouldn't be > restricted to supervisor-only. Andrew is correct -- please replace both BIN lines with BIN = xenalyze Thanks, -George
diff --git a/tools/xentrace/Makefile b/tools/xentrace/Makefile index 0157be2..180add4 100644 --- a/tools/xentrace/Makefile +++ b/tools/xentrace/Makefile @@ -9,9 +9,8 @@ LDLIBS += $(LDLIBS_libxenevtchn) LDLIBS += $(LDLIBS_libxenctrl) LDLIBS += $(ARGP_LDFLAGS) -BIN-$(CONFIG_X86) = xenalyze BIN = $(BIN-y) -SBIN = xentrace xentrace_setsize +SBIN = xenalyze xentrace xentrace_setsize LIBBIN = xenctx SCRIPTS = xentrace_format