diff mbox

[v5,25/28] xsplice: Print dependency and payloads build_id in the keyhandler.

Message ID 1458849640-22588-26-git-send-email-konrad.wilk@oracle.com (mailing list archive)
State New, archived
Headers show

Commit Message

Konrad Rzeszutek Wilk March 24, 2016, 8 p.m. UTC 
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>
Cc: Tim Deegan <tim@xen.org>
---
---
 xen/common/xsplice.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Jan Beulich April 4, 2016, 3:03 p.m. UTC | #1 
>>> On 24.03.16 at 21:00, <konrad.wilk@oracle.com> wrote:
> --- a/xen/common/xsplice.c
> +++ b/xen/common/xsplice.c
> @@ -1514,6 +1514,11 @@ static void xsplice_printall(unsigned char key)
>              if ( !(i % 100) )
>                  process_pending_softirqs();
>          }
> +        if ( data->id.len )
> +            printk("build-id=%*phN\n", data->id.len, data->id.p);
> +
> +        if ( data->dep.len )
> +            printk("depend-on=%*phN\n", data->dep.len, data->dep.p);
>      }
>  
>      spin_unlock_recursive(&payload_lock);

Looks certainly fine, but wouldn't this better be part of patch 23?

Jan
diff mbox

Patch

diff --git a/xen/common/xsplice.c b/xen/common/xsplice.c
index d7a65fe..d5d4b3c 100644
--- a/xen/common/xsplice.c
+++ b/xen/common/xsplice.c
@@ -1514,6 +1514,11 @@  static void xsplice_printall(unsigned char key)
             if ( !(i % 100) )
                 process_pending_softirqs();
         }
+        if ( data->id.len )
+            printk("build-id=%*phN\n", data->id.len, data->id.p);
+
+        if ( data->dep.len )
+            printk("depend-on=%*phN\n", data->dep.len, data->dep.p);
     }
 
     spin_unlock_recursive(&payload_lock);