@@ -7205,7 +7205,7 @@ int main_tmem_freeze(int argc, char **argv)
if (!dom && all == 0) {
fprintf(stderr, "You must specify -a or a domain id.\n\n");
help("tmem-freeze");
- return 1;
+ return EXIT_FAILURE;
}
if (all)
@@ -7213,8 +7213,11 @@ int main_tmem_freeze(int argc, char **argv)
else
domid = find_domain(dom);
- libxl_tmem_freeze(ctx, domid);
- return 0;
+ if (libxl_tmem_freeze(ctx, domid) < 0) {
+ return EXIT_FAILURE;
+ }
+
+ return EXIT_SUCCESS;
}
int main_tmem_thaw(int argc, char **argv)
@@ -7234,7 +7237,7 @@ int main_tmem_thaw(int argc, char **argv)
if (!dom && all == 0) {
fprintf(stderr, "You must specify -a or a domain id.\n\n");
help("tmem-thaw");
- return 1;
+ return EXIT_FAILURE;
}
if (all)
@@ -7242,8 +7245,11 @@ int main_tmem_thaw(int argc, char **argv)
else
domid = find_domain(dom);
- libxl_tmem_thaw(ctx, domid);
- return 0;
+ if (libxl_tmem_thaw(ctx, domid) < 0) {
+ return EXIT_FAILURE;
+ }
+
+ return EXIT_SUCCESS;
}
int main_tmem_set(int argc, char **argv)
@@ -7254,6 +7260,7 @@ int main_tmem_set(int argc, char **argv)
int opt_w = 0, opt_c = 0, opt_p = 0;
int all = 0;
int opt;
+ int r = 0;
SWITCH_FOREACH_OPT(opt, "aw:c:p:", NULL, "tmem-set", 0) {
case 'a':
@@ -7277,7 +7284,7 @@ int main_tmem_set(int argc, char **argv)
if (!dom && all == 0) {
fprintf(stderr, "You must specify -a or a domain id.\n\n");
help("tmem-set");
- return 1;
+ return EXIT_FAILURE;
}
if (all)
@@ -7288,17 +7295,21 @@ int main_tmem_set(int argc, char **argv)
if (!opt_w && !opt_c && !opt_p) {
fprintf(stderr, "No set value specified.\n\n");
help("tmem-set");
- return 1;
+ return EXIT_FAILURE;
}
if (opt_w)
- libxl_tmem_set(ctx, domid, "weight", weight);
+ r = libxl_tmem_set(ctx, domid, "weight", weight);
if (opt_c)
- libxl_tmem_set(ctx, domid, "cap", cap);
+ r = libxl_tmem_set(ctx, domid, "cap", cap);
if (opt_p)
- libxl_tmem_set(ctx, domid, "compress", compress);
+ r = libxl_tmem_set(ctx, domid, "compress", compress);
- return 0;
+ if (r < 0) {
+ return EXIT_FAILURE;
+ }
+
+ return EXIT_SUCCESS;
}
int main_tmem_shared_auth(int argc, char **argv)
@@ -7328,7 +7339,7 @@ int main_tmem_shared_auth(int argc, char **argv)
if (!dom && all == 0) {
fprintf(stderr, "You must specify -a or a domain id.\n\n");
help("tmem-shared-auth");
- return 1;
+ return EXIT_FAILURE;
}
if (all)
@@ -7339,18 +7350,20 @@ int main_tmem_shared_auth(int argc, char **argv)
if (uuid == NULL || autharg == NULL) {
fprintf(stderr, "No uuid or auth specified.\n\n");
help("tmem-shared-auth");
- return 1;
+ return EXIT_FAILURE;
}
auth = strtol(autharg, &endptr, 10);
if (*endptr != '\0') {
fprintf(stderr, "Invalid auth, valid auth are <0|1>.\n\n");
- return 1;
+ return EXIT_FAILURE;
}
- libxl_tmem_shared_auth(ctx, domid, uuid, auth);
+ if (libxl_tmem_shared_auth(ctx, domid, uuid, auth) < 0) {
+ return EXIT_FAILURE;
+ }
- return 0;
+ return EXIT_SUCCESS;
}
int main_tmem_freeable(int argc, char **argv)
@@ -7364,10 +7377,10 @@ int main_tmem_freeable(int argc, char **argv)
mb = libxl_tmem_freeable(ctx);
if (mb == -1)
- return -1;
+ return EXIT_FAILURE;
printf("%d\n", mb);
- return 0;
+ return EXIT_SUCCESS;
}
int main_cpupoolcreate(int argc, char **argv)
Functions libxl_tmem_freeze(), libxl_tmem_thaw(), libxl_tmem_set() and libxl_tmem_shared_auth() located in libxl.c file return ERROR_FAIL/ERROR_INVAL or internal error codes from libxc library * improve main_tmem_* return codes by returning EXIT_{SUCCESS/FAILURE} accordingly to return codes of those functions. Signed-off-by: Paulina Szubarczyk <paulinaszubarczyk@gmail.com> CC: Wei Liu <wei.liu2@citrix.com> CC: Ian Jackson <ian.jackson@eu.citrix.com> CC: Dario Faggioli <dario.faggioli@citrix.com> CC: Ian Campbell <ian.campbell@citrix.com> --- tools/libxl/xl_cmdimpl.c | 51 ++++++++++++++++++++++++++++++------------------ 1 file changed, 32 insertions(+), 19 deletions(-) -- 1.9.1