diff mbox

tools: add missing header for xenctrl.h

Message ID 1459478802-11121-1-git-send-email-xiecl.fnst@cn.fujitsu.com (mailing list archive)
State New, archived
Headers show

Commit Message

Changlong Xie April 1, 2016, 2:46 a.m. UTC
Commit d275ec9c introduce ssize_t but not include relevant header,
it will cause compile errors just like below:

./include/xenctrl.h:1485: error: expected '=', ',', ';', 'asm' or
'__attribute__' before 'xc_version_len'

Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
---
 tools/libxc/include/xenctrl.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Changlong Xie April 1, 2016, 2:52 a.m. UTC | #1
My build machine is

master:/etc # cat SuSE-release
SUSE Linux Enterprise Server 11 (x86_64)
VERSION = 11
PATCHLEVEL = 3

You may not to reproduce the same errors on fedora or some other platforms.

On 04/01/2016 10:46 AM, Changlong Xie wrote:
> Commit d275ec9c introduce ssize_t but not include relevant header,
> it will cause compile errors just like below:
>
> ./include/xenctrl.h:1485: error: expected '=', ',', ';', 'asm' or
> '__attribute__' before 'xc_version_len'
>
> Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> ---
>   tools/libxc/include/xenctrl.h | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenctrl.h
> index a9e4dc1..fb5c26c 100644
> --- a/tools/libxc/include/xenctrl.h
> +++ b/tools/libxc/include/xenctrl.h
> @@ -31,6 +31,7 @@
>   #include <stdint.h>
>   #include <stdio.h>
>   #include <stdbool.h>
> +#include <unistd.h>
>   #include <xen/xen.h>
>   #include <xen/domctl.h>
>   #include <xen/physdev.h>
>
Wei Liu April 1, 2016, 10:04 a.m. UTC | #2
On Fri, Apr 01, 2016 at 10:52:08AM +0800, Changlong Xie wrote:
> My build machine is
> 
> master:/etc # cat SuSE-release
> SUSE Linux Enterprise Server 11 (x86_64)
> VERSION = 11
> PATCHLEVEL = 3
> 
> You may not to reproduce the same errors on fedora or some other platforms.
> 

Olaf posted a similar patch yesterday.

This issue will be fixed soon.

Wei.

> On 04/01/2016 10:46 AM, Changlong Xie wrote:
> >Commit d275ec9c introduce ssize_t but not include relevant header,
> >it will cause compile errors just like below:
> >
> >./include/xenctrl.h:1485: error: expected '=', ',', ';', 'asm' or
> >'__attribute__' before 'xc_version_len'
> >
> >Signed-off-by: Wen Congyang <wency@cn.fujitsu.com>
> >Signed-off-by: Changlong Xie <xiecl.fnst@cn.fujitsu.com>
> >---
> >  tools/libxc/include/xenctrl.h | 1 +
> >  1 file changed, 1 insertion(+)
> >
> >diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenctrl.h
> >index a9e4dc1..fb5c26c 100644
> >--- a/tools/libxc/include/xenctrl.h
> >+++ b/tools/libxc/include/xenctrl.h
> >@@ -31,6 +31,7 @@
> >  #include <stdint.h>
> >  #include <stdio.h>
> >  #include <stdbool.h>
> >+#include <unistd.h>
> >  #include <xen/xen.h>
> >  #include <xen/domctl.h>
> >  #include <xen/physdev.h>
> >
> 
>
diff mbox

Patch

diff --git a/tools/libxc/include/xenctrl.h b/tools/libxc/include/xenctrl.h
index a9e4dc1..fb5c26c 100644
--- a/tools/libxc/include/xenctrl.h
+++ b/tools/libxc/include/xenctrl.h
@@ -31,6 +31,7 @@ 
 #include <stdint.h>
 #include <stdio.h>
 #include <stdbool.h>
+#include <unistd.h>
 #include <xen/xen.h>
 #include <xen/domctl.h>
 #include <xen/physdev.h>