From patchwork Fri Apr 1 12:40:13 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paulina Szubarczyk X-Patchwork-Id: 8723561 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 56043C0553 for ; Fri, 1 Apr 2016 12:43:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AD8B4203DB for ; Fri, 1 Apr 2016 12:43:47 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C487D20374 for ; Fri, 1 Apr 2016 12:43:46 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1alyOK-0001Nu-0m; Fri, 01 Apr 2016 12:41:32 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1alyOI-0001Lq-K6 for xen-devel@lists.xenproject.org; Fri, 01 Apr 2016 12:41:30 +0000 Received: from [85.158.137.68] by server-7.bemta-3.messagelabs.com id 1F/89-04060-97C6EF65; Fri, 01 Apr 2016 12:41:29 +0000 X-Env-Sender: paulinaszubarczyk@gmail.com X-Msg-Ref: server-8.tower-31.messagelabs.com!1459514489!32642848!1 X-Originating-IP: [209.85.215.51] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG X-StarScan-Received: X-StarScan-Version: 8.11; banners=-,-,- X-VirusChecked: Checked Received: (qmail 13961 invoked from network); 1 Apr 2016 12:41:29 -0000 Received: from mail-lf0-f51.google.com (HELO mail-lf0-f51.google.com) (209.85.215.51) by server-8.tower-31.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 1 Apr 2016 12:41:29 -0000 Received: by mail-lf0-f51.google.com with SMTP id p188so53649522lfd.0 for ; Fri, 01 Apr 2016 05:41:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vYkqcJGIWuhjlR+6vUAfUFON7/ubrlr8Z4X9KbjP6Ek=; b=gu2IM5fDB3v8HoxvPpYKuAG0F5enrTli0B5Hv0i9lIU2UDfFzkILIoBm3HHCMkwQDF 7ie/weOw/uiVzU0tSSgLcvoHrvunuvVghDORkgxGbvrZ5cJWQXzQGsIIYjYEKmO+7CHr vEQ/BHWKZmutHLsR0vdctRa4qLPxoOGura6N3Bp5W6Ivi6oy6QfZLcq6J3JJGetkFHd6 ZGfR3mGjHLEU1RWJB/m9f/d+woFQYxCkRufOhxu3lLpXeqG5y1mlMWeo5pAr/wm+sRyV cfxrRXOhf8T/CZCUwW4CJuRY9okvK0nnqaneI8Oqql7usN/hvei0QQrEOwF38XoUiZtd YipA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vYkqcJGIWuhjlR+6vUAfUFON7/ubrlr8Z4X9KbjP6Ek=; b=hcr9HwuzH5nAsE8EFSpri8z2/wpBl6vvF4sdN1WRC9F54ZR0O07V4hgexpLJsLNXuF GPvP2HmAZaxRO1vJUP4omVOaVk/nEGQqeNpVRoGufCvDGejPBdt1lpq43dU5fahYllNU +yWXUN0tmmO7/A7qyqWtjw9wTCQAcFQupE8m7YORNFTYhXl6YS0H2M4TGQndL01rd35y sSw3WDfaAcjt9WmzHQaRz5xWRla4AJJyA4tSUimchB+QJN1+gwKzl4YodwjpnNmDViqB ucBej1OjD+Cb6qOVMMGAEansYikiul3k4I4Dd8FKSc8k1h4ETj4+N5kmaSZIlenAthV2 xF/w== X-Gm-Message-State: AD7BkJKBAjVs3L6FzvQ6gzJQ0Cns4P1OtP8k73jEkoqb2D/t4rGuZprA+i+MdOYajnap3A== X-Received: by 10.25.16.103 with SMTP id f100mr1556082lfi.90.1459514488843; Fri, 01 Apr 2016 05:41:28 -0700 (PDT) Received: from localhost.localdomain (84-10-74-207.static.chello.pl. [84.10.74.207]) by smtp.gmail.com with ESMTPSA id do4sm2134801lbc.35.2016.04.01.05.41.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 01 Apr 2016 05:41:27 -0700 (PDT) From: Paulina Szubarczyk To: xen-devel@lists.xenproject.org, roger.pau@citrix.com, George.Dunlap@eu.citrix.com Date: Fri, 1 Apr 2016 14:40:13 +0200 Message-Id: <1459514413-18682-11-git-send-email-paulinaszubarczyk@gmail.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1459514413-18682-1-git-send-email-paulinaszubarczyk@gmail.com> References: <1459514413-18682-1-git-send-email-paulinaszubarczyk@gmail.com> Cc: Paulina Szubarczyk , dario.faggioli@citrix.com, wei.liu2@citrix.com, ian.campbell@citrix.com Subject: [Xen-devel] [PATCH 10/10] libxl: libxl_tmem functions improving coding style X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP In accordance with CODING_SYTLE: - Use 'r' for return values to functions whose return values are a different error space (like xc_tmem_control, xc_tmem_auth) Signed-off-by: Paulina Szubarczyk Reviewed-by: Konrad Rzeszutek Wilk --- tools/libxl/libxl.c | 58 ++++++++++++++++++++++++++--------------------------- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/tools/libxl/libxl.c b/tools/libxl/libxl.c index 6bb2f82..5794ade 100644 --- a/tools/libxl/libxl.c +++ b/tools/libxl/libxl.c @@ -6107,14 +6107,14 @@ uint32_t libxl_vm_get_start_time(libxl_ctx *ctx, uint32_t domid) char *libxl_tmem_list(libxl_ctx *ctx, uint32_t domid, int use_long) { - int rc; + int r; char _buf[32768]; GC_INIT(ctx); - rc = xc_tmem_control(ctx->xch, -1, XEN_SYSCTL_TMEM_OP_LIST, domid, 32768, use_long, + r = xc_tmem_control(ctx->xch, -1, XEN_SYSCTL_TMEM_OP_LIST, domid, 32768, use_long, _buf); - if (rc < 0) { - LOGEV(ERROR, rc, "Can not get tmem list"); + if (r < 0) { + LOGEV(ERROR, r, "Can not get tmem list"); GC_FREE; return NULL; } @@ -6125,36 +6125,36 @@ char *libxl_tmem_list(libxl_ctx *ctx, uint32_t domid, int use_long) int libxl_tmem_freeze(libxl_ctx *ctx, uint32_t domid) { - int rc; + int r; GC_INIT(ctx); - rc = xc_tmem_control(ctx->xch, -1, XEN_SYSCTL_TMEM_OP_FREEZE, domid, 0, 0, + r = xc_tmem_control(ctx->xch, -1, XEN_SYSCTL_TMEM_OP_FREEZE, domid, 0, 0, NULL); - if (rc < 0) { - LOGEV(ERROR, rc, "Can not freeze tmem pools"); + if (r < 0) { + LOGEV(ERROR, r, "Can not freeze tmem pools"); GC_FREE; return ERROR_FAIL; } GC_FREE; - return rc; + return r; } int libxl_tmem_thaw(libxl_ctx *ctx, uint32_t domid) { - int rc; + int r; GC_INIT(ctx); - rc = xc_tmem_control(ctx->xch, -1, XEN_SYSCTL_TMEM_OP_THAW, domid, 0, 0, + r = xc_tmem_control(ctx->xch, -1, XEN_SYSCTL_TMEM_OP_THAW, domid, 0, 0, NULL); - if (rc < 0) { - LOGEV(ERROR, rc, "Can not thaw tmem pools"); + if (r < 0) { + LOGEV(ERROR, r, "Can not thaw tmem pools"); GC_FREE; return ERROR_FAIL; } GC_FREE; - return rc; + return r; } static int32_t tmem_setop_from_string(char *set_name) @@ -6171,7 +6171,7 @@ static int32_t tmem_setop_from_string(char *set_name) int libxl_tmem_set(libxl_ctx *ctx, uint32_t domid, char* name, uint32_t set) { - int rc; + int r; int32_t subop = tmem_setop_from_string(name); GC_INIT(ctx); @@ -6180,48 +6180,48 @@ int libxl_tmem_set(libxl_ctx *ctx, uint32_t domid, char* name, uint32_t set) GC_FREE; return ERROR_INVAL; } - rc = xc_tmem_control(ctx->xch, -1, subop, domid, set, 0, NULL); - if (rc < 0) { - LOGEV(ERROR, rc, "Can not set tmem %s", name); + r = xc_tmem_control(ctx->xch, -1, subop, domid, set, 0, NULL); + if (r < 0) { + LOGEV(ERROR, r, "Can not set tmem %s", name); GC_FREE; return ERROR_FAIL; } GC_FREE; - return rc; + return r; } int libxl_tmem_shared_auth(libxl_ctx *ctx, uint32_t domid, char* uuid, int auth) { - int rc; + int r; GC_INIT(ctx); - rc = xc_tmem_auth(ctx->xch, domid, uuid, auth); - if (rc < 0) { - LOGEV(ERROR, rc, "Can not set tmem shared auth"); + r = xc_tmem_auth(ctx->xch, domid, uuid, auth); + if (r < 0) { + LOGEV(ERROR, r, "Can not set tmem shared auth"); GC_FREE; return ERROR_FAIL; } GC_FREE; - return rc; + return r; } int libxl_tmem_freeable(libxl_ctx *ctx) { - int rc; + int r; GC_INIT(ctx); - rc = xc_tmem_control(ctx->xch, -1, XEN_SYSCTL_TMEM_OP_QUERY_FREEABLE_MB, -1, 0, 0, 0); - if (rc < 0) { - LOGEV(ERROR, rc, "Can not get tmem freeable memory"); + r = xc_tmem_control(ctx->xch, -1, XEN_SYSCTL_TMEM_OP_QUERY_FREEABLE_MB, -1, 0, 0, 0); + if (r < 0) { + LOGEV(ERROR, r, "Can not get tmem freeable memory"); GC_FREE; return ERROR_FAIL; } GC_FREE; - return rc; + return r; } int libxl_get_freecpus(libxl_ctx *ctx, libxl_bitmap *cpumap)