diff mbox

[03/10] libxl_pci: Return error code for more pci-* functions

Message ID 1459514413-18682-4-git-send-email-paulinaszubarczyk@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Paulina Szubarczyk April 1, 2016, 12:40 p.m. UTC 
Return rc value instead of allways 0.

Signed-off-by: Paulina Szubarczyk <paulinaszubarczyk@gmail.com>
---
 tools/libxl/libxl_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Roger Pau Monné April 1, 2016, 2:20 p.m. UTC | #1 
On Fri, 1 Apr 2016, Paulina Szubarczyk wrote:
> Return rc value instead of allways 0.
                              ^ extra "l"

The subject on this patch is too vague, please use something more 
descriptive, like:

libxl: fix return value of libxl__device_pci_destroy_all

> Signed-off-by: Paulina Szubarczyk <paulinaszubarczyk@gmail.com>

LGTM, so provided that you fix the subject and commit message:

Acked-by: Roger Pau Monné <roger.pau@citrix.com>
diff mbox

Patch

diff --git a/tools/libxl/libxl_pci.c b/tools/libxl/libxl_pci.c
index 6051ee4..e4a2c2c 100644
--- a/tools/libxl/libxl_pci.c
+++ b/tools/libxl/libxl_pci.c
@@ -1604,7 +1604,7 @@  int libxl__device_pci_destroy_all(libxl__gc *gc, uint32_t domid)
     }
 
     free(pcidevs);
-    return 0;
+    return rc;
 }
 
 int libxl__grant_vga_iomem_permission(libxl__gc *gc, const uint32_t domid,