From patchwork Mon Apr 4 15:09:59 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Jackson X-Patchwork-Id: 8741631 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 1B6919F36E for ; Mon, 4 Apr 2016 15:12:20 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3E283201FA for ; Mon, 4 Apr 2016 15:12:19 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 66C07201F2 for ; Mon, 4 Apr 2016 15:12:18 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1an68u-00076z-40; Mon, 04 Apr 2016 15:10:16 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1an68s-00076m-2Z for xen-devel@lists.xensource.com; Mon, 04 Apr 2016 15:10:14 +0000 Received: from [193.109.254.147] by server-13.bemta-14.messagelabs.com id 3B/7D-02874-5D382075; Mon, 04 Apr 2016 15:10:13 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpikeJIrShJLcpLzFFi42JxWrrBXvdSM1O 4wcHrFhb3prxnd2D02N63iz2AMYo1My8pvyKBNePDp2amgtNsFU0LjrE0MM5n7WLk5JAQ8Jc4 svYyC4jNJqAr0bTlLxuILSKgLHG86QtYDbPAHUaJZy/9QGxhAQ+JI1dmMYLYLAIqEtOfnGTqY uTg4BXwlDhy0x5ipKJE97MJbCBhIQE1ibnr40HCvAKCEidnPmGBmCghcfDFC2aQEgkBbom/3f YTGHlmIamahaRqASPTKkaN4tSistQiXUMLvaSizPSMktzEzBxdQ0MTvdzU4uLE9NScxKRiveT 83E2MwPCoZ2Bg3MF4ZLvnIUZJDiYlUV73KqZwIb6k/JTKjMTijPii0pzU4kOMMhwcShK8l5uA coJFqempFWmZOcBAhUlLcPAoifDuAEnzFhck5hZnpkOkTjHqciz4cXstkxBLXn5eqpQ4byVIk QBIUUZpHtwIWNRcYpSVEuZlZGBgEOIpSC3KzSxBlX/FKM7BqCTMexRkCk9mXgncpldARzABHV EvDHZESSJCSqqB0ZZr6WzTyX+eyGSe/dj4cPbaXb5T119xzeA4uU9A5cTjL8r2Uy0kJXbutK5 kPzw9JmFPrJrdRnn3J1582sv+aR/uC35Qo77+9k6HSyyHol6tLLykfqBV5Uzw/ukZMT/Yf61m uL0qKoHnWXeiSNL329Xq9w42/c5qXjutiMnWbcnry7mVO9LL7iixFGckGmoxFxUnAgD5E6lml QIAAA== X-Env-Sender: prvs=895d09049=Ian.Jackson@citrix.com X-Msg-Ref: server-6.tower-27.messagelabs.com!1459782609!35563106!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 8.28; banners=-,-,- X-VirusChecked: Checked Received: (qmail 43684 invoked from network); 4 Apr 2016 15:10:10 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-6.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 4 Apr 2016 15:10:10 -0000 X-IronPort-AV: E=Sophos;i="5.24,441,1454976000"; d="scan'208";a="351305839" From: Ian Jackson To: Date: Mon, 4 Apr 2016 16:09:59 +0100 Message-ID: <1459782600-16073-1-git-send-email-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 1.7.10.4 MIME-Version: 1.0 X-DLP: MIA1 Cc: Simon Cao , Ian Jackson , George Dunlap , coverity@xenproject.org, Chunyan Liu Subject: [Xen-devel] [PATCH 1/2] libxl: Set rc on failure of usbdev_busaddr_to_busid X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We must set rc before using `goto out'. Bug introduced in bf7628f0 "libxl: add pvusb API". CID: 1358113 Signed-off-by: Ian Jackson CC: coverity@xenproject.org CC: Simon Cao CC: George Dunlap CC: Chunyan Liu --- tools/libxl/libxl_pvusb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/libxl/libxl_pvusb.c b/tools/libxl/libxl_pvusb.c index 5f92628..6f53317 100644 --- a/tools/libxl/libxl_pvusb.c +++ b/tools/libxl/libxl_pvusb.c @@ -905,6 +905,7 @@ static int libxl__device_usbdev_add_xenstore(libxl__gc *gc, uint32_t domid, usbdev->u.hostdev.hostaddr); if (!busid) { LOG(DEBUG, "Fail to get busid of usb device"); + rc = ERROR_FAIL; goto out; }