From patchwork Wed Apr 6 20:30:38 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chong Li X-Patchwork-Id: 8765241 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 926459F372 for ; Wed, 6 Apr 2016 20:34:08 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AB72A201FE for ; Wed, 6 Apr 2016 20:34:06 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CAE92201EC for ; Wed, 6 Apr 2016 20:34:05 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anu6G-0006Xk-BZ; Wed, 06 Apr 2016 20:30:52 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1anu6E-0006Xd-9C for xen-devel@lists.xen.org; Wed, 06 Apr 2016 20:30:50 +0000 Received: from [85.158.139.211] by server-7.bemta-5.messagelabs.com id 58/80-22167-9F175075; Wed, 06 Apr 2016 20:30:49 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjkeJIrShJLcpLzFFi42K5GHr1oO6PQtZ wg+0/jCyWfFzM4sDocXT3b6YAxijWzLyk/IoE1oz713cyFuzgqpi2q5m5gXEmRxcjF4eQwERG ick9nxlBHBaBSywSR+ecZwdxJATesUgsf/aVqYuRA8iJkTh/QqCLkRPIrJCY0rSVHcQWElCWO HV3FzvEpIVMEh0T2xhBEmwCqhJXd71jAbFFBKQlrn2+DLaBWeARo8TGfXtYQRLCAnES97bcBC tiAWpYfbsXLM4r4Cxx8tdyVohtchInj01mncDIt4CRYRWjenFqUVlqka6JXlJRZnpGSW5iZo6 uoYGpXm5qcXFiempOYlKxXnJ+7iZGYKgwAMEOxlt9zocYJTmYlER59bJZw4X4kvJTKjMSizPi i0pzUosPMcpwcChJ8HIBQ09IsCg1PbUiLTMHGLQwaQkOHiURXjOQNG9xQWJucWY6ROoUozHHl t/X1jJxbJt6by2TEEtefl6qlDivMEipAEhpRmke3CBYNF1ilJUS5mUEOk2IpyC1KDezBFX+Fa M4B6OSMK8kyBSezLwSuH2vgE5hAjqlXpgJ5JSSRISUVANjL8c2sztnVmWy1c39XKRptvntnxm tNkHP1uyMaZxZdOVuZcuy2zeu9v7rX7rV9ac0U4r719P7VPRfNq3OLtB/W/ur2kHsr+mHvTe/ CVxf82/bD72f0TX+exZ93fk9cvm0MOGagENrblt2vmX5dvlbvrxL1qTQq8zpXHHLp2yvynUOE bt4wqTojRJLcUaioRZzUXEiAGaedNyhAgAA X-Env-Sender: lichong659@gmail.com X-Msg-Ref: server-3.tower-206.messagelabs.com!1459974647!33368851!1 X-Originating-IP: [209.85.213.193] X-SpamReason: No, hits=0.3 required=7.0 tests=MAILTO_TO_SPAM_ADDR X-StarScan-Received: X-StarScan-Version: 8.28; banners=-,-,- X-VirusChecked: Checked Received: (qmail 44377 invoked from network); 6 Apr 2016 20:30:48 -0000 Received: from mail-ig0-f193.google.com (HELO mail-ig0-f193.google.com) (209.85.213.193) by server-3.tower-206.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 6 Apr 2016 20:30:48 -0000 Received: by mail-ig0-f193.google.com with SMTP id nt3so9157494igb.0 for ; Wed, 06 Apr 2016 13:30:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=CI2hcK0NMwPvOFUMQrDrIdKhsvaElteHEB5+z87cSFU=; b=Znn1OBKjhizpWMun0Jd152IkTIGokL69jJ4JfRH2lTEVDIKU0W+NxkmLSib9L4W7wj /2d2ofsppP/Bvck8iLKni3br8Jp36772FzUffr8l4mzMYns5/YhIF/yf+zDX0pUqUFXx PRFhoespDmuPp9BG7bvA+6UYaXG0BzAHlXJ5tCw23DadzxDBMtQgc23RfWSKA31b4cvI 5ZN1ag8Hpi37fDpLhoZ87/fdWmltTJQ4ltzIb5fpjgVBAcMjsjuSKK3h23IsBJtyudAC V77OVHipTf5q0MoMI92z52efFxHi93qOigA5Go6PK1ExtiFfwRxAPeISVI7+dD6VWgUA Pkeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=CI2hcK0NMwPvOFUMQrDrIdKhsvaElteHEB5+z87cSFU=; b=K90q17FjsZj9uXb4WlR2kXk7rX1GFBS6jaFQetABWWTo6BcyDK+t9nF4tJVB0SlAKN zXR7eGfYF5fQpfhjL21S+zjxPWiWYaI3srjohuRKR9HA+KhEs+32c9+G5N1C4nMCwx9J 9P28nnT5Dtwe2M97SXf4YHFlRHty7cqnHEmxNBtiHRED1ic17HQPOYENZzpFy5IZxQzt 4gSpN5gOHHRccglz3msJzZFk5SGTJa0MfVnMgPU2xXSEbWtxxgHk0M6WnvlDy6+e14Vc 0BhbW6PoQJi3TIEWupxsM31b7eiKR5F7MW43bUewanMC3+FReFsf24hWIJgrsat6NZBd OO0Q== X-Gm-Message-State: AD7BkJKFXtWa8WUVR4niRFEDMG/wG9j0zO18eL4WE0zXVUFCTTPzEOnNcxee0mJ0calNZw== X-Received: by 10.50.79.198 with SMTP id l6mr22822476igx.30.1459974647584; Wed, 06 Apr 2016 13:30:47 -0700 (PDT) Received: from chong-OptiPlex-960.seas.wustl.edu (admin998.cec.wustl.edu. [128.252.20.193]) by smtp.googlemail.com with ESMTPSA id x3sm2148275igl.11.2016.04.06.13.30.45 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 06 Apr 2016 13:30:46 -0700 (PDT) From: Chong Li To: xen-devel@lists.xen.org Date: Wed, 6 Apr 2016 15:30:38 -0500 Message-Id: <1459974638-7102-1-git-send-email-lichong659@gmail.com> X-Mailer: git-send-email 1.9.1 Cc: Chong Li , wei.liu2@citrix.com, george.dunlap@eu.citrix.com, dario.faggioli@citrix.com, ian.jackson@eu.citrix.com, mengxu@cis.upenn.edu, lichong659@gmail.com, dgolomb@seas.upenn.edu Subject: [Xen-devel] [PATCH v1] libxc: fix uninitialized variable when changing rtds scheduling parameters X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit 046c2b503a89d21b41e4d555a9f75d02af00dbc6 introduces a build failure: in some cases (e.g., num_vcpus <=0), xc_sched_rtds_vcpu_get/set returns an uninitialized variable. Fix it. Signed-off-by: Chong Li Reviewed-by: Andrew Cooper Reviewed-by: Dario Faggioli --- CC: CC: CC: CC: CC: CC: CC: --- tools/libxc/xc_rt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/libxc/xc_rt.c b/tools/libxc/xc_rt.c index 221d17f..77aaa36 100644 --- a/tools/libxc/xc_rt.c +++ b/tools/libxc/xc_rt.c @@ -68,7 +68,7 @@ int xc_sched_rtds_vcpu_set(xc_interface *xch, struct xen_domctl_schedparam_vcpu *vcpus, uint32_t num_vcpus) { - int rc; + int rc = 0; unsigned processed = 0; DECLARE_DOMCTL; DECLARE_HYPERCALL_BOUNCE(vcpus, sizeof(*vcpus) * num_vcpus, @@ -102,7 +102,7 @@ int xc_sched_rtds_vcpu_get(xc_interface *xch, struct xen_domctl_schedparam_vcpu *vcpus, uint32_t num_vcpus) { - int rc; + int rc = 0; unsigned processed = 0; DECLARE_DOMCTL; DECLARE_HYPERCALL_BOUNCE(vcpus, sizeof(*vcpus) * num_vcpus,