| Message ID | 1460026796-10899-4-git-send-email-julien.grall@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 2016/4/7 18:59, Julien Grall wrote: > The variable enabled_cpus is used to know the number of CPU enabled in > the MADT. > > Currently this variable is used to check the validity of the boot CPU. > It will be considered invalid when "enabled_cpus > 1". > > However, this condition also means that multiple CPUs are present on the > system. So secondary will never be brought up. > > The correct way to check the validity of the boot CPU is to use the > variable bootcpu_valid. > > Signed-off-by: Julien Grall <julien.grall@arm.com> Reviewed-by: Shannon Zhao <shannon.zhao@linaro.org> > --- > xen/arch/arm/acpi/boot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/arm/acpi/boot.c b/xen/arch/arm/acpi/boot.c > index 2a71660..fd29bdc 100644 > --- a/xen/arch/arm/acpi/boot.c > +++ b/xen/arch/arm/acpi/boot.c > @@ -149,7 +149,7 @@ void __init acpi_smp_init_cpus(void) > return; > } > > - if ( enabled_cpus > 1 ) > + if ( !bootcpu_valid ) > { > printk("MADT missing boot CPU MPIDR, not enabling secondaries\n"); > return; >
On Thu, 7 Apr 2016, Julien Grall wrote: > The variable enabled_cpus is used to know the number of CPU enabled in > the MADT. > > Currently this variable is used to check the validity of the boot CPU. > It will be considered invalid when "enabled_cpus > 1". > > However, this condition also means that multiple CPUs are present on the > system. So secondary will never be brought up. > > The correct way to check the validity of the boot CPU is to use the > variable bootcpu_valid. > > Signed-off-by: Julien Grall <julien.grall@arm.com> Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > xen/arch/arm/acpi/boot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/xen/arch/arm/acpi/boot.c b/xen/arch/arm/acpi/boot.c > index 2a71660..fd29bdc 100644 > --- a/xen/arch/arm/acpi/boot.c > +++ b/xen/arch/arm/acpi/boot.c > @@ -149,7 +149,7 @@ void __init acpi_smp_init_cpus(void) > return; > } > > - if ( enabled_cpus > 1 ) > + if ( !bootcpu_valid ) > { > printk("MADT missing boot CPU MPIDR, not enabling secondaries\n"); > return; > -- > 1.9.1 >
diff --git a/xen/arch/arm/acpi/boot.c b/xen/arch/arm/acpi/boot.c index 2a71660..fd29bdc 100644 --- a/xen/arch/arm/acpi/boot.c +++ b/xen/arch/arm/acpi/boot.c @@ -149,7 +149,7 @@ void __init acpi_smp_init_cpus(void) return; } - if ( enabled_cpus > 1 ) + if ( !bootcpu_valid ) { printk("MADT missing boot CPU MPIDR, not enabling secondaries\n"); return;
The variable enabled_cpus is used to know the number of CPU enabled in the MADT. Currently this variable is used to check the validity of the boot CPU. It will be considered invalid when "enabled_cpus > 1". However, this condition also means that multiple CPUs are present on the system. So secondary will never be brought up. The correct way to check the validity of the boot CPU is to use the variable bootcpu_valid. Signed-off-by: Julien Grall <julien.grall@arm.com> --- xen/arch/arm/acpi/boot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)