| Message ID | 1460028049-29606-1-git-send-email-cyliu@suse.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Chunyan Liu writes ("[PATCH] bind_usbintf: do not reuse 'path'"):
> To avoid confusion, add a new variable "intf_path" to indicate
> driver/interface path, let "path" indicate driver/bind path only.
I think it would be better to rename both variables, as I suggested in
my mail yesterday. That makes it much more obvious that each place
where `path' was used has been checked and the reference to the
proper variable substituted.
Thanks,
Ian.
>>> On 4/8/2016 at 12:52 AM, in message <22278.36941.470901.631613@mariner.uk.xensource.com>, Ian Jackson <Ian.Jackson@eu.citrix.com> wrote: > Chunyan Liu writes ("[PATCH] bind_usbintf: do not reuse 'path'"): > > To avoid confusion, add a new variable "intf_path" to indicate > > driver/interface path, let "path" indicate driver/bind path only. > > I think it would be better to rename both variables, as I suggested in > my mail yesterday. That makes it much more obvious that each place > where `path' was used has been checked and the reference to the > proper variable substituted. Updated. Sent V2. > > Thanks, > Ian. > >
diff --git a/tools/libxl/libxl_pvusb.c b/tools/libxl/libxl_pvusb.c index 6447639..8cf3ddc 100644 --- a/tools/libxl/libxl_pvusb.c +++ b/tools/libxl/libxl_pvusb.c @@ -1035,18 +1035,18 @@ out: static int bind_usbintf(libxl__gc *gc, const char *intf, const char *drvpath) { - char *path; + char *path, *intf_path; struct stat st; int fd = -1; int rc, r; - path = GCSPRINTF("%s/%s", drvpath, intf); + intf_path = GCSPRINTF("%s/%s", drvpath, intf); /* check through lstat, if intf already exists under drvpath, * it's already bound, return directly; if it doesn't exist, * continue to do bind work; otherwise, return error. */ - r = lstat(path, &st); + r = lstat(intf_path, &st); if (r == 0) return 0; if (r < 0 && errno != ENOENT)
To avoid confusion, add a new variable "intf_path" to indicate driver/interface path, let "path" indicate driver/bind path only. CID: 1358111 Signed-off-by: Chunyan Liu <cyliu@suse.com> CC: Simon Cao <caobosimon@gmail.com> CC: George Dunlap <george.dunlap@citrix.com> CC: Ian Jackson <Ian.Jackson@eu.citrix.com> --- tools/libxl/libxl_pvusb.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)