| Message ID | 1460380083-14534-1-git-send-email-wei.liu2@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 11/04/16 15:08, Wei Liu wrote: > Both be_domid and fe_domid are unsigned. > > Reported-by: Olaf Hering <olaf@aepfle.de> > Signed-off-by: Wei Liu <wei.liu2@citrix.com> Reviewed-by: Juergen Gross <jgross@suse.com> > --- > Cc: Ian Jackson <ian.jackson@eu.citrix.com> > Cc: Juergen Gross <jgross@suse.com> > Cc: Chunyan Liu <cyliu@suse.com> > --- > tools/libxl/libxl_pvusb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/libxl/libxl_pvusb.c b/tools/libxl/libxl_pvusb.c > index c66733b..9f1e842 100644 > --- a/tools/libxl/libxl_pvusb.c > +++ b/tools/libxl/libxl_pvusb.c > @@ -350,7 +350,7 @@ static const char *vusb_be_from_xs_fe(libxl__gc *gc, const char *fe_path, > > /* Check to see that it has the proper form, and that fe_domid == > * target domid */ > - r = sscanf(be_path, "/local/domain/%d/backend/%15[^/]/%d", > + r = sscanf(be_path, "/local/domain/%u/backend/%15[^/]/%u", > &be_domid, be_type, &fe_domid); > > if (r != 3 || fe_domid != tgt_domid) { >
Juergen Gross writes ("Re: [PATCH for-4.7] libxl: pvusb: use %u to convert unsigned number"):
> On 11/04/16 15:08, Wei Liu wrote:
> > Both be_domid and fe_domid are unsigned.
> >
> > Reported-by: Olaf Hering <olaf@aepfle.de>
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
>
> Reviewed-by: Juergen Gross <jgross@suse.com>
This patch doesn't have a formal release ack. I am confused.
Wei, if you send a patch "for 4.7", should I take you to have
implicitly acked it yourself, or what ?
Thanks,
Ian.
On Fri, Apr 22, 2016 at 03:44:09PM +0100, Ian Jackson wrote: > Juergen Gross writes ("Re: [PATCH for-4.7] libxl: pvusb: use %u to convert unsigned number"): > > On 11/04/16 15:08, Wei Liu wrote: > > > Both be_domid and fe_domid are unsigned. > > > > > > Reported-by: Olaf Hering <olaf@aepfle.de> > > > Signed-off-by: Wei Liu <wei.liu2@citrix.com> > > > > Reviewed-by: Juergen Gross <jgross@suse.com> > > This patch doesn't have a formal release ack. I am confused. > > Wei, if you send a patch "for 4.7", should I take you to have > implicitly acked it yourself, or what ? > My bad. This fell through the crack. Release-acked-by: Wei Liu <wei.liu2@citrix.com> Generally speaking even if I myself send a patch I would still want to explicitly release ack it because I might not want the patch to go straight in. Wei. > Thanks, > Ian.
Wei Liu writes ("Re: [PATCH for-4.7] libxl: pvusb: use %u to convert unsigned number"):
> On Fri, Apr 22, 2016 at 03:44:09PM +0100, Ian Jackson wrote:
> > Juergen Gross writes ("Re: [PATCH for-4.7] libxl: pvusb: use %u to convert unsigned number"):
> > > On 11/04/16 15:08, Wei Liu wrote:
> > > > Both be_domid and fe_domid are unsigned.
> > > >
> > > > Reported-by: Olaf Hering <olaf@aepfle.de>
> > > > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > >
> > > Reviewed-by: Juergen Gross <jgross@suse.com>
> >
> > This patch doesn't have a formal release ack. I am confused.
> >
> > Wei, if you send a patch "for 4.7", should I take you to have
> > implicitly acked it yourself, or what ?
> >
>
> My bad. This fell through the crack.
>
> Release-acked-by: Wei Liu <wei.liu2@citrix.com>
Queued, thanks.
> Generally speaking even if I myself send a patch I would still want to
> explicitly release ack it because I might not want the patch to go
> straight in.
Right, OK.
Thanks,
Ian.
diff --git a/tools/libxl/libxl_pvusb.c b/tools/libxl/libxl_pvusb.c index c66733b..9f1e842 100644 --- a/tools/libxl/libxl_pvusb.c +++ b/tools/libxl/libxl_pvusb.c @@ -350,7 +350,7 @@ static const char *vusb_be_from_xs_fe(libxl__gc *gc, const char *fe_path, /* Check to see that it has the proper form, and that fe_domid == * target domid */ - r = sscanf(be_path, "/local/domain/%d/backend/%15[^/]/%d", + r = sscanf(be_path, "/local/domain/%u/backend/%15[^/]/%u", &be_domid, be_type, &fe_domid); if (r != 3 || fe_domid != tgt_domid) {
Both be_domid and fe_domid are unsigned. Reported-by: Olaf Hering <olaf@aepfle.de> Signed-off-by: Wei Liu <wei.liu2@citrix.com> --- Cc: Ian Jackson <ian.jackson@eu.citrix.com> Cc: Juergen Gross <jgross@suse.com> Cc: Chunyan Liu <cyliu@suse.com> --- tools/libxl/libxl_pvusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)