diff mbox

[OSSTEST] ts-xen-build-prep: Install Ocaml

Message ID 1461338802-29779-1-git-send-email-ian.jackson@eu.citrix.com (mailing list archive)
State New, archived
Headers show

Commit Message

Ian Jackson April 22, 2016, 3:26 p.m. UTC
This will result in the Xen build system building, and then
preferring, oxenstored.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
CC: David Scott <dave@recoil.org>
CC: Wei Liu <wei.liu2@citrix.com>
---
 ts-xen-build-prep |    1 +
 1 file changed, 1 insertion(+)

Comments

Andrew Cooper April 22, 2016, 4:23 p.m. UTC | #1
On 22/04/16 16:26, Ian Jackson wrote:
> This will result in the Xen build system building, and then
> preferring, oxenstored.
>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: David Scott <dave@recoil.org>
> CC: Wei Liu <wei.liu2@citrix.com>

Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>

This matches my notes for developing the ocaml bits of xen.git outside
of the XenServer build system.

> ---
>  ts-xen-build-prep |    1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/ts-xen-build-prep b/ts-xen-build-prep
> index b35e91b..c8cebf4 100755
> --- a/ts-xen-build-prep
> +++ b/ts-xen-build-prep
> @@ -206,6 +206,7 @@ sub prep () {
>                        autoconf automake libtool xsltproc
>                        libxml2-utils libxml2-dev
>                        libdevmapper-dev w3c-dtd-xhtml libxml-xpath-perl
> +                      ocaml-nox ocaml-findlib
>                        ccache nasm checkpolicy ebtables);
>  
>      if ($ho->{Suite} =~ m/wheezy|squeeze|lenny/) {
Wei Liu April 22, 2016, 5:44 p.m. UTC | #2
On Fri, Apr 22, 2016 at 04:26:42PM +0100, Ian Jackson wrote:
> This will result in the Xen build system building, and then
> preferring, oxenstored.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: David Scott <dave@recoil.org>
> CC: Wei Liu <wei.liu2@citrix.com>

Reviewed-by: Wei Liu <wei.liu2@citrix.com>

> ---
>  ts-xen-build-prep |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/ts-xen-build-prep b/ts-xen-build-prep
> index b35e91b..c8cebf4 100755
> --- a/ts-xen-build-prep
> +++ b/ts-xen-build-prep
> @@ -206,6 +206,7 @@ sub prep () {
>                        autoconf automake libtool xsltproc
>                        libxml2-utils libxml2-dev
>                        libdevmapper-dev w3c-dtd-xhtml libxml-xpath-perl
> +                      ocaml-nox ocaml-findlib
>                        ccache nasm checkpolicy ebtables);
>  
>      if ($ho->{Suite} =~ m/wheezy|squeeze|lenny/) {
> -- 
> 1.7.10.4
>
David Scott April 22, 2016, 7:54 p.m. UTC | #3
> On 22 Apr 2016, at 16:26, Ian Jackson <ian.jackson@eu.citrix.com> wrote:
> 
> This will result in the Xen build system building, and then
> preferring, oxenstored.
> 
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: David Scott <dave@recoil.org>
> CC: Wei Liu <wei.liu2@citrix.com>


This looks good to me too.

Reviewed-by: David Scott <dave@recoil.org>



> ---
> ts-xen-build-prep |    1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/ts-xen-build-prep b/ts-xen-build-prep
> index b35e91b..c8cebf4 100755
> --- a/ts-xen-build-prep
> +++ b/ts-xen-build-prep
> @@ -206,6 +206,7 @@ sub prep () {
>                       autoconf automake libtool xsltproc
>                       libxml2-utils libxml2-dev
>                       libdevmapper-dev w3c-dtd-xhtml libxml-xpath-perl
> +                      ocaml-nox ocaml-findlib
>                       ccache nasm checkpolicy ebtables);
> 
>     if ($ho->{Suite} =~ m/wheezy|squeeze|lenny/) {
> -- 
> 1.7.10.4
>
diff mbox

Patch

diff --git a/ts-xen-build-prep b/ts-xen-build-prep
index b35e91b..c8cebf4 100755
--- a/ts-xen-build-prep
+++ b/ts-xen-build-prep
@@ -206,6 +206,7 @@  sub prep () {
                       autoconf automake libtool xsltproc
                       libxml2-utils libxml2-dev
                       libdevmapper-dev w3c-dtd-xhtml libxml-xpath-perl
+                      ocaml-nox ocaml-findlib
                       ccache nasm checkpolicy ebtables);
 
     if ($ho->{Suite} =~ m/wheezy|squeeze|lenny/) {