From patchwork Wed Apr 27 11:11:54 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Roger_Pau_Monn=C3=A9?= X-Patchwork-Id: 8955071 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id D18E39F1C1 for ; Wed, 27 Apr 2016 11:14:41 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id CE17E2022A for ; Wed, 27 Apr 2016 11:14:36 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F1C3C200F0 for ; Wed, 27 Apr 2016 11:14:35 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avNOU-0003WO-JA; Wed, 27 Apr 2016 11:12:34 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1avNOT-0003VM-MZ for xen-devel@lists.xenproject.org; Wed, 27 Apr 2016 11:12:33 +0000 Received: from [193.109.254.147] by server-10.bemta-14.messagelabs.com id 2F/71-02972-0AE90275; Wed, 27 Apr 2016 11:12:32 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrGIsWRWlGSWpSXmKPExsXitHRDpO6CeQr hBo+eK1p83zKZyYHR4/CHKywBjFGsmXlJ+RUJrBkbfpYWzOeseHPvAVMD4zf2LkZODgkBf4lX e38ygdhsAjoSF+fuZOti5OAQEVCRuL3XACTMLFAs8XVVHyuILSzgIvFrwWU2EJtFQFVi7sPPY HFeAVeJvuuPmCBG6kqc3L0JbDwnULytaQILiC0E1Pv09h2oekGJkzOfsEDM15Ro3f6bHcKWl2 jeOpsZol5Ron/eAzaImdwSt09PZZ7AyD8LSfssJO2zkLQvYGRexahenFpUllqka6aXVJSZnlG Sm5iZo2toaKKXm1pcnJiempOYVKyXnJ+7iREYfgxAsIPx7wTnQ4ySHExKorwL2xXChfiS8lMq MxKLM+KLSnNSiw8xynBwKEnwhs8FygkWpaanVqRl5gAjASYtwcGjJMJbPwcozVtckJhbnJkOk TrFqCglzpsI0icAksgozYNrg0XfJUZZKWFeRqBDhHgKUotyM0tQ5V8xinMwKgnzHgCZwpOZVw I3/RXQYiagxZcPyYIsLklESEk1MCbZnr/Wni6zf2HJodcPJS7d0V1eqrP7zepQ3X/y+14qcU4 SdF/r5Z7xav3PjNojxh2XZuzecVrqu3Chx+v7315MKo/5FBz/YtnW1U1eV515PGKfWwbUTb3y vKW+Zzbb/naGZZnP92x8//fTpb9zjmUEG7CZH2j8d1H3yYPEfeE5k9kD2Ve3l5sosRRnJBpqM RcVJwIAvCytorkCAAA= X-Env-Sender: prvs=918322aae=roger.pau@citrix.com X-Msg-Ref: server-2.tower-27.messagelabs.com!1461755550!36130066!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 8.34; banners=-,-,- X-VirusChecked: Checked Received: (qmail 65220 invoked from network); 27 Apr 2016 11:12:32 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-2.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 27 Apr 2016 11:12:32 -0000 X-IronPort-AV: E=Sophos;i="5.24,541,1454976000"; d="scan'208";a="350092245" From: Roger Pau Monne To: Date: Wed, 27 Apr 2016 13:11:54 +0200 Message-ID: <1461755514-23754-17-git-send-email-roger.pau@citrix.com> X-Mailer: git-send-email 2.6.4 (Apple Git-63) In-Reply-To: <1461755514-23754-1-git-send-email-roger.pau@citrix.com> References: <1461755514-23754-1-git-send-email-roger.pau@citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: Wei Liu , Ian Jackson , Roger Pau Monne Subject: [Xen-devel] [PATCH v3 for-4.7 16/16] tools/pygrub: fix usage of LDFLAGS X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP LDFLAGS cannot be appended to CFLAGS, instead pass them down as env variables. Signed-off-by: Roger Pau Monné Acked-by: Wei Liu --- Cc: Ian Jackson Cc: Wei Liu --- tools/pygrub/Makefile | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/pygrub/Makefile b/tools/pygrub/Makefile index fe8e03b..a318490 100644 --- a/tools/pygrub/Makefile +++ b/tools/pygrub/Makefile @@ -2,7 +2,8 @@ XEN_ROOT = $(CURDIR)/../.. include $(XEN_ROOT)/tools/Rules.mk -PY_CFLAGS = $(CFLAGS) $(PY_NOOPT_CFLAGS) $(APPEND_LDFLAGS) +PY_CFLAGS = $(CFLAGS) $(PY_NOOPT_CFLAGS) +PY_LDFLAGS = $(LDFLAGS) $(APPEND_LDFLAGS) .PHONY: all all: build @@ -12,8 +13,8 @@ build: .PHONY: install install: all - CC="$(CC)" CFLAGS="$(PY_CFLAGS)" $(PYTHON) setup.py install \ - $(PYTHON_PREFIX_ARG) --root="$(DESTDIR)" \ + CC="$(CC)" CFLAGS="$(PY_CFLAGS)" LDFLAGS="$(PY_LDFLAGS)" $(PYTHON) \ + setup.py install $(PYTHON_PREFIX_ARG) --root="$(DESTDIR)" \ --install-scripts=$(LIBEXEC_BIN) --force set -e; if [ $(bindir) != $(LIBEXEC_BIN) -a \ "`readlink -f $(DESTDIR)/$(bindir)`" != \