From patchwork Fri Apr 29 15:11:12 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Wei Liu X-Patchwork-Id: 8983831 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 45A479F1D3 for ; Fri, 29 Apr 2016 15:13:29 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 927FE201CD for ; Fri, 29 Apr 2016 15:13:27 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B9704201CE for ; Fri, 29 Apr 2016 15:13:26 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awA4m-0003Be-HR; Fri, 29 Apr 2016 15:11:28 +0000 Received: from mail6.bemta6.messagelabs.com ([85.158.143.247]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awA4l-0003BC-Qs for xen-devel@lists.xenproject.org; Fri, 29 Apr 2016 15:11:27 +0000 Received: from [85.158.143.35] by server-2.bemta-6.messagelabs.com id DF/95-09532-F9973275; Fri, 29 Apr 2016 15:11:27 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrBIsWRWlGSWpSXmKPExsXitHRDpO68SuV wg5crzC2+b5nM5MDocfjDFZYAxijWzLyk/IoE1ow5F2ULXrNXTNr7kLGB8R1bFyMnh4SAv8Sp pYtYQWw2AWWJn529YHERAT2JpgPPGbsYuTiYBXoYJXY03GQBSQgLhEr83fQBzGYRUJU48LaLG cTmFXCWmLb1HDvEUDmJ88d/gsU5BVwkfnydxwhiCwHVbDz4kRWiXlDi5MwnYHOYBTQlWrf/Zo ew5SWat85mhqhXkOiYfowJYia3xO3TU5knMPLPQtI+C0n7LCTtCxiZVzGqF6cWlaUW6RrrJRV lpmeU5CZm5ugaGpjp5aYWFyemp+YkJhXrJefnbmIEhiADEOxg7PjndIhRkoNJSZT3qq5yuBBf Un5KZUZicUZ8UWlOavEhRhkODiUJ3iMVQDnBotT01Iq0zBxgNMCkJTh4lER4RUHSvMUFibnFm ekQqVOMilLivNtAEgIgiYzSPLg2WAReYpSVEuZlBDpEiKcgtSg3swRV/hWjOAejkjDvS5ApPJ l5JXDTXwEtZgJaLLBJEWRxSSJCSqqBUTzvgyxzoFucT60Nq/+GL0u95LIdktMX2Lbv/Nl4Yrd qilN+S2jo/Cb9m90L+EziL0y60vArJ/4u1z21POVXsv/P3Iit93R+WHm3L2uXUH/ZHd+V+/gE 399MeJlQK3dc/e2aiGkfoi398v7zpGyQY/Tttar8GcGp/fOx1+FPp/lbwxq/ZK5WYinOSDTUY i4qTgQABWWF+rsCAAA= X-Env-Sender: prvs=920e124aa=wei.liu2@citrix.com X-Msg-Ref: server-8.tower-21.messagelabs.com!1461942684!11927639!2 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 8.34; banners=-,-,- X-VirusChecked: Checked Received: (qmail 20864 invoked from network); 29 Apr 2016 15:11:26 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-8.tower-21.messagelabs.com with RC4-SHA encrypted SMTP; 29 Apr 2016 15:11:26 -0000 X-IronPort-AV: E=Sophos;i="5.24,552,1454976000"; d="scan'208";a="350738976" From: Wei Liu To: Xen-devel Date: Fri, 29 Apr 2016 16:11:12 +0100 Message-ID: <1461942677-14564-2-git-send-email-wei.liu2@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1461942677-14564-1-git-send-email-wei.liu2@citrix.com> References: <1461942677-14564-1-git-send-email-wei.liu2@citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: Andrew Cooper , Ian Jackson , Wei Liu , cardoe@cardoe.com Subject: [Xen-devel] [PATCH for-4.7 1/6] rombios/tcgbios: initialise size in tcpa_extend_acpi_log X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Gcc complains: tcgbios.c:362:3: error: ‘size’ may be used uninitialized in this function [-Werror=maybe-uninitialized] memcpy((char *)lasa_last, (char *)entry_ptr, size); It fails to figure out if size is used in memcpy it is always initialised. Signed-off-by: Wei Liu --- tools/firmware/rombios/32bit/tcgbios/tcgbios.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/firmware/rombios/32bit/tcgbios/tcgbios.c b/tools/firmware/rombios/32bit/tcgbios/tcgbios.c index beef5a4..d1d1203 100644 --- a/tools/firmware/rombios/32bit/tcgbios/tcgbios.c +++ b/tools/firmware/rombios/32bit/tcgbios/tcgbios.c @@ -330,7 +330,7 @@ uint32_t tcpa_extend_acpi_log(uint32_t entry_ptr) uint32_t res = 0; unsigned char *lasa_last = tcpa_get_lasa_last_ptr(); unsigned char *lasa_base = tcpa_get_lasa_base_ptr(); - uint32_t size; + uint32_t size = 0; uint16_t entry_count = tcpa_acpi.entry_count; struct pcpes *pcpes = (struct pcpes *)entry_ptr;