From patchwork Mon May 2 04:10:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Douglas Goldstein X-Patchwork-Id: 8989761 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 3DEE7BF440 for ; Mon, 2 May 2016 04:13:41 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4F13120173 for ; Mon, 2 May 2016 04:13:40 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 45DC2201DD for ; Mon, 2 May 2016 04:13:39 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ax5CP-0002FA-1J; Mon, 02 May 2016 04:11:09 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ax5CN-0002Db-7n for xen-devel@lists.xen.org; Mon, 02 May 2016 04:11:07 +0000 Received: from [193.109.254.147] by server-7.bemta-14.messagelabs.com id 52/06-03757-B53D6275; Mon, 02 May 2016 04:11:07 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNIsWRWlGSWpSXmKPExsVyMXThYd2oy2r hBlcu8los+biYxYHR4+ju30wBjFGsmXlJ+RUJrBlntu5iLNgkVLHm3hm2BsY5/F2MXBxCApMY JbpW9bKDOCwC85glmj9NZQNxJAT6WSVWbO8DynAAOTESy6cXdzFyApm1Egsa/7KA2EICChK/J xxigpg0mUni2t91bCAJNgENiSe/ZoDZIgLSEtc+X2YEKWIWeMYk8fpwFzNIQljAQWLu8idMID aLgKrE7CknwWxeAUeJhy+eM0IslpNY8N4HJMwp4CTR93UTM8RiR4mnH+4zTmAUWMDIsIpRvTi 1qCy1SNdIL6koMz2jJDcxM0fX0NBELze1uDgxPTUnMalYLzk/dxMjMLAYgGAHY8sc50OMkhxM SqK8k4+phQvxJeWnVGYkFmfEF5XmpBYfYpTh4FCS4L1xESgnWJSanlqRlpkDDHGYtAQHj5IIr +05oDRvcUFibnFmOkTqFKMlx5bf19YycXzaeAdIbpt6by2TEEtefl6qlDivySWgBgGQhozSPL hxsDi8xCgrJczLCHSgEE9BalFuZgmq/CtGcQ5GJWFeb5ApPJl5JXBbXwEdxAR0UPZ6VZCDShI RUlINjLnmR1ckOYtU3sgOnLLESDH8ajvTowkbn05gdj/CKbg470mIeVtQY/7R/b83HnDgUvEI N1GYIyUi9Wef9r6ufJN4wSfb7iw2uffJrfSbuATro9c2W981LP36hrVEd9Omo6q3hP8bLz9ZG D1tXWVyVNjc5t0FsgHzvmxNi9T3arj/QYb3FpOPrhJLcUaioRZzUXEiAEAIuKu+AgAA X-Env-Sender: cardoe@cardoe.com X-Msg-Ref: server-16.tower-27.messagelabs.com!1462162265!38894339!1 X-Originating-IP: [209.85.161.195] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG X-StarScan-Received: X-StarScan-Version: 8.34; banners=-,-,- X-VirusChecked: Checked Received: (qmail 57388 invoked from network); 2 May 2016 04:11:05 -0000 Received: from mail-yw0-f195.google.com (HELO mail-yw0-f195.google.com) (209.85.161.195) by server-16.tower-27.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 2 May 2016 04:11:05 -0000 Received: by mail-yw0-f195.google.com with SMTP id v81so17931597ywa.2 for ; Sun, 01 May 2016 21:11:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cardoe.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=r0eB9fuED4oIx7VLGiTErqMYb9kjLia1pkuF+U3L1pM=; b=fwZLoYI/EZ1sQaOSqLDV0Qyc9wtr1vAqyeVh7wXKYSFIBZNxwQl7xTZSo5Ib6eZXa7 I5JBVOlTsdwkIUfnX2HXTtP0MgjD64X+l5cu6PhZezTCynWh/GWx9LO69hzRKI+20e10 DkLJm4eDAQcDaD+Jr01bI7fpPHyaDSC7TJ0H4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=r0eB9fuED4oIx7VLGiTErqMYb9kjLia1pkuF+U3L1pM=; b=jNfGYoO3QJ/fgCMgKbnqxJiI9QmKRsmcBfCHHTIrY37rCZmfrj+s5k0FH48cK3j5B1 /c4CXBIuZyr5G6GGWgA9/QCpBBLr68d/H3EDWDGOruhRhjMeCOgd93o03OF1G0ZWr09f 428P2oZc9kl0TxJ0IlG32M10zjnXWi1j2ojVYeRpXVbIr1WIyS1Xok05oBOGypC2Yj0N dYeSTSZ0cDbmIKv9ibFQlkawEKfWKXp9CrAAJMGWrTz7KlP2fu58NSfO9N7w5KqO84UE R9d/mc/ED24O4JAalTnf959/PQzpw2ohklvjdmAi8qD8xwLIzqEzDhCcdJ2NFyKezvib 81FQ== X-Gm-Message-State: AOPr4FXnAMNlIn3Q5qVZwRAzim5YHRV6bn+EzYNTjztTpp4nzaiYlnYXFbo1pSBVBRkriQ== X-Received: by 10.129.130.135 with SMTP id s129mr17298376ywf.139.1462162264762; Sun, 01 May 2016 21:11:04 -0700 (PDT) Received: from swanson.lan (c-68-46-196-185.hsd1.al.comcast.net. [68.46.196.185]) by smtp.gmail.com with ESMTPSA id j3sm14334897ywj.32.2016.05.01.21.11.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 01 May 2016 21:11:03 -0700 (PDT) From: Doug Goldstein To: xen-devel@lists.xen.org Date: Sun, 1 May 2016 23:10:43 -0500 Message-Id: <1462162246-32413-5-git-send-email-cardoe@cardoe.com> X-Mailer: git-send-email 2.7.3 In-Reply-To: <1462162246-32413-1-git-send-email-cardoe@cardoe.com> References: <1462162246-32413-1-git-send-email-cardoe@cardoe.com> Cc: Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Doug Goldstein , Tim Deegan , Jan Beulich , Ian Jackson Subject: [Xen-devel] [RFC PATCH 4/7] build: convert frame_pointer to Kconfig X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID,UNPARSEABLE_RELAY,URIBL_BLACK autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Converts the frame_pointer option to a Kconfig option. Signed-off-by: Doug Goldstein --- CC: Andrew Cooper CC: George Dunlap CC: Ian Jackson CC: Jan Beulich CC: Konrad Rzeszutek Wilk CC: Stefano Stabellini CC: Tim Deegan CC: Wei Liu --- INSTALL | 1 - xen/Kconfig.debug | 8 ++++++++ xen/Rules.mk | 6 +----- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/INSTALL b/INSTALL index 35668bd..f55d42c 100644 --- a/INSTALL +++ b/INSTALL @@ -230,7 +230,6 @@ hypervisor build. perfc=y perfc_arrays=y lock_profile=y -frame_pointer=y lto=y During tools build external repos will be cloned into the source tree. diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug index 94a6381..0b2ec50 100644 --- a/xen/Kconfig.debug +++ b/xen/Kconfig.debug @@ -15,6 +15,14 @@ config CRASH_DEBUG If you want to be able to attach gdb to Xen to be able to debug Xen if it crashes then say Y. +config FRAME_POINTER + bool "Compile Xen with frame pointers" + default y + ---help--- + If you say Y here the resulting Xen will be slightly larger and + maybe slower, but it gives very useful debugging information + in case of any Xen bugs. + config VERBOSE_DEBUG bool "Verbose debug messages" default y diff --git a/xen/Rules.mk b/xen/Rules.mk index b159451..84b9d81 100644 --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -6,7 +6,6 @@ perfc ?= n perfc_arrays ?= n lock_profile ?= n -frame_pointer ?= n lto ?= n -include $(BASEDIR)/include/config/auto.conf @@ -15,9 +14,6 @@ include $(XEN_ROOT)/Config.mk # Hardcoded configuration implications and dependencies. # Do this is a neater way if it becomes unwieldy. -ifeq ($(debug),y) -frame_pointer := y -endif ifeq ($(perfc_arrays),y) perfc := y endif @@ -58,7 +54,7 @@ endif CFLAGS-$(perfc) += -DPERF_COUNTERS CFLAGS-$(perfc_arrays) += -DPERF_ARRAYS CFLAGS-$(lock_profile) += -DLOCK_PROFILE -CFLAGS-$(frame_pointer) += -fno-omit-frame-pointer -DCONFIG_FRAME_POINTER +CFLAGS-$(CONFIG_FRAME_POINTER) += -fno-omit-frame-pointer ifneq ($(max_phys_irqs),) CFLAGS-y += -DMAX_PHYS_IRQS=$(max_phys_irqs)