| Message ID | 1462194334-2761-1-git-send-email-konrad.wilk@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Mon, May 02, 2016 at 09:05:34AM -0400, Konrad Rzeszutek Wilk wrote: > Add the missing conditional. > > Reported-by: Jan Beulich <JBeulich@suse.com> > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > FWIW: Reviewed-by: Wei Liu <wei.liu2@citrix.com> And subject to ack from HV maintainer: Release-acked-by: Wei Liu <wei.liu2@citrix.com> > --- > This has been in there since v3 posting! And I really need to finish > with the OSSTest regression tests to catch this. > > Cc: Andrew Cooper <andrew.cooper3@citrix.com> > Cc: Jan Beulich <jbeulich@suse.com> > Cc: Wei Liu <wei.liu2@citrix.com> > --- > xen/common/xsplice.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/xen/common/xsplice.c b/xen/common/xsplice.c > index 777faa7..c9fc53a 100644 > --- a/xen/common/xsplice.c > +++ b/xen/common/xsplice.c > @@ -548,6 +548,7 @@ static int prepare_payload(struct payload *payload, > } > > sec = xsplice_elf_sec_by_name(elf, ELF_XSPLICE_DEPENDS); > + if ( sec ) > { > n = sec->load_addr; > > -- > 2.5.0 >
>>> On 02.05.16 at 15:09, <wei.liu2@citrix.com> wrote: > On Mon, May 02, 2016 at 09:05:34AM -0400, Konrad Rzeszutek Wilk wrote: >> Add the missing conditional. >> >> Reported-by: Jan Beulich <JBeulich@suse.com> >> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> >> > > FWIW: > > Reviewed-by: Wei Liu <wei.liu2@citrix.com> > > And subject to ack from HV maintainer: > > Release-acked-by: Wei Liu <wei.liu2@citrix.com> A think the ack can basically be implied from the Reported-by above; Konrad - feel free. Jan
On Mon, May 02, 2016 at 02:09:16PM +0100, Wei Liu wrote: > On Mon, May 02, 2016 at 09:05:34AM -0400, Konrad Rzeszutek Wilk wrote: > > Add the missing conditional. > > > > Reported-by: Jan Beulich <JBeulich@suse.com> > > Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> > > > > FWIW: > > Reviewed-by: Wei Liu <wei.liu2@citrix.com> > > And subject to ack from HV maintainer: > > Release-acked-by: Wei Liu <wei.liu2@citrix.com> > I would like to have Ack from Jan, Andrew or Ross if possible. But this bug is so trivial so whether they ack it or not my release ack stands. Wei.
diff --git a/xen/common/xsplice.c b/xen/common/xsplice.c index 777faa7..c9fc53a 100644 --- a/xen/common/xsplice.c +++ b/xen/common/xsplice.c @@ -548,6 +548,7 @@ static int prepare_payload(struct payload *payload, } sec = xsplice_elf_sec_by_name(elf, ELF_XSPLICE_DEPENDS); + if ( sec ) { n = sec->load_addr;
Add the missing conditional. Reported-by: Jan Beulich <JBeulich@suse.com> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> --- This has been in there since v3 posting! And I really need to finish with the OSSTest regression tests to catch this. Cc: Andrew Cooper <andrew.cooper3@citrix.com> Cc: Jan Beulich <jbeulich@suse.com> Cc: Wei Liu <wei.liu2@citrix.com> --- xen/common/xsplice.c | 1 + 1 file changed, 1 insertion(+)