From patchwork Tue May 3 14:29:10 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Douglas Goldstein X-Patchwork-Id: 9004311 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id F385C9F372 for ; Tue, 3 May 2016 14:31:40 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 06F0120270 for ; Tue, 3 May 2016 14:31:40 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ECB7C202E9 for ; Tue, 3 May 2016 14:31:38 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1axbKQ-0004Eu-PM; Tue, 03 May 2016 14:29:34 +0000 Received: from mail6.bemta6.messagelabs.com ([85.158.143.247]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1axbKP-0004EE-9U for xen-devel@lists.xen.org; Tue, 03 May 2016 14:29:33 +0000 Received: from [85.158.143.35] by server-3.bemta-6.messagelabs.com id 0F/1F-07120-CC5B8275; Tue, 03 May 2016 14:29:32 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFIsWRWlGSWpSXmKPExsVyMXThEd0zWzX CDRatYLNY8nExiwOjx9Hdv5kCGKNYM/OS8isSWDPOb/7DWLBJqOLPpOvsDYxz+LsYuTiEBCYy Smz6eoURxGERmMcs8XDtFBYQR0Kgn1Vi0ftj7F2MHEBOjMSENxVdjJxAZrXE0R9fWUFsIQEFi d8TDjFBTJrCJDHxwEawBJuAhsSTXzPYQGwRAWmJa58vg21gFnjGJPH6cBczSEJYwF5iw/GLYA 0sAqoSM8+tZgGxeQUcJDpeHWGEWCwnseC9D4jJKeAo8XpHOsReB4n7TfeZJjAKLGBkWMWoXpx aVJZapGukl1SUmZ5RkpuYmaNraGCml5taXJyYnpqTmFSsl5yfu4kRGFYMQLCDcdlfp0OMkhxM SqK8P5ZohAvxJeWnVGYkFmfEF5XmpBYfYpTh4FCS4M3ZApQTLEpNT61Iy8wBBjhMWoKDR0mEd zpImre4IDG3ODMdInWK0ZJjy+9ra5k4Pm28AyS3Tb23lkmIJS8/L1VKnDcCpEEApCGjNA9uHC wKLzHKSgnzMgIdKMRTkFqUm1mCKv+KUZyDUUmYtxxkCk9mXgnc1ldABzEBHZS9XhXkoJJEhJR UA6PEIQlOsfOb9wlzOxlnZJm+/O8tcPXz9Hnbj0vM8GC9uTLS8uzKy46s6y7Xs8m9LNt5drlh TL3tgb7zPzlFP4s9qp2RtVnlhbnexNdvpnCtWCi1WOb0V7kTlVlrvb13T6rivN0oeTkrsD84W d/g48wrfWZv5/R9T5wS2i5vWvJ3Lbuny7HpjHeUWIozEg21mIuKEwGoOlbPvQIAAA== X-Env-Sender: cardoe@cardoe.com X-Msg-Ref: server-11.tower-21.messagelabs.com!1462285771!12373857!1 X-Originating-IP: [209.85.161.196] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG X-StarScan-Received: X-StarScan-Version: 8.34; banners=-,-,- X-VirusChecked: Checked Received: (qmail 49742 invoked from network); 3 May 2016 14:29:32 -0000 Received: from mail-yw0-f196.google.com (HELO mail-yw0-f196.google.com) (209.85.161.196) by server-11.tower-21.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 3 May 2016 14:29:32 -0000 Received: by mail-yw0-f196.google.com with SMTP id i22so1766238ywc.1 for ; Tue, 03 May 2016 07:29:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cardoe.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=1gL0hvN3bF+aik1Gu6e9PLGnpjdCn1l4Pu7UfX1xfMs=; b=bSzkytPjSPP74WDRJX9pgWYDgXzhGUW3qmW32nsCcpcRuk9g/xc1VKzlLzm/VM0PIv l/zw9S7rGkN37nhe6to3x1bGjf1sF028FDUpOM9qcczj2ybD3pF5I1+J6Yv3t3Ci1/y3 IoAu88Iwr1ByR8w3Egk91ZGJVj2ArpaXefau8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=1gL0hvN3bF+aik1Gu6e9PLGnpjdCn1l4Pu7UfX1xfMs=; b=ARIFEANps5Ht/n8LTC53VmuZgPa7NG/MMtGCl/WcKb1ivFh4m1dXj5wBmCuWmoqI2G 8MlbU6w1BIFBghFmvQjCmGxKtNb0OKIiVao/VLsaumqNj7vIB1eVNpfcb1STWaFYnVVD Qou5guDKVNb+yndGZpr5vTrdup2pkWz3B23E2jqUXg9/X337oFMVwzjKEqstKoUydPXX D4DJ3SssJ4F0n33wbWHPnpCc9ds1REHKiqNTfHD0FIkylHidWIKQ4anQowljlTWDRzhk YSKnREvzMJ2BrMKOakWGLQ8j7uV28ph7IDMnioySWIaif1AiyBsEuUw9j+vPQKVWPAFp +cpg== X-Gm-Message-State: AOPr4FXg8vL+2TPMeIgYVEn2mxCxEx6qCtukB7F1HDEOosNN67fSNpLaFmPNK7i0TJ+9GA== X-Received: by 10.13.201.130 with SMTP id l124mr1482811ywd.212.1462285770832; Tue, 03 May 2016 07:29:30 -0700 (PDT) Received: from swanson.lan (c-68-46-196-185.hsd1.al.comcast.net. [68.46.196.185]) by smtp.gmail.com with ESMTPSA id l132sm1879409ywb.26.2016.05.03.07.29.29 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 03 May 2016 07:29:29 -0700 (PDT) From: Doug Goldstein To: xen-devel@lists.xen.org Date: Tue, 3 May 2016 09:29:10 -0500 Message-Id: <1462285753-5588-5-git-send-email-cardoe@cardoe.com> X-Mailer: git-send-email 2.7.3 In-Reply-To: <1462285753-5588-1-git-send-email-cardoe@cardoe.com> References: <1462285753-5588-1-git-send-email-cardoe@cardoe.com> Cc: Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Doug Goldstein , Tim Deegan , Jan Beulich , Ian Jackson Subject: [Xen-devel] [PATCH v2 4/7] build: convert frame_pointer to Kconfig X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Converts the frame_pointer option to a Kconfig option. Signed-off-by: Doug Goldstein --- CC: Andrew Cooper CC: George Dunlap CC: Ian Jackson CC: Jan Beulich CC: Konrad Rzeszutek Wilk CC: Stefano Stabellini CC: Tim Deegan CC: Wei Liu --- INSTALL | 1 - xen/Kconfig.debug | 8 ++++++++ xen/Rules.mk | 6 +----- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/INSTALL b/INSTALL index 35668bd..f55d42c 100644 --- a/INSTALL +++ b/INSTALL @@ -230,7 +230,6 @@ hypervisor build. perfc=y perfc_arrays=y lock_profile=y -frame_pointer=y lto=y During tools build external repos will be cloned into the source tree. diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug index 89e26fe..c75cf1d 100644 --- a/xen/Kconfig.debug +++ b/xen/Kconfig.debug @@ -15,6 +15,14 @@ config CRASH_DEBUG If you want to be able to attach gdb to Xen to be able to debug Xen if it crashes then say Y. +config FRAME_POINTER + bool "Compile Xen with frame pointers" + default y + ---help--- + If you say Y here the resulting Xen will be slightly larger and + maybe slower, but it gives very useful debugging information + in case of any Xen bugs. + config VERBOSE_DEBUG bool "Verbose debug messages" default y diff --git a/xen/Rules.mk b/xen/Rules.mk index b159451..84b9d81 100644 --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -6,7 +6,6 @@ perfc ?= n perfc_arrays ?= n lock_profile ?= n -frame_pointer ?= n lto ?= n -include $(BASEDIR)/include/config/auto.conf @@ -15,9 +14,6 @@ include $(XEN_ROOT)/Config.mk # Hardcoded configuration implications and dependencies. # Do this is a neater way if it becomes unwieldy. -ifeq ($(debug),y) -frame_pointer := y -endif ifeq ($(perfc_arrays),y) perfc := y endif @@ -58,7 +54,7 @@ endif CFLAGS-$(perfc) += -DPERF_COUNTERS CFLAGS-$(perfc_arrays) += -DPERF_ARRAYS CFLAGS-$(lock_profile) += -DLOCK_PROFILE -CFLAGS-$(frame_pointer) += -fno-omit-frame-pointer -DCONFIG_FRAME_POINTER +CFLAGS-$(CONFIG_FRAME_POINTER) += -fno-omit-frame-pointer ifneq ($(max_phys_irqs),) CFLAGS-y += -DMAX_PHYS_IRQS=$(max_phys_irqs)