From patchwork Tue May 10 21:05:27 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Douglas Goldstein X-Patchwork-Id: 9063301 Return-Path: X-Original-To: patchwork-xen-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id E83839F1D3 for ; Tue, 10 May 2016 21:08:10 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0ADD0201C7 for ; Tue, 10 May 2016 21:08:10 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1F6AE20154 for ; Tue, 10 May 2016 21:08:09 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b0Eqs-0006oI-NK; Tue, 10 May 2016 21:05:58 +0000 Received: from mail6.bemta6.messagelabs.com ([85.158.143.247]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b0Eqr-0006o5-Ep for xen-devel@lists.xen.org; Tue, 10 May 2016 21:05:57 +0000 Received: from [85.158.143.35] by server-1.bemta-6.messagelabs.com id 7F/2C-18833-43D42375; Tue, 10 May 2016 21:05:56 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNIsWRWlGSWpSXmKPExsVyMXThIV0jX6N wg4MtnBZLPi5mcWD0OLr7N1MAYxRrZl5SfkUCa8aFLcuZCpYIVcw6/oepgXEmfxcjF4eQwERG iUcrtzGCOCwC85gl3u7rZO5i5OSQEOhnlbhwKQPCjpF4uv4/O4RdJbFt8zVGEFtIQEHi94RDT BCTJjFJ3L93DqyITUBD4smvGWwgtoiAtMS1z5fBNjALPGOSeH24C2yDsIC9xK5PS1hBbBYBVY m2yb+ZQGxeAQeJ1e82ADVwAG2Tk1jw3gckzCngKLF4yioWiMUOEuc/X2CcwCiwgJFhFaN6cWp RWWqRrpFeUlFmekZJbmJmjq6hgZlebmpxcWJ6ak5iUrFecn7uJkZgYDEAwQ7GZX+dDjFKcjAp ifL2uBmFC/El5adUZiQWZ8QXleakFh9ilOHgUJLgFfcBygkWpaanVqRl5gBDHCYtwcGjJMIrA JLmLS5IzC3OTIdInWK05Njy+9paJo5PG+8AyW1T761lEmLJy89LlRLn5QRpEABpyCjNgxsHi8 NLjLJSwryMQAcK8RSkFuVmlqDKv2IU52BUEuZlA5nCk5lXArf1FdBBTEAHybHpgxxUkoiQkmp gzF6zVyuyc15DlXBtQezDtFvHjFuuKui6X53Ha9h1eDrX9hNyF159EpbScM489ySnxlp/b8nJ Xu/rxRs2MxmwRSRslH2txPzv46V8G3ZLlz3RqwXdTM8ZSHDK8jjcm1Ly97fmVn9T1du7lPT8b sUbd6vfWR6X8VG4+qCuxPkjVy7P3ahf0vBAiaU4I9FQi7moOBEA+rsi3r4CAAA= X-Env-Sender: cardoe@cardoe.com X-Msg-Ref: server-14.tower-21.messagelabs.com!1462914353!13514241!1 X-Originating-IP: [209.85.161.194] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG X-StarScan-Received: X-StarScan-Version: 8.34; banners=-,-,- X-VirusChecked: Checked Received: (qmail 7682 invoked from network); 10 May 2016 21:05:54 -0000 Received: from mail-yw0-f194.google.com (HELO mail-yw0-f194.google.com) (209.85.161.194) by server-14.tower-21.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 10 May 2016 21:05:54 -0000 Received: by mail-yw0-f194.google.com with SMTP id i22so2213939ywc.1 for ; Tue, 10 May 2016 14:05:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cardoe.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ASqUqihFDMFv7FZ6VHzF6D5XCAUluRbh+8Lff5xXzNw=; b=RIsZos16DZX0/xI6eV6qVegZFExMSbYPxAoUQpEaezKV0FQA2eIiKOEUCFs+z0hazk EwMLK6X6S8fXn9aK64BnSr8WUEZGDaI9VZCUl2ZV7ep0jbzDilaaHKUw5OWOaQnHhnGf NbtXNDT+VIToe4W9OxbG6f1EAUkKYRdp1s9gY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ASqUqihFDMFv7FZ6VHzF6D5XCAUluRbh+8Lff5xXzNw=; b=Vv8owGY3Z8EF9Mo9E5rq0i9uanUfC6OkiA3H9FFGPisVVmDiHkpQNAa0oC+3e/W19o jH2JqiuBi0MBmp0fgmB4dIM58BByqVjNrrYoYOOmW21+VIQ4i0gBh1FI3dQ/kGVdigQx HYErGgszVYhg/W4xiPP4E3qaGgJSCwux3I2m8wRdig5lqFIAaVmawIpAow/e6xn8jjn8 /FOYQlvIYRatp0YInMWSP3MZFucvrhC63+3/111MdrCqalpEkBZAw8Ndh8D1OU2wUgbN ukrrAKOOHIzPhxSzETZ94Q5PgecKxbIvARx47ntuBXqNOBb0xTohIgAE3e7OiNxXq10o nc7g== X-Gm-Message-State: AOPr4FUjmhZbrBeuYgh77U16CpWSxmtC3FvZlVmcgVqdJTWZwFrv1zGklxsPEMe4x4i/ZQ== X-Received: by 10.129.154.79 with SMTP id r76mr27026912ywg.86.1462914345921; Tue, 10 May 2016 14:05:45 -0700 (PDT) Received: from swanson.lan (c-68-46-196-185.hsd1.al.comcast.net. [68.46.196.185]) by smtp.gmail.com with ESMTPSA id e6sm2198740ywd.23.2016.05.10.14.05.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 10 May 2016 14:05:44 -0700 (PDT) From: Doug Goldstein To: xen-devel@lists.xen.org Date: Tue, 10 May 2016 16:05:27 -0500 Message-Id: <1462914329-8797-5-git-send-email-cardoe@cardoe.com> X-Mailer: git-send-email 2.7.3 In-Reply-To: <1462914329-8797-1-git-send-email-cardoe@cardoe.com> References: <1462914329-8797-1-git-send-email-cardoe@cardoe.com> Cc: Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Doug Goldstein , Tim Deegan , Jan Beulich , Ian Jackson Subject: [Xen-devel] [PATCH v3 4/6] build: convert frame_pointer to Kconfig X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_BL_SPAMCOP_NET, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Converts the frame_pointer option to a Kconfig option. Signed-off-by: Doug Goldstein --- CC: Andrew Cooper CC: George Dunlap CC: Ian Jackson CC: Jan Beulich CC: Konrad Rzeszutek Wilk CC: Stefano Stabellini CC: Tim Deegan CC: Wei Liu --- INSTALL | 1 - xen/Kconfig.debug | 8 ++++++++ xen/Rules.mk | 6 +----- 3 files changed, 9 insertions(+), 6 deletions(-) diff --git a/INSTALL b/INSTALL index 35668bd..f55d42c 100644 --- a/INSTALL +++ b/INSTALL @@ -230,7 +230,6 @@ hypervisor build. perfc=y perfc_arrays=y lock_profile=y -frame_pointer=y lto=y During tools build external repos will be cloned into the source tree. diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug index 734e78d..375c71d 100644 --- a/xen/Kconfig.debug +++ b/xen/Kconfig.debug @@ -15,6 +15,14 @@ config DEBUG option is intended for development purposes only, and not for production use. +config FRAME_POINTER + bool "Compile Xen with frame pointers" + default DEBUG + ---help--- + If you say Y here the resulting Xen will be slightly larger and + maybe slower, but it gives very useful debugging information + in case of any Xen bugs. + config VERBOSE_DEBUG bool "Verbose debug messages" default DEBUG diff --git a/xen/Rules.mk b/xen/Rules.mk index b159451..84b9d81 100644 --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -6,7 +6,6 @@ perfc ?= n perfc_arrays ?= n lock_profile ?= n -frame_pointer ?= n lto ?= n -include $(BASEDIR)/include/config/auto.conf @@ -15,9 +14,6 @@ include $(XEN_ROOT)/Config.mk # Hardcoded configuration implications and dependencies. # Do this is a neater way if it becomes unwieldy. -ifeq ($(debug),y) -frame_pointer := y -endif ifeq ($(perfc_arrays),y) perfc := y endif @@ -58,7 +54,7 @@ endif CFLAGS-$(perfc) += -DPERF_COUNTERS CFLAGS-$(perfc_arrays) += -DPERF_ARRAYS CFLAGS-$(lock_profile) += -DLOCK_PROFILE -CFLAGS-$(frame_pointer) += -fno-omit-frame-pointer -DCONFIG_FRAME_POINTER +CFLAGS-$(CONFIG_FRAME_POINTER) += -fno-omit-frame-pointer ifneq ($(max_phys_irqs),) CFLAGS-y += -DMAX_PHYS_IRQS=$(max_phys_irqs)