| Message ID | 1463665617-21781-2-git-send-email-roger.pau@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 19/05/16 14:46, Roger Pau Monne wrote: > Since it might be included from different paths that have different levels > of nestedness. Also all makefiles that include common.mk already define ROOT > on their own. > > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> I really need to work on improving the build system. This one is already creaking at the seams. LGTM - Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com> and committed.
diff --git a/build/common.mk b/build/common.mk index 13c468e..6d4c8e8 100644 --- a/build/common.mk +++ b/build/common.mk @@ -1,4 +1,3 @@ -ROOT := $(abspath $(CURDIR)/../..) DESTDIR ?= $(ROOT)/dist PREFIX ?= $(ROOT) CC ?= gcc
Since it might be included from different paths that have different levels of nestedness. Also all makefiles that include common.mk already define ROOT on their own. Signed-off-by: Roger Pau Monné <roger.pau@citrix.com> --- Cc: andrew.cooper3@citrix.com --- build/common.mk | 1 - 1 file changed, 1 deletion(-)