From patchwork Sun May 22 05:01:33 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Douglas Goldstein X-Patchwork-Id: 9130719 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 73C64607D3 for ; Sun, 22 May 2016 05:04:24 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1491E1FF27 for ; Sun, 22 May 2016 05:04:24 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0969628160; Sun, 22 May 2016 05:04:24 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 434402819A for ; Sun, 22 May 2016 05:04:19 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4LWY-0005d3-7V; Sun, 22 May 2016 05:01:58 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b4LWW-0005bc-Bn for xen-devel@lists.xen.org; Sun, 22 May 2016 05:01:56 +0000 Received: from [85.158.139.211] by server-2.bemta-5.messagelabs.com id C9/70-20564-44D31475; Sun, 22 May 2016 05:01:56 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNIsWRWlGSWpSXmKPExsVyMXThQV1nW8d wgyPLlC2WfFzM4sDocXT3b6YAxijWzLyk/IoE1oyjLzewFuwTrdizYhpTA+MnwS5GLg4hgQmM Emv29zKCOCwC85glfr+4zQriSAj0s0qsWvOKuYuRE8iJkTj9bhcrhF0lcerccnYQW0hAQeL3h ENMEKPmMUm0L13MBpJgE9CQePJrBpgtIiAtce3zZbAVzALPmCReH+4CmyosYC/x+VELWBGLgK rE6ZOnmEBsXgEHiQWXXwPZHEDb5CQWvPcBMTkFHCUufNeG2Osg0bBuIcsERoEFjAyrGNWLU4v KUot0TfWSijLTM0pyEzNzdA0NTPVyU4uLE9NTcxKTivWS83M3MQIDiwEIdjB+6Xc+xCjJwaQk ypvabR8uxJeUn1KZkVicEV9UmpNafIhRhoNDSYJX3sYxXEiwKDU9tSItMwcY4jBpCQ4eJRGIN G9xQWJucWY6ROoUoyXHlt/X1jJxfNp4B0hum3pvLZMQS15+XqqUOK8qSIMASENGaR7cOFgcXm KUlRLmZQQ6UIinILUoN7MEVf4VozgHo5IwryfIFJ7MvBK4ra+ADmICOuihtAPIQSWJCCmpBkY NnY4Ll6VFFVp4RSqehbxP1Plx92zc4/nL56XUR3dmxc98ZReWk7l13UUJQ7GiyB/CaiUbly55 +eN/3g5fM76qgncqn9hFV514rJhwZIGn5GX1SZzqe6rcfrzO1rhzwC1l4e+suPos1asftiswp 6esr2j/w831RlQiX/mUyeL1oawh0UYC6kosxRmJhlrMRcWJAB3C3zi+AgAA X-Env-Sender: cardoe@cardoe.com X-Msg-Ref: server-5.tower-206.messagelabs.com!1463893314!40913200!1 X-Originating-IP: [209.85.161.193] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG X-StarScan-Received: X-StarScan-Version: 8.34; banners=-,-,- X-VirusChecked: Checked Received: (qmail 64726 invoked from network); 22 May 2016 05:01:55 -0000 Received: from mail-yw0-f193.google.com (HELO mail-yw0-f193.google.com) (209.85.161.193) by server-5.tower-206.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 22 May 2016 05:01:55 -0000 Received: by mail-yw0-f193.google.com with SMTP id j74so887315ywg.1 for ; Sat, 21 May 2016 22:01:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cardoe.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=ip+n+vLF4WOro+a6m6BjepWyNRqkgcP3NKIxw/pfbQM=; b=Krlg2z9DGtX7VFfi4zudCeTH6ykFxFgVUaBMT6jynm9mau7Dgv2a5ulboKqOL5X/eR +jV16JIKT2CBt1Lsd/ut27kys4AB936VbmaZLa/M5aFZRtYNOjyTKpI2reQ3nEBCLVbE TnnnneYD7icEu+JGsyL5T3d1YK96bo4VCpCnc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=ip+n+vLF4WOro+a6m6BjepWyNRqkgcP3NKIxw/pfbQM=; b=SjyeCDjBK2Z7g4N5JisFEg6MPihK+wUo2NwPBX/t31yKgiLPFKVaXdbaULb/B31JtF RGvqqBS6aBJa6fypjY9RrwI8Z2owD56NKhzYAoday54+guTfF0Ru/A4EmwUmBhnczRT+ JQGZKYetcu+iNx4wCCur2T4S3fN2uRN59H2r0/vZzmUjahFpWOweTVn3bX4bk9hkhUNs oZJreDziEwkVUCbpLOU8oryfaDU2h6pBeVZDzzsD6mhYVXOWEG6ZccByxgN3GOYBLi34 dmStNIQldRUrSZ+IJQYDGLkxZn9xdocv6EPGWOKBPYDQlRowQFxsVGZe8sP/X5F316BV nnFg== X-Gm-Message-State: AOPr4FU+RkwqEA5pQJgly+Kq4+9UrFOGnYrfucW4LRKRdgXC2uj/L8H8arO5PqNuZyueZQ== X-Received: by 10.13.194.134 with SMTP id e128mr5901714ywd.57.1463893314297; Sat, 21 May 2016 22:01:54 -0700 (PDT) Received: from localhost.localdomain (c-68-46-196-185.hsd1.al.comcast.net. [68.46.196.185]) by smtp.gmail.com with ESMTPSA id z20sm15961686ywd.44.2016.05.21.22.01.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 21 May 2016 22:01:53 -0700 (PDT) From: Doug Goldstein To: xen-devel@lists.xen.org Date: Sun, 22 May 2016 00:01:33 -0500 Message-Id: <1463893295-2610-5-git-send-email-cardoe@cardoe.com> X-Mailer: git-send-email 2.7.3 In-Reply-To: <1463893295-2610-1-git-send-email-cardoe@cardoe.com> References: <1463893295-2610-1-git-send-email-cardoe@cardoe.com> Cc: Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Doug Goldstein , Tim Deegan , Jan Beulich , Ian Jackson Subject: [Xen-devel] [PATCH v4 4/6] build: convert frame_pointer to Kconfig X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Converts the frame_pointer option to a Kconfig option. Signed-off-by: Doug Goldstein --- CC: Andrew Cooper CC: George Dunlap CC: Ian Jackson CC: Jan Beulich CC: Konrad Rzeszutek Wilk CC: Stefano Stabellini CC: Tim Deegan CC: Wei Liu --- INSTALL | 1 - xen/Kconfig.debug | 8 ++++++++ xen/Rules.mk | 9 ++++----- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/INSTALL b/INSTALL index 35668bd..f55d42c 100644 --- a/INSTALL +++ b/INSTALL @@ -230,7 +230,6 @@ hypervisor build. perfc=y perfc_arrays=y lock_profile=y -frame_pointer=y lto=y During tools build external repos will be cloned into the source tree. diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug index 7c115b0..f4eb815 100644 --- a/xen/Kconfig.debug +++ b/xen/Kconfig.debug @@ -19,6 +19,14 @@ config CRASH_DEBUG If you want to be able to attach gdb to Xen to be able to debug Xen if it crashes then say Y. +config FRAME_POINTER + bool "Compile Xen with frame pointers" + default DEBUG + ---help--- + If you say Y here the resulting Xen will be slightly larger and + maybe slower, but it gives very useful debugging information + in case of any Xen bugs. + config VERBOSE_DEBUG bool "Verbose debug messages" default DEBUG diff --git a/xen/Rules.mk b/xen/Rules.mk index 55096d3..ab6f7fc 100644 --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -6,7 +6,6 @@ perfc ?= n perfc_arrays ?= n lock_profile ?= n -frame_pointer ?= n lto ?= n -include $(BASEDIR)/include/config/auto.conf @@ -15,9 +14,6 @@ include $(XEN_ROOT)/Config.mk # Hardcoded configuration implications and dependencies. # Do this is a neater way if it becomes unwieldy. -ifeq ($(debug),y) -frame_pointer := y -endif ifeq ($(perfc_arrays),y) perfc := y endif @@ -28,6 +24,9 @@ endif ifeq ($(origin debug),command line) $(error "You must use 'make menuconfig' to enable/disable debug now.") endif +ifneq ($(origin frame_pointer),undefined) +$(error "You must use 'make menuconfig' to enable/disable frame_pointer now.") +endif ifneq ($(origin kexec),undefined) $(error "You must use 'make menuconfig' to enable/disable kexec now.") endif @@ -64,7 +63,7 @@ endif CFLAGS-$(perfc) += -DPERF_COUNTERS CFLAGS-$(perfc_arrays) += -DPERF_ARRAYS CFLAGS-$(lock_profile) += -DLOCK_PROFILE -CFLAGS-$(frame_pointer) += -fno-omit-frame-pointer -DCONFIG_FRAME_POINTER +CFLAGS-$(CONFIG_FRAME_POINTER) += -fno-omit-frame-pointer ifneq ($(max_phys_irqs),) CFLAGS-y += -DMAX_PHYS_IRQS=$(max_phys_irqs)