From patchwork Tue May 24 13:56:37 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Douglas Goldstein X-Patchwork-Id: 9133721 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 99AB16075E for ; Tue, 24 May 2016 13:59:12 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8C48928233 for ; Tue, 24 May 2016 13:59:12 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 80C8E28288; Tue, 24 May 2016 13:59:12 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id AE96228233 for ; Tue, 24 May 2016 13:59:10 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b5CpS-000674-Tn; Tue, 24 May 2016 13:57:02 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b5CpR-000669-5p for xen-devel@lists.xen.org; Tue, 24 May 2016 13:57:01 +0000 Received: from [193.109.254.147] by server-4.bemta-14.messagelabs.com id D4/6B-28349-CAD54475; Tue, 24 May 2016 13:57:00 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrNIsWRWlGSWpSXmKPExsVyMXThEd3VsS7 hBpMPGVos+biYxYHR4+ju30wBjFGsmXlJ+RUJrBkz595gLjglVvFp1XemBsbvQl2MXBxCAhMZ JfofLmYDcVgE5jFL/Jx4mAXEkRDoZ5V4/voyUxcjJ5ATI7F51lRWCLtaovvvbEYQW0hAQeL3h ENMEKOmMEncvHeaDSTBJqAh8eTXDDBbREBa4trny4wgRcwCz5gkXh/uYgZJCAvYS0zZ0gc2iU VAVeLRmf1gcV4BR4ljTWuAmjmAtslJLHjvA2JyCjhJbPsmD7HXUeLx/CPMExgFFjAyrGJUL04 tKkst0jXUSyrKTM8oyU3MzNE1NDTRy00tLk5MT81JTCrWS87P3cQIDCwGINjBeLTT+RCjJAeT kiivgZZLuBBfUn5KZUZicUZ8UWlOavEhRhkODiUJ3oIYoJxgUWp6akVaZg4wxGHSEhw8SiK80 0HSvMUFibnFmekQqVOMlhxbfl9by8TxaeMdILlt6r21TEIsefl5qVLiEPMEQBoySvPgxsHi8B KjrJQwLyPQgUI8BalFuZklqPKvGMU5GJWEeZeDTOHJzCuB2/oK6CAmoIP8vziDHFSSiJCSamC sLg2xe8hwXVBJ5pfrB9WJIVf5XqeWKr9+V3E1eqP/ivhA71nbv+qXHhIOf7NB8Hrk+vfMCd1L n8X63JmzuM/0g9WV7ZFL36YvvZ4peGm28XU/vrP7Th8MLXCJEPkatfBpQrEz/1UdN9763YYxG XWyQT7ex0SSWIqfWFRf33Wmxyfl/IMnEs+UWIozEg21mIuKEwGVXDr3vgIAAA== X-Env-Sender: cardoe@cardoe.com X-Msg-Ref: server-6.tower-27.messagelabs.com!1464098218!43625327!1 X-Originating-IP: [209.85.161.196] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG X-StarScan-Received: X-StarScan-Version: 8.34; banners=-,-,- X-VirusChecked: Checked Received: (qmail 7439 invoked from network); 24 May 2016 13:56:59 -0000 Received: from mail-yw0-f196.google.com (HELO mail-yw0-f196.google.com) (209.85.161.196) by server-6.tower-27.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 24 May 2016 13:56:59 -0000 Received: by mail-yw0-f196.google.com with SMTP id n16so2329865ywd.2 for ; Tue, 24 May 2016 06:56:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cardoe.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=btIfSqjmzcurFQBrOpfZ3WQv+lHGz/qcMb5bRzK7aLc=; b=VJzhMOAtB123XR9B5hUr+33GcaK/Op5/UsybAM8UoByfX9kivuTT/NFNsYRfQksdRi /OtsdIt4SbjU/ATU1sPA0zAy1o/YK3Zd6In+fBCzMbrFIgtztkdTCN9zXLEgGpLj6QnS dGddYB58y32LQ5Y0Gi07auui4/C8Pvi712n14= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=btIfSqjmzcurFQBrOpfZ3WQv+lHGz/qcMb5bRzK7aLc=; b=XfOWtJZ/r6/r6fHjRYOA0UuEK3aNyA0hKKUwSeo3PRJ51vyox9tzXBwPM+s4QT5HIw VeL/4zUK1qiqKhRt0xfIQoFg4krPy8smUh8fA3QpgPIy5szDdxVRRz0sOKCOG5CLbadK VJHYn2uBKEBXh0CaspbJkXpNR3aqYSfzaTrZU7OIk9dTQNidvGGt6xWrXI+CIHyk4k3U OTlH1KUKzlpL1BE2irx69E9x7C4hw1IoqHO+nXQT4CJfPcXKd+pzwuwgYXaVBC0RZQGx LhXOmwY2tC+Bc7TI6hb5Ind4cIrho1vN0WCMrmIhxR+lFQEzYgreXBJWdAvtH945jSgj 6MNA== X-Gm-Message-State: ALyK8tJL8F5lZs2LAePTOFojx2c03DGKoQUHPqFmgKqK5Z7DUBtaexFiFZDh9cVxAkxwKw== X-Received: by 10.129.40.197 with SMTP id o188mr2519953ywo.250.1464098218393; Tue, 24 May 2016 06:56:58 -0700 (PDT) Received: from swanson.lan (c-68-46-196-185.hsd1.al.comcast.net. [68.46.196.185]) by smtp.gmail.com with ESMTPSA id i67sm22199641ywf.34.2016.05.24.06.56.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 24 May 2016 06:56:57 -0700 (PDT) From: Doug Goldstein To: xen-devel@lists.xen.org Date: Tue, 24 May 2016 08:56:37 -0500 Message-Id: <1464098199-19851-5-git-send-email-cardoe@cardoe.com> X-Mailer: git-send-email 2.7.3 In-Reply-To: <1464098199-19851-1-git-send-email-cardoe@cardoe.com> References: <1464098199-19851-1-git-send-email-cardoe@cardoe.com> Cc: Stefano Stabellini , Wei Liu , George Dunlap , Andrew Cooper , Doug Goldstein , Tim Deegan , Jan Beulich , Ian Jackson Subject: [Xen-devel] [PATCH v5 4/6] build: convert frame_pointer to Kconfig X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP Converts the frame_pointer option to a Kconfig option. Signed-off-by: Doug Goldstein Reviewed-by: Andrew Cooper Reviewed-by: Konrad Rzeszutek Wilk Reviewed-by: Jan Beulich --- CC: Andrew Cooper CC: George Dunlap CC: Ian Jackson CC: Jan Beulich CC: Konrad Rzeszutek Wilk CC: Stefano Stabellini CC: Tim Deegan CC: Wei Liu --- INSTALL | 1 - xen/Kconfig.debug | 8 ++++++++ xen/Rules.mk | 9 ++++----- 3 files changed, 12 insertions(+), 6 deletions(-) diff --git a/INSTALL b/INSTALL index 35668bd..f55d42c 100644 --- a/INSTALL +++ b/INSTALL @@ -230,7 +230,6 @@ hypervisor build. perfc=y perfc_arrays=y lock_profile=y -frame_pointer=y lto=y During tools build external repos will be cloned into the source tree. diff --git a/xen/Kconfig.debug b/xen/Kconfig.debug index fb11c56..664a67b 100644 --- a/xen/Kconfig.debug +++ b/xen/Kconfig.debug @@ -20,6 +20,14 @@ config CRASH_DEBUG If you want to attach gdb to Xen to debug Xen if it crashes then say Y. +config FRAME_POINTER + bool "Compile Xen with frame pointers" + default DEBUG + ---help--- + If you say Y here the resulting Xen will be slightly larger and + maybe slower, but it gives very useful debugging information + in case of any Xen bugs. + config VERBOSE_DEBUG bool "Verbose debug messages" default DEBUG diff --git a/xen/Rules.mk b/xen/Rules.mk index 2a93ef7..418fc74 100644 --- a/xen/Rules.mk +++ b/xen/Rules.mk @@ -6,7 +6,6 @@ perfc ?= n perfc_arrays ?= n lock_profile ?= n -frame_pointer ?= n lto ?= n -include $(BASEDIR)/include/config/auto.conf @@ -15,9 +14,6 @@ include $(XEN_ROOT)/Config.mk # Hardcoded configuration implications and dependencies. # Do this is a neater way if it becomes unwieldy. -ifeq ($(debug),y) -frame_pointer := y -endif ifeq ($(perfc_arrays),y) perfc := y endif @@ -28,6 +24,9 @@ endif ifeq ($(origin debug),command line) $(warning "You must use 'make menuconfig' to enable/disable debug now.") endif +ifneq ($(origin frame_pointer),undefined) +$(error "You must use 'make menuconfig' to enable/disable frame_pointer now.") +endif ifneq ($(origin kexec),undefined) $(error "You must use 'make menuconfig' to enable/disable kexec now.") endif @@ -64,7 +63,7 @@ endif CFLAGS-$(perfc) += -DPERF_COUNTERS CFLAGS-$(perfc_arrays) += -DPERF_ARRAYS CFLAGS-$(lock_profile) += -DLOCK_PROFILE -CFLAGS-$(frame_pointer) += -fno-omit-frame-pointer -DCONFIG_FRAME_POINTER +CFLAGS-$(CONFIG_FRAME_POINTER) += -fno-omit-frame-pointer ifneq ($(max_phys_irqs),) CFLAGS-y += -DMAX_PHYS_IRQS=$(max_phys_irqs)