| Message ID | 1464191801-1294-3-git-send-email-julien.grall@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
>>> On 25.05.16 at 17:56, <julien.grall@arm.com> wrote: > Currently, XENMAPSPACE_dev_mmio maps MMIO regions using one of the most > restrictive memory attribute (Device-nGnRE). > > Signed-off-by: Julien Grall <julien.grall@arm.com> Acked-by: Jan Beulich <jbeulich@suse.com> irrespective of whether ... > --- a/xen/include/public/memory.h > +++ b/xen/include/public/memory.h > @@ -220,7 +220,11 @@ DEFINE_XEN_GUEST_HANDLE(xen_machphys_mapping_t); > #define XENMAPSPACE_gmfn_range 3 /* GMFN range, XENMEM_add_to_physmap > only. */ > #define XENMAPSPACE_gmfn_foreign 4 /* GMFN from another dom, > * XENMEM_add_to_physmap_batch only. */ > -#define XENMAPSPACE_dev_mmio 5 /* device mmio region */ > +#define XENMAPSPACE_dev_mmio 5 /* device mmio region > + ARM only; the region will be mapped > + in Stage-2 using the memory attribute > + "Device-nGnRE" (previously named > + "Device" on ARMv7) */ "will be" would get replaced as suggested by Stefano (I don't think the current wording is really misleading). Jan
diff --git a/xen/include/public/memory.h b/xen/include/public/memory.h index a5ab139..cfb427f 100644 --- a/xen/include/public/memory.h +++ b/xen/include/public/memory.h @@ -220,7 +220,11 @@ DEFINE_XEN_GUEST_HANDLE(xen_machphys_mapping_t); #define XENMAPSPACE_gmfn_range 3 /* GMFN range, XENMEM_add_to_physmap only. */ #define XENMAPSPACE_gmfn_foreign 4 /* GMFN from another dom, * XENMEM_add_to_physmap_batch only. */ -#define XENMAPSPACE_dev_mmio 5 /* device mmio region */ +#define XENMAPSPACE_dev_mmio 5 /* device mmio region + ARM only; the region will be mapped + in Stage-2 using the memory attribute + "Device-nGnRE" (previously named + "Device" on ARMv7) */ /* ` } */ /*
Currently, XENMAPSPACE_dev_mmio maps MMIO regions using one of the most restrictive memory attribute (Device-nGnRE). Signed-off-by: Julien Grall <julien.grall@arm.com> --- Changes in v2: - s/Device_nGnRE/Device-nGnRE/ to match the spec - Update the comment to mention the name for ARMv7. --- xen/include/public/memory.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)