diff mbox

xen/Makefile: quote HOSTCC and HOSTCXX args

Message ID 1464707632-7435-1-git-send-email-cjp256@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Chris Patterson May 31, 2016, 3:13 p.m. UTC 
From: Chris Patterson <pattersonc@ainfosec.com>

In some cross-compilation environments, the CC/CXX variables may
expand out to more than one argument (to include things
like --sysroot=...).  Quote these to safely pass along.

Signed-off-by: Chris Patterson <pattersonc@ainfosec.com>
---
 xen/Makefile | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Jan Beulich May 31, 2016, 4:22 p.m. UTC | #1 
>>> On 31.05.16 at 17:13, <cjp256@gmail.com> wrote:
> From: Chris Patterson <pattersonc@ainfosec.com>
> 
> In some cross-compilation environments, the CC/CXX variables may
> expand out to more than one argument (to include things
> like --sysroot=...).  Quote these to safely pass along.
> 
> Signed-off-by: Chris Patterson <pattersonc@ainfosec.com>

Acked-by: Jan Beulich <jbeulich@suse.com>

Wei, do we want this in 4.7?

Jan
Wei Liu May 31, 2016, 5:45 p.m. UTC | #2 
On Tue, May 31, 2016 at 10:22:41AM -0600, Jan Beulich wrote:
> >>> On 31.05.16 at 17:13, <cjp256@gmail.com> wrote:
> > From: Chris Patterson <pattersonc@ainfosec.com>
> > 
> > In some cross-compilation environments, the CC/CXX variables may
> > expand out to more than one argument (to include things
> > like --sysroot=...).  Quote these to safely pass along.
> > 
> > Signed-off-by: Chris Patterson <pattersonc@ainfosec.com>
> 
> Acked-by: Jan Beulich <jbeulich@suse.com>
> 
> Wei, do we want this in 4.7?

Yes.

I've queued this up.

Wei.

> 
> Jan
>
diff mbox

Patch

diff --git a/xen/Makefile b/xen/Makefile
index 0d5f240..b59f95d 100644
--- a/xen/Makefile
+++ b/xen/Makefile
@@ -246,14 +246,14 @@  kconfig := silentoldconfig oldconfig config menuconfig defconfig \
 	randconfig
 .PHONY: $(kconfig)
 $(kconfig):
-	$(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC=$(HOSTCC) HOSTCXX=$(HOSTCXX) $@
+	$(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)" $@
 
 include/config/%.conf: include/config/auto.conf.cmd $(KCONFIG_CONFIG)
-	$(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC=$(HOSTCC) HOSTCXX=$(HOSTCXX) silentoldconfig
+	$(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)" silentoldconfig
 
 # Allow people to just run `make` as before and not force them to configure
 $(KCONFIG_CONFIG):
-	$(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC=$(HOSTCC) HOSTCXX=$(HOSTCXX) defconfig
+	$(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)" defconfig
 
 # Break the dependency chain for the first run
 include/config/auto.conf.cmd: ;