From patchwork Tue May 31 15:13:52 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Patterson X-Patchwork-Id: 9145007 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id DE51460752 for ; Tue, 31 May 2016 15:17:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CECA92198E for ; Tue, 31 May 2016 15:17:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C38E32796F; Tue, 31 May 2016 15:17:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 99B742198E for ; Tue, 31 May 2016 15:17:10 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7lNU-000857-Bu; Tue, 31 May 2016 15:14:44 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1b7lNS-000851-I7 for xen-devel@lists.xen.org; Tue, 31 May 2016 15:14:42 +0000 Received: from [85.158.139.211] by server-17.bemta-5.messagelabs.com id 31/7C-28468-16AAD475; Tue, 31 May 2016 15:14:41 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjkeJIrShJLcpLzFFi42K5GHrAWTd+lW+ 4wa6d3BZLPi5mcWD0OLr7N1MAYxRrZl5SfkUCa8bpKXsZCybyVvzY+ZapgfE2dxcjF4eQwARG ieauGYxdjJwcLAKXWCR2z84BSUgIvGOReNl9jQ0kISEQI3Fy6zRmCLtCYmv/P3YQW0hAXuLvg SmMUJOYJCafPQ9UxMHBJqAhceqGC0iNiIC0xLXPl8FqmAXeMEpcPrUGbJCwgI3EtE3NLBCbVS W6Wx6DxXkF7CUePvjPDrFMTuL88Z/MExj5FjAyrGLUKE4tKkst0jU01ksqykzPKMlNzMzRNTQ w1ctNLS5OTE/NSUwq1kvOz93ECAwVBiDYwfhvm+chRkkOJiVR3rTFvuFCfEn5KZUZicUZ8UWl OanFhxhlODiUJHhNVwLlBItS01Mr0jJzgEELk5bg4FES4Q0ESfMWFyTmFmemQ6ROMRpzbPl9b S0Tx7ap99YyCbHk5eelSonz/l0BVCoAUppRmgc3CBZNlxhlpYR5GYFOE+IpSC3KzSxBlX/FKM 7BqCTMawOykCczrwRu3yugU5iATonP8AE5pSQRISXVwGjyWNxP71ac5+mfIoVnlDjFs6bedmh 7cYtZpTF7375pc5tCkg+KFYQnHGidrzNDSFXAfFLzG1OlUNlPX78+SG2S5ZeSPH6u92+J+tV2 i4fNR2ed3e2Y+SmbS7p+/42NJ1imPuW/+mlmQWzKpc3SM9zyhb52OXNtkpsZmvfbpJFlNvO/7 58K9ZVYijMSDbWYi4oTAeYaWBWhAgAA X-Env-Sender: cjp256@gmail.com X-Msg-Ref: server-2.tower-206.messagelabs.com!1464707678!26469180!1 X-Originating-IP: [209.85.192.67] X-SpamReason: No, hits=0.5 required=7.0 tests=BODY_RANDOM_LONG, UPPERCASE_25_50 X-StarScan-Received: X-StarScan-Version: 8.46; banners=-,-,- X-VirusChecked: Checked Received: (qmail 35794 invoked from network); 31 May 2016 15:14:39 -0000 Received: from mail-qg0-f67.google.com (HELO mail-qg0-f67.google.com) (209.85.192.67) by server-2.tower-206.messagelabs.com with AES128-GCM-SHA256 encrypted SMTP; 31 May 2016 15:14:39 -0000 Received: by mail-qg0-f67.google.com with SMTP id z67so4318706qgz.1 for ; Tue, 31 May 2016 08:14:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=brNlWDd2LEzQC/vk3YaiZgqvUt33zd3BsROQO2+V1T4=; b=nJHqKgndxLzIOd6YarmM22jwzycWVqzHj+OVBoUyzfw1qSSfdq6E8GRR+MnMM5VCUB nI1Lahd996PL2Keem7/Fiw7JAjegSoYjzaF1nX+0kkfiQxJO6fDxLakbPynbYllcfm2C dh609urLF4CQPaKIBUmTeJZXa1kW3i5KdUuTD4/qfFr1F+AF8eqcAtDVywPwGvxaASLz +E91heobowNgV43y4gvPT69KaaWMM20K5Y+YI2+UoEn2SJoLAojHALumiJdm32U5TU9u t4cuwvZJw2xd7X9keg9fVgFoqycJnVrgIhfgCKvU1yPLPUXaQGsz5OQFOeU7PH4+RTY0 HJ2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=brNlWDd2LEzQC/vk3YaiZgqvUt33zd3BsROQO2+V1T4=; b=PbpWZt8jeB6gUakktqrPzip+30NpOCuBB0/F0rWy+uJHsNZt+wr4xVvpnx291g9kg6 2yLruXdtphUlC15Sf0IV325Ono9WokwNBnOJ1E4h+RH5P5Iu7YBc0055O2iwBM4yhDNY mzU2m+pJ7CYS27w6G6JeSNouFFq3DGR4r14DVJBfBr9ViHZFlRO8qDWXk7u/2gHGGvIe TTi3IOeJfDQ7sCPOONUzNCa1N/fkSrh4p51wh9vR/ivFReUkoHQR144hCnawjSccy3W7 jsO5D+Gf/zLbeI1Y8T8hs5WfHKXku9TWXkBaSSoS1xc+9+huJqjLmuopjrPoGYR9x/li WQog== X-Gm-Message-State: ALyK8tLd8Q/u11xcFEbjt6nJXiffXybD7gLr6A07LRUe0VrSsTbuvt0dxwg5eQncdeGDBw== X-Received: by 10.140.170.5 with SMTP id q5mr24008229qhq.50.1464707678142; Tue, 31 May 2016 08:14:38 -0700 (PDT) Received: from roost.members.linode.com (chrispatterson.net. [66.175.209.160]) by smtp.gmail.com with ESMTPSA id c94sm8340519qge.36.2016.05.31.08.14.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 31 May 2016 08:14:37 -0700 (PDT) From: Chris Patterson To: xen-devel@lists.xen.org Date: Tue, 31 May 2016 11:13:52 -0400 Message-Id: <1464707632-7435-1-git-send-email-cjp256@gmail.com> X-Mailer: git-send-email 2.1.4 Cc: sstabellini@kernel.org, wei.liu2@citrix.com, George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, Chris Patterson , jbeulich@suse.com, im@xen.org Subject: [Xen-devel] [PATCH] xen/Makefile: quote HOSTCC and HOSTCXX args X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP From: Chris Patterson In some cross-compilation environments, the CC/CXX variables may expand out to more than one argument (to include things like --sysroot=...). Quote these to safely pass along. Signed-off-by: Chris Patterson Acked-by: Jan Beulich --- xen/Makefile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/xen/Makefile b/xen/Makefile index 0d5f240..b59f95d 100644 --- a/xen/Makefile +++ b/xen/Makefile @@ -246,14 +246,14 @@ kconfig := silentoldconfig oldconfig config menuconfig defconfig \ randconfig .PHONY: $(kconfig) $(kconfig): - $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC=$(HOSTCC) HOSTCXX=$(HOSTCXX) $@ + $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)" $@ include/config/%.conf: include/config/auto.conf.cmd $(KCONFIG_CONFIG) - $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC=$(HOSTCC) HOSTCXX=$(HOSTCXX) silentoldconfig + $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)" silentoldconfig # Allow people to just run `make` as before and not force them to configure $(KCONFIG_CONFIG): - $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC=$(HOSTCC) HOSTCXX=$(HOSTCXX) defconfig + $(MAKE) -f $(BASEDIR)/tools/kconfig/Makefile.kconfig ARCH=$(ARCH) SRCARCH=$(SRCARCH) HOSTCC="$(HOSTCC)" HOSTCXX="$(HOSTCXX)" defconfig # Break the dependency chain for the first run include/config/auto.conf.cmd: ;