| Message ID | 1465210332-25440-7-git-send-email-wei.liu2@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Wei Liu writes ("[PATCH 6/6] libxl: log file name in failure in libxl__create_qemu_logfile"):
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
It would be nice to fix the error handling pattern to `goto out'
style, but this patch is an improvement.
Ian.
diff --git a/tools/libxl/libxl_dm.c b/tools/libxl/libxl_dm.c index 155a653..69d2242 100644 --- a/tools/libxl/libxl_dm.c +++ b/tools/libxl/libxl_dm.c @@ -52,13 +52,15 @@ static int libxl__create_qemu_logfile(libxl__gc *gc, char *name) if (rc) return rc; logfile_w = open(logfile, O_WRONLY|O_CREAT|O_APPEND, 0644); - free(logfile); if (logfile_w < 0) { - LOGE(ERROR, "unable to open Qemu logfile"); + LOGE(ERROR, "unable to open Qemu logfile: %s", logfile); + free(logfile); return ERROR_FAIL; } + free(logfile); + return logfile_w; }
Signed-off-by: Wei Liu <wei.liu2@citrix.com> --- tools/libxl/libxl_dm.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)