| Message ID | 1465804155-14469-9-git-send-email-wei.liu2@citrix.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Wei Liu writes ("[PATCH 08/17] tools: remove hard-coded /var/lib/xen in Makefile"):
> Now all conversations are done, remove the hard-coded paths.
Should we not keep these for (most of) a release cycle ?
Otherwise someone who tries to use the new feature in 4.8 will find it
doesn't uninstall their previous install.
Ian.
On Mon, Jun 13, 2016 at 04:13:26PM +0100, Ian Jackson wrote: > Wei Liu writes ("[PATCH 08/17] tools: remove hard-coded /var/lib/xen in Makefile"): > > Now all conversations are done, remove the hard-coded paths. > > Should we not keep these for (most of) a release cycle ? > > Otherwise someone who tries to use the new feature in 4.8 will find it > doesn't uninstall their previous install. > TBH I think the uninstall target has been broken for a long time. I merely added the rm rune for completeness. Last time I tried it didn't remove things cleanly. For one there is no rune to remove systemd unit files. For now, I'm fine with keeping the uninstall target rune. Wei. > Ian.
Wei Liu writes ("Re: [PATCH 08/17] tools: remove hard-coded /var/lib/xen in Makefile"):
> TBH I think the uninstall target has been broken for a long time. I
> merely added the rm rune for completeness. Last time I tried it didn't
> remove things cleanly. For one there is no rune to remove systemd unit
> files.
Mmmm. So maybe we should just drop this now.
> For now, I'm fine with keeping the uninstall target rune.
It might sit there forever and eventually remove some wrong thing...
Ian.
On Mon, Jun 13, 2016 at 05:07:11PM +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH 08/17] tools: remove hard-coded /var/lib/xen in Makefile"): > > TBH I think the uninstall target has been broken for a long time. I > > merely added the rm rune for completeness. Last time I tried it didn't > > remove things cleanly. For one there is no rune to remove systemd unit > > files. > > Mmmm. So maybe we should just drop this now. Drop what? Drop the uninstall target all together? Or just the rune in this patch? > > > For now, I'm fine with keeping the uninstall target rune. > > It might sit there forever and eventually remove some wrong thing... > Indeed. > Ian.
Wei Liu writes ("Re: [PATCH 08/17] tools: remove hard-coded /var/lib/xen in Makefile"):
> On Mon, Jun 13, 2016 at 05:07:11PM +0100, Ian Jackson wrote:
> > Mmmm. So maybe we should just drop this now.
>
> Drop what? Drop the uninstall target all together? Or just the rune in
> this patch?
I meant we should keep this patch and therefore drop the rune that is
being deleted by this patch.
Ian.
On Mon, Jun 13, 2016 at 05:57:26PM +0100, Ian Jackson wrote: > Wei Liu writes ("Re: [PATCH 08/17] tools: remove hard-coded /var/lib/xen in Makefile"): > > On Mon, Jun 13, 2016 at 05:07:11PM +0100, Ian Jackson wrote: > > > Mmmm. So maybe we should just drop this now. > > > > Drop what? Drop the uninstall target all together? Or just the rune in > > this patch? > > I meant we should keep this patch and therefore drop the rune that is > being deleted by this patch. > Does that mean you're satisfied with this patch? Can I translate this thread into an ack? Wei. > Ian.
Wei Liu writes ("Re: [PATCH 08/17] tools: remove hard-coded /var/lib/xen in Makefile"):
> Does that mean you're satisfied with this patch? Can I translate this
> thread into an ack?
Err, sorry, yes, I should have said
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
diff --git a/tools/Makefile b/tools/Makefile index cb0817a..cc45758 100644 --- a/tools/Makefile +++ b/tools/Makefile @@ -63,7 +63,6 @@ install: subdirs-install $(INSTALL_DIR) -m 700 $(DESTDIR)$(XEN_DUMP_DIR) $(INSTALL_DIR) $(DESTDIR)$(XEN_LOG_DIR) $(INSTALL_DIR) $(DESTDIR)$(XEN_RUN_DIR) - $(INSTALL_DIR) $(DESTDIR)/var/lib/xen $(INSTALL_DIR) $(DESTDIR)$(XEN_LIB_DIR) .PHONY: uninstall @@ -77,7 +76,6 @@ uninstall: rm -f $(D)$(SYSCONFIG_DIR)/xendomains rm -f $(D)$(sbindir)/xendomains rm -f $(D)$(SYSCONFIG_DIR)/xencommons - rm -rf $(D)/var/lib/xen* rm -rf $(D)$(XEN_LIB_DIR) rm -rf $(D)$(XEN_LIB_STORED) rm -rf $(D)$(bindir)/cpuperf-perfcntr $(D)$(bindir)/cpuperf-xen
Now all conversations are done, remove the hard-coded paths. Signed-off-by: Wei Liu <wei.liu2@citrix.com> --- Cc: Ian Jackson <ian.jackson@eu.citrix.com> --- tools/Makefile | 2 -- 1 file changed, 2 deletions(-)