diff mbox

[04/19] xen: credit2: kill useless helper function choose_cpu

Message ID 146620510554.29766.4276980651226118049.stgit@Solace.fritz.box (mailing list archive)
State New, archived
Headers show

Commit Message

Dario Faggioli June 17, 2016, 11:11 p.m. UTC 
In fact, it has the same signature of csched2_cpu_pick,
which also is its uniqe caller.

Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
---
Cc: George Dunlap <george.dunlap@citrix.com>
Cc: Anshul Makkar <anshul.makkar@citrix.com>
Cc: David Vrabel <david.vrabel@citrix.com>
---
 xen/common/sched_credit2.c |   14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)

Comments

George Dunlap July 6, 2016, 4:02 p.m. UTC | #1 
On Sat, Jun 18, 2016 at 12:11 AM, Dario Faggioli
<dario.faggioli@citrix.com> wrote:
> In fact, it has the same signature of csched2_cpu_pick,
> which also is its uniqe caller.
>
> Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>

Reviewed-by: George Dunlap <george.dunlap@citrix.com>

And queued, fixing up the spelling of "unique".
Dario Faggioli July 7, 2016, 10:26 a.m. UTC | #2 
On Wed, 2016-07-06 at 17:02 +0100, George Dunlap wrote:
> On Sat, Jun 18, 2016 at 12:11 AM, Dario Faggioli
> <dario.faggioli@citrix.com> wrote:
> > 
> > In fact, it has the same signature of csched2_cpu_pick,
> > which also is its uniqe caller.
> > 
> > Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com>
> Reviewed-by: George Dunlap <george.dunlap@citrix.com>
> 
> And queued, fixing up the spelling of "unique".
> 
Thanks! :-)
Dario
diff mbox

Patch

diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c
index 5881583..ef199e3 100644
--- a/xen/common/sched_credit2.c
+++ b/xen/common/sched_credit2.c
@@ -321,7 +321,7 @@  struct csched2_dom {
 /*
  * When a hard affinity change occurs, we may not be able to check some
  * (any!) of the other runqueues, when looking for the best new processor
- * for svc (as trylock-s in choose_cpu() can fail). If that happens, we
+ * for svc (as trylock-s in csched2_cpu_pick() can fail). If that happens, we
  * pick, in order of decreasing preference:
  *  - svc's current pcpu;
  *  - another pcpu from svc's current runq;
@@ -1116,7 +1116,7 @@  csched2_context_saved(const struct scheduler *ops, struct vcpu *vc)
 
 #define MAX_LOAD (1ULL<<60);
 static int
-choose_cpu(const struct scheduler *ops, struct vcpu *vc)
+csched2_cpu_pick(const struct scheduler *ops, struct vcpu *vc)
 {
     struct csched2_private *prv = CSCHED2_PRIV(ops);
     int i, min_rqi = -1, new_cpu;
@@ -1490,16 +1490,6 @@  out:
     return;
 }
 
-static int
-csched2_cpu_pick(const struct scheduler *ops, struct vcpu *vc)
-{
-    int new_cpu;
-
-    new_cpu = choose_cpu(ops, vc);
-
-    return new_cpu;
-}
-
 static void
 csched2_vcpu_migrate(
     const struct scheduler *ops, struct vcpu *vc, unsigned int new_cpu)