| Message ID | 1467745519-9868-10-git-send-email-boris.ostrovsky@oracle.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
>>> On 05.07.16 at 21:05, <boris.ostrovsky@oracle.com> wrote: > --- a/tools/firmware/hvmloader/acpi/build.c > +++ b/tools/firmware/hvmloader/acpi/build.c > @@ -342,9 +342,12 @@ static int construct_secondary_tables(unsigned long *table_ptrs, > } > > /* WAET. */ > - waet = construct_waet(); > - if (!waet) return -1; > - table_ptrs[nr_tables++] = (unsigned long)waet; > + if ( config->table_flags & ACPI_BUILD_WAET ) > + { > + waet = construct_waet(); > + if ( !waet ) return -1; Now that you touch it, this should become two lines. With that Reviewed-by: Jan Beulich <jbeulich@suse.com>
diff --git a/tools/firmware/hvmloader/acpi/build.c b/tools/firmware/hvmloader/acpi/build.c index 8780984..570d26f 100644 --- a/tools/firmware/hvmloader/acpi/build.c +++ b/tools/firmware/hvmloader/acpi/build.c @@ -342,9 +342,12 @@ static int construct_secondary_tables(unsigned long *table_ptrs, } /* WAET. */ - waet = construct_waet(); - if (!waet) return -1; - table_ptrs[nr_tables++] = (unsigned long)waet; + if ( config->table_flags & ACPI_BUILD_WAET ) + { + waet = construct_waet(); + if ( !waet ) return -1; + table_ptrs[nr_tables++] = (unsigned long)waet; + } if ( config->table_flags & ACPI_BUILD_SSDT_PM ) { diff --git a/tools/firmware/hvmloader/acpi/libacpi.h b/tools/firmware/hvmloader/acpi/libacpi.h index 86f19b9..b052eab 100644 --- a/tools/firmware/hvmloader/acpi/libacpi.h +++ b/tools/firmware/hvmloader/acpi/libacpi.h @@ -36,6 +36,7 @@ #define ACPI_BUILD_SSDT_S4 (1<<2) #define ACPI_BUILD_TCPA (1<<3) #define ACPI_BUILD_IOAPIC (1<<4) +#define ACPI_BUILD_WAET (1<<5) #pragma pack () diff --git a/tools/firmware/hvmloader/util.c b/tools/firmware/hvmloader/util.c index 5aecf7b..08328f8 100644 --- a/tools/firmware/hvmloader/util.c +++ b/tools/firmware/hvmloader/util.c @@ -914,7 +914,8 @@ void hvmloader_acpi_build_tables(struct acpi_config *config, if ( !strncmp(xenstore_read("platform/acpi_s4", "1"), "1", 1) ) config->table_flags |= ACPI_BUILD_SSDT_S4; - config->table_flags |= (ACPI_BUILD_TCPA | ACPI_BUILD_IOAPIC); + config->table_flags |= (ACPI_BUILD_TCPA | ACPI_BUILD_IOAPIC | + ACPI_BUILD_WAET); config->tis_hdr = (uint16_t *)ACPI_TIS_HDR_ADDRESS;
Signed-off-by: Boris Ostrovsky <boris.ostrovsky@oracle.com> --- tools/firmware/hvmloader/acpi/build.c | 9 ++++++--- tools/firmware/hvmloader/acpi/libacpi.h | 1 + tools/firmware/hvmloader/util.c | 3 ++- 3 files changed, 9 insertions(+), 4 deletions(-)