From patchwork Wed Jul 20 13:19:11 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Jackson X-Patchwork-Id: 9239621 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id BE5FA602F0 for ; Wed, 20 Jul 2016 13:22:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AE3CB26C9B for ; Wed, 20 Jul 2016 13:22:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A161727BFF; Wed, 20 Jul 2016 13:22:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 59DD426C9B for ; Wed, 20 Jul 2016 13:22:34 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPrPn-000579-0a; Wed, 20 Jul 2016 13:19:55 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPrPm-00056m-4Y for xen-devel@lists.xenproject.org; Wed, 20 Jul 2016 13:19:54 +0000 Received: from [85.158.137.68] by server-13.bemta-3.messagelabs.com id BB/B9-06162-97A7F875; Wed, 20 Jul 2016 13:19:53 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjkeJIrShJLcpLzFFi42JxWrohUreiqj/ c4P02S4vvWyYzOTB6HP5whSWAMYo1My8pvyKBNePcicfMBRM4Ktqe7WFvYLzE1sXIySEh4C9x qO0NC4jNJqAr0bTlL1Ccg0NEQEXi9l4DkDCzgLbE3nVzmUFsYYEgia5d15lAbBYBVYlFS7eyg ti8Ap4Sj++0MEKMlJM4f/wnWD2ngJfEkZmb2EFsIaCauRtes4OMFxJQk5i7Ph6iVVDi5MwnLB CrJCQOvnjBDDGGW+L26anMExj5ZiEpm4WkbAEj0ypG9eLUorLUIl1zvaSizPSMktzEzBxdQwN jvdzU4uLE9NScxKRiveT83E2MwHBiAIIdjI3fnQ4xSnIwKYnyqor2hgvxJeWnVGYkFmfEF5Xm pBYfYpTh4FCS4L1W2R8uJFiUmp5akZaZAwxsmLQEB4+SCO9kkDRvcUFibnFmOkTqFKOilDjvK ZCEAEgiozQPrg0WTZcYZaWEeRmBDhHiKUgtys0sQZV/xSjOwagkzFsMMoUnM68EbvoroMVMQI vnCIAtLklESEk1MBpVxD9lE7F7ZK/882nkLg2DRwzPXvXNTj5z6W19hm8J8zotl/8rRbJdfqm c6WB9t/Jt67ab/4okwpKTPV2OcR6RS5q0nuXDvr8mzc6VvH6nUqvf6k7s5v7Kkbkz7esB4eaI Fft3qa9zCd/SolYduSSCX5ytuHoF13elxAPcs0IW/j7Bk2iYrsRSnJFoqMVcVJwIAEpHcB6hA gAA X-Env-Sender: prvs=00244cc2b=Ian.Jackson@citrix.com X-Msg-Ref: server-2.tower-31.messagelabs.com!1469020791!51521765!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 8.77; banners=-,-,- X-VirusChecked: Checked Received: (qmail 31029 invoked from network); 20 Jul 2016 13:19:52 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-2.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 20 Jul 2016 13:19:52 -0000 X-IronPort-AV: E=Sophos;i="5.28,394,1464652800"; d="scan'208";a="367283015" From: Ian Jackson To: Date: Wed, 20 Jul 2016 14:19:11 +0100 Message-ID: <1469020751-12413-5-git-send-email-ian.jackson@eu.citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1469020751-12413-1-git-send-email-ian.jackson@eu.citrix.com> References: <1469020751-12413-1-git-send-email-ian.jackson@eu.citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: Ian Jackson Subject: [Xen-devel] [OSSTEST PATCH 5/5] mg-list-all-branches: Do not match ${BRANCHES+= ... } X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP This is not valid shell syntax and should not appear. The confusion seems to have arisen because of the need for to match BRANCHES+=... (without the surrounding { }). This results in no change to the output. (I seem to have collected this patch some time ago as part of some fixes to mg-list-all-branches which have by now been applied, but not managed to write up and post this specific change.) Signed-off-by: Ian Jackson --- mg-list-all-branches | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mg-list-all-branches b/mg-list-all-branches index 62d3ff1..989b5ae 100755 --- a/mg-list-all-branches +++ b/mg-list-all-branches @@ -14,7 +14,7 @@ foreach my $f (qw(cr-for-branches crontab)) { open C, $f or die $!; while () { next unless - m/\$\{$branchvar_re[:+]?=()($branchchr_re+)\b/ || + m/\$\{$branchvar_re:=()($branchchr_re+)\b/ || m/$branchvar_re[:+]?=('?)($branchchr_re+?)\1\s/; $branches{$_}=1 foreach split /\s+/, $2; }