From patchwork Wed Jul 20 14:13:42 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Liu X-Patchwork-Id: 9239679 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E5461602F0 for ; Wed, 20 Jul 2016 14:16:15 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D775A20649 for ; Wed, 20 Jul 2016 14:16:15 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CC23927BF7; Wed, 20 Jul 2016 14:16:15 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 28C55268AE for ; Wed, 20 Jul 2016 14:16:13 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPsFy-00033S-7a; Wed, 20 Jul 2016 14:13:50 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bPsFx-00032x-9D for xen-devel@lists.xenproject.org; Wed, 20 Jul 2016 14:13:49 +0000 Received: from [85.158.137.68] by server-5.bemta-3.messagelabs.com id 72/F3-03281-C178F875; Wed, 20 Jul 2016 14:13:48 +0000 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNIsWRWlGSWpSXmKPExsXitHSDva5Me3+ 4wdofvBbft0xmcmD0OPzhCksAYxRrZl5SfkUCa8bDndeZCiaxVazd6dTAOJO1i5GTQ0LAX+LV 0h5mEJtNQFniZ2cvG4gtIqAn0XTgOSOIzSzgJfFi3T8wW1jAVWLGxclg9SwCqhL9/3+C2bwCT hI/7t2Gmikncf44RJxTwFnixcvLYL1CQDXnTzYwQdgKEh3TjzFB9ApKnJz5hAVil4TEwRcvgH o5gOZwS/zttp/AyDcLSdUsJFULGJlWMWoUpxaVpRbpGhrqJRVlpmeU5CZm5ugaGhjr5aYWFye mp+YkJhXrJefnbmIEBhQDEOxgXP3b6RCjJAeTkiivqmhvuBBfUn5KZUZicUZ8UWlOavEhRhkO DiUJ3let/eFCgkWp6akVaZk5wNCGSUtw8CiJ8HK3AaV5iwsSc4sz0yFSpxh1ORb8uL2WSYglL z8vVUqc9xzIDAGQoozSPLgRsDi7xCgrJczLCHSUEE9BalFuZgmq/CtGcQ5GJWHe6yBTeDLzSu A2vQI6ggnoiDkCYEeUJCKkpBoYV5kmXs9VfN/3JztHikdPY2+s4rrKKxF5jBFyYWK/H5+ZsPF Tn0Tp5qWHmZVeKD/ZIrjse7p5OZv4ytPcVWWpJ8SquT9V3E3tT4yO+s0rN/PO6uMvWo6Y7lv8 8lRbUevnPO7lp8wkJjFefiN8ovdRq2+6cJ4/85deviifDfXCjecCHt/a+Pa+EktxRqKhFnNRc SIA0vgdeq4CAAA= X-Env-Sender: prvs=002eeef3a=wei.liu2@citrix.com X-Msg-Ref: server-3.tower-31.messagelabs.com!1469024025!51547923!2 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 8.77; banners=-,-,- X-VirusChecked: Checked Received: (qmail 49780 invoked from network); 20 Jul 2016 14:13:47 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-3.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 20 Jul 2016 14:13:47 -0000 X-IronPort-AV: E=Sophos;i="5.28,394,1464652800"; d="scan'208";a="374290962" From: Wei Liu To: Xen-devel Date: Wed, 20 Jul 2016 15:13:42 +0100 Message-ID: <1469024022-6505-3-git-send-email-wei.liu2@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1469024022-6505-1-git-send-email-wei.liu2@citrix.com> References: <1469024022-6505-1-git-send-email-wei.liu2@citrix.com> MIME-Version: 1.0 X-DLP: MIA1 Cc: Ian Jackson , Wei Liu Subject: [Xen-devel] [PATCH 2/2] xenstore: add assertion in database dumping code X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" X-Virus-Scanned: ClamAV using ClamSMTP If memfile is NULL, the signal handler won't be installed, hence fopen won't dereference NULL. Coverity is not smart enough to figure that out unfortunately. Add an assertion to prevent coverity from complaining. Signed-off-by: Wei Liu Acked-by: Ian Jackson --- Cc: Ian Jackson --- tools/xenstore/xenstored_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/xenstore/xenstored_core.c b/tools/xenstore/xenstored_core.c index 5b2a49b..693d47d 100644 --- a/tools/xenstore/xenstored_core.c +++ b/tools/xenstore/xenstored_core.c @@ -2135,6 +2135,7 @@ int main(int argc, char *argv[]) if (trigger_talloc_report) { FILE *out; + assert(memfile); trigger_talloc_report = false; out = fopen(memfile, "a"); if (out) {